New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786544 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mash: Check failed in aura::WindowPortMus::SetFrameSinkIdFromServer for browser_tests that use fullscreen

Project Member Reported by jamescook@chromium.org, Nov 17 2017

Issue description

I've seen this across several browser_tests --mash, usually in ones that open a fullscreen window. For example:

ExtensionInstallUIBrowserTest.*
ImmersiveModeBrowserViewTest.*

[56492:56492:1117/132440.577515:FATAL:window_port_mus.cc(296)] Check failed: window_mus_type() == WindowMusType::TOP_LEVEL_IN_WM || window_mus_type() == WindowMusType::EMBED_IN_OWNER. 
#0 0x7f2030776f3c base::debug::StackTrace::StackTrace()
#1 0x7f203079d92c logging::LogMessage::~LogMessage()
#2 0x7f202b0f7ad1 aura::WindowPortMus::SetFrameSinkIdFromServer()
#3 0x7f202b10474e aura::WindowTreeClient::WmCreateTopLevelWindow()
#4 0x7f202b126999 ui::mojom::WindowManagerStubDispatch::Accept()
#5 0x7f202e0ea42b mojo::InterfaceEndpointClient::HandleValidatedMessage()
#6 0x7f202e0e9d26 mojo::FilterChain::Accept()
#7 0x7f202e0eb795 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#8 0x7f202e0f59b2 mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#9 0x7f202e0f4ee4 mojo::internal::MultiplexRouter::Accept()
#10 0x7f202e0e9d26 mojo::FilterChain::Accept()
#11 0x7f202e0e4dd5 mojo::Connector::ReadSingleMessage()
#12 0x7f202e0e58c1 mojo::Connector::ReadAllAvailableMessages()
#13 0x7f202e0e5769 mojo::Connector::OnHandleReadyInternal()
#14 0x7f202e0e5f67 mojo::SimpleWatcher::DiscardReadyState()
#15 0x7f202e0ae8b2 mojo::SimpleWatcher::OnHandleReady()
#16 0x7f202e0aedd1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE
#17 0x7f2030777815 base::debug::TaskAnnotator::RunTask()
#18 0x7f20307a8ee9 base::internal::IncomingTaskQueue::RunTask()
#19 0x7f20307ac958 base::MessageLoop::RunTask()

erg mentioned in  issue 640365  that he's seen this when entering immersive mode with --mash, with the window type being LOCAL.

sky, feel free to reassign if you're not the right person for this.

 
Cc: e...@chromium.org
Owner: sky@chromium.org
er, really assign to sky for triage

Comment 2 by sky@chromium.org, Nov 28 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e645f7ae50fd939ed5c31ebbb4d3185cfc7e7ed0

commit e645f7ae50fd939ed5c31ebbb4d3185cfc7e7ed0
Author: Scott Violet <sky@chromium.org>
Date: Tue Nov 28 21:18:28 2017

chromeos: set kEmbedType property for DetachedTitleAreaRendererForClient

All other code paths properly set it. Without this we hit DCHECKs as
the type isn't set.

BUG= 786544 
TEST=covered by tests

Change-Id: Ia3837afa9641c6fef83ed4441dbcb5ab1d5d9cd4
Reviewed-on: https://chromium-review.googlesource.com/794520
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519842}
[modify] https://crrev.com/e645f7ae50fd939ed5c31ebbb4d3185cfc7e7ed0/ash/frame/detached_title_area_renderer.cc

Comment 4 by sky@chromium.org, Nov 28 2017

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0ce0f4d0772ad4f09e063ccf4449ed9fe3825da

commit d0ce0f4d0772ad4f09e063ccf4449ed9fe3825da
Author: James Cook <jamescook@chromium.org>
Date: Sat Dec 02 00:16:42 2017

mash: Update browser_tests FYI filter for immersive tests

Several tests can be re-enabled now that  crbug.com/786544  is fixed

Also rename a bluetooth test exclusion because the underlying
bluetooth test was renamed.

Bug:  786544 
Test: browser_tests --mash
Change-Id: I68cd79028e15636c810257a95aa64bfed6862e69
Reviewed-on: https://chromium-review.googlesource.com/803668
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521138}
[modify] https://crrev.com/d0ce0f4d0772ad4f09e063ccf4449ed9fe3825da/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment