mash: Check failed in aura::WindowPortMus::SetFrameSinkIdFromServer for browser_tests that use fullscreen |
||||||
Issue descriptionI've seen this across several browser_tests --mash, usually in ones that open a fullscreen window. For example: ExtensionInstallUIBrowserTest.* ImmersiveModeBrowserViewTest.* [56492:56492:1117/132440.577515:FATAL:window_port_mus.cc(296)] Check failed: window_mus_type() == WindowMusType::TOP_LEVEL_IN_WM || window_mus_type() == WindowMusType::EMBED_IN_OWNER. #0 0x7f2030776f3c base::debug::StackTrace::StackTrace() #1 0x7f203079d92c logging::LogMessage::~LogMessage() #2 0x7f202b0f7ad1 aura::WindowPortMus::SetFrameSinkIdFromServer() #3 0x7f202b10474e aura::WindowTreeClient::WmCreateTopLevelWindow() #4 0x7f202b126999 ui::mojom::WindowManagerStubDispatch::Accept() #5 0x7f202e0ea42b mojo::InterfaceEndpointClient::HandleValidatedMessage() #6 0x7f202e0e9d26 mojo::FilterChain::Accept() #7 0x7f202e0eb795 mojo::InterfaceEndpointClient::HandleIncomingMessage() #8 0x7f202e0f59b2 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #9 0x7f202e0f4ee4 mojo::internal::MultiplexRouter::Accept() #10 0x7f202e0e9d26 mojo::FilterChain::Accept() #11 0x7f202e0e4dd5 mojo::Connector::ReadSingleMessage() #12 0x7f202e0e58c1 mojo::Connector::ReadAllAvailableMessages() #13 0x7f202e0e5769 mojo::Connector::OnHandleReadyInternal() #14 0x7f202e0e5f67 mojo::SimpleWatcher::DiscardReadyState() #15 0x7f202e0ae8b2 mojo::SimpleWatcher::OnHandleReady() #16 0x7f202e0aedd1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #17 0x7f2030777815 base::debug::TaskAnnotator::RunTask() #18 0x7f20307a8ee9 base::internal::IncomingTaskQueue::RunTask() #19 0x7f20307ac958 base::MessageLoop::RunTask() erg mentioned in issue 640365 that he's seen this when entering immersive mode with --mash, with the window type being LOCAL. sky, feel free to reassign if you're not the right person for this.
,
Nov 28 2017
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e645f7ae50fd939ed5c31ebbb4d3185cfc7e7ed0 commit e645f7ae50fd939ed5c31ebbb4d3185cfc7e7ed0 Author: Scott Violet <sky@chromium.org> Date: Tue Nov 28 21:18:28 2017 chromeos: set kEmbedType property for DetachedTitleAreaRendererForClient All other code paths properly set it. Without this we hit DCHECKs as the type isn't set. BUG= 786544 TEST=covered by tests Change-Id: Ia3837afa9641c6fef83ed4441dbcb5ab1d5d9cd4 Reviewed-on: https://chromium-review.googlesource.com/794520 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#519842} [modify] https://crrev.com/e645f7ae50fd939ed5c31ebbb4d3185cfc7e7ed0/ash/frame/detached_title_area_renderer.cc
,
Nov 28 2017
,
Dec 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0ce0f4d0772ad4f09e063ccf4449ed9fe3825da commit d0ce0f4d0772ad4f09e063ccf4449ed9fe3825da Author: James Cook <jamescook@chromium.org> Date: Sat Dec 02 00:16:42 2017 mash: Update browser_tests FYI filter for immersive tests Several tests can be re-enabled now that crbug.com/786544 is fixed Also rename a bluetooth test exclusion because the underlying bluetooth test was renamed. Bug: 786544 Test: browser_tests --mash Change-Id: I68cd79028e15636c810257a95aa64bfed6862e69 Reviewed-on: https://chromium-review.googlesource.com/803668 Reviewed-by: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#521138} [modify] https://crrev.com/d0ce0f4d0772ad4f09e063ccf4449ed9fe3825da/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter
,
Jan 22 2018
,
Jan 23 2018
,
Feb 26 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jamescook@chromium.org
, Nov 27 2017Owner: sky@chromium.org