PR approved: https://github.com/WebAudio/web-audio-api/pull/1445 - Create `AudioWorklet` interface - Window.audioWorklet now becomes BaseAudioContext.audioWorklet
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/249e75ed36a08aed24a4c6f81aca47b384bd2ad8 commit 249e75ed36a08aed24a4c6f81aca47b384bd2ad8 Author: Hongchan Choi <hongchan@chromium.org> Date: Fri Dec 01 21:58:54 2017 Move audioWorklet under BaseAudioContext Spec PR (approved): https://github.com/WebAudio/web-audio-api/pull/1445 Based on the spec change, this CL moves audioWorklet from `window` to `BaseAudioContext`. This alters the relationship between BaseAudioContext, AudioWorkletMessagingProxy and AudioWorkletGlobalScope: - Now AWMP/AWGS cannot exist without BaseAudioContext, this reduces the code complexity by removing checks. - With this clear ownership, BaseAudioContext only needs to talk to AudioWorklet. AudioWorkletMessagingProxy can be hidden. - When the script evaluation is completed, AWGS will notify the associated BaseAudioContext via AWObjectProxy - AWMessagingProxy. Bug: 786542 Change-Id: I7b55fcacf304a4a25b527bcbcd285bef80881b8d Reviewed-on: https://chromium-review.googlesource.com/779862 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Raymond Toy <rtoy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#521078} [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-common.js [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-gain-node.html [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-node-construction.html [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-node-options.html [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-processor-state.html [add] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/context-audio-worklet.html [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/dynamic-channel-count.html [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/message-port.html [delete] https://crrev.com/fe1dd7780f6713d4e4518bad931dcadfd80f9985/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/window-audio-worklet.html [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/worklet-context-interaction.html [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/http/tests/worklet/import-on-insecure-context.html [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/webaudio/AudioParam/worklet-warnings.html [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/modules_idl_files.gni [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/AudioWorklet.cpp [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/AudioWorklet.h [rename] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/AudioWorklet.idl [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.h [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.cpp [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/BUILD.gn [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp [modify] https://crrev.com/249e75ed36a08aed24a4c6f81aca47b384bd2ad8/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp [delete] https://crrev.com/fe1dd7780f6713d4e4518bad931dcadfd80f9985/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.cpp [delete] https://crrev.com/fe1dd7780f6713d4e4518bad931dcadfd80f9985/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.h
Please add affected OSs.
This is Web Platform API, so affects all platforms ship with Blink.
cmasso@ Thanks for the approval, but what's the branch ref?
I am assuming the branch number is: 3282.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a637921fd31d5dbea6440dc11097b134bd603ca6 commit a637921fd31d5dbea6440dc11097b134bd603ca6 Author: Hongchan Choi <hongchan@chromium.org> Date: Tue Dec 05 22:51:18 2017 Move audioWorklet under BaseAudioContext Spec PR (approved): https://github.com/WebAudio/web-audio-api/pull/1445 Based on the spec change, this CL moves audioWorklet from `window` to `BaseAudioContext`. This alters the relationship between BaseAudioContext, AudioWorkletMessagingProxy and AudioWorkletGlobalScope: - Now AWMP/AWGS cannot exist without BaseAudioContext, this reduces the code complexity by removing checks. - With this clear ownership, BaseAudioContext only needs to talk to AudioWorklet. AudioWorkletMessagingProxy can be hidden. - When the script evaluation is completed, AWGS will notify the associated BaseAudioContext via AWObjectProxy - AWMessagingProxy. Bug: 786542 Change-Id: I7b55fcacf304a4a25b527bcbcd285bef80881b8d Reviewed-on: https://chromium-review.googlesource.com/779862 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Raymond Toy <rtoy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521078}(cherry picked from commit 249e75ed36a08aed24a4c6f81aca47b384bd2ad8) Reviewed-on: https://chromium-review.googlesource.com/809752 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#41} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-common.js [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-gain-node.html [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-node-construction.html [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-node-options.html [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/audio-worklet-processor-state.html [add] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/context-audio-worklet.html [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/dynamic-channel-count.html [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/message-port.html [delete] https://crrev.com/f0faec296239720f9889b0fec1bad6f91a1dcbb7/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/window-audio-worklet.html [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/http/tests/webaudio/audio-worklet/worklet-context-interaction.html [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/http/tests/worklet/import-on-insecure-context.html [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/webaudio/AudioParam/worklet-warnings.html [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/modules_idl_files.gni [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/AudioWorklet.cpp [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/AudioWorklet.h [rename] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/AudioWorklet.idl [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.h [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.cpp [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/BUILD.gn [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp [modify] https://crrev.com/a637921fd31d5dbea6440dc11097b134bd603ca6/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp [delete] https://crrev.com/f0faec296239720f9889b0fec1bad6f91a1dcbb7/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.cpp [delete] https://crrev.com/f0faec296239720f9889b0fec1bad6f91a1dcbb7/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.h
Comment 1 by bugdroid1@chromium.org
, Dec 1 2017