Issue metadata
Sign in to add a comment
|
WebglConformance_conformance_glsl_misc_struct_nesting_of_variable_names fails on Android GPU.FYI bots |
||||||||||||||||||||
Issue descriptionhttps://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%205%29/builds/8102 Suspecting https://chromium-review.googlesource.com/766434 [369/912] gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_glsl_misc_struct_nesting_of_variable_names failed unexpectedly 16.1940s: Traceback (most recent call last): _RunGpuTest at content/test/gpu/gpu_tests/gpu_integration_test.py:132 self.RunActualGpuTest(url, *args) RunActualGpuTest at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:203 getattr(self, test_name)(test_path, *args[1:]) _RunConformanceTest at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:217 self._CheckTestCompletion() _CheckTestCompletion at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:213 self.fail(self._WebGLTestMessages(self.tab)) fail at /usr/lib/python2.7/unittest/case.py:412 raise self.failureException(msg) AssertionError: [unexpected fragment shader compile status] (expected: true) Outer struct type: float inner struct type: float *** Error compiling FRAGMENT_SHADER '[object WebGLShader]':Fragment shader compilation failed. ERROR: 0:7: 'webgl_bc2ee2bf060ca60' : Syntax error: syntax error ERROR: 1 compilation errors. No code generated.
,
Nov 20 2017
Looks like the change to remove unreferenced variables has uncovered a driver bug. Rather than making a specific workaround for this, this might be easiest to fix by expanding pruning unreferenced variables so that unreferenced named struct types would also be pruned.
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/39f74df5f715e73f2e493961e8bca38f90061e17 commit 39f74df5f715e73f2e493961e8bca38f90061e17 Author: Olli Etuaho <oetuaho@nvidia.com> Date: Tue Nov 21 17:17:36 2017 Remove unreferenced struct types from the AST This expands pruning unreferenced variables so that unreferenced named struct types can also be removed from the AST. Includes a small cleanup in GLSL output so that the output code matching tests can test against clean output. BUG= chromium:786535 TEST=angle_unittests Change-Id: I20974ac99a797e478d82f9203c179d2d58fac268 Reviewed-on: https://chromium-review.googlesource.com/779519 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> [modify] https://crrev.com/39f74df5f715e73f2e493961e8bca38f90061e17/src/tests/compiler_tests/RemoveUnreferencedVariables_test.cpp [modify] https://crrev.com/39f74df5f715e73f2e493961e8bca38f90061e17/src/compiler/translator/OutputGLSLBase.h [modify] https://crrev.com/39f74df5f715e73f2e493961e8bca38f90061e17/src/compiler/translator/OutputGLSLBase.cpp [modify] https://crrev.com/39f74df5f715e73f2e493961e8bca38f90061e17/src/compiler/translator/RemoveUnreferencedVariables.h [modify] https://crrev.com/39f74df5f715e73f2e493961e8bca38f90061e17/src/compiler/translator/RemoveUnreferencedVariables.cpp
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3bb6ffbf9f5c462508be96fe54318fa53d15c0f commit a3bb6ffbf9f5c462508be96fe54318fa53d15c0f Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Tue Nov 21 20:07:01 2017 Roll src/third_party/angle/ 03fd0356b..378734c51 (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/03fd0356b4c9..378734c51221 $ git log 03fd0356b..378734c51 --date=short --no-merges --format='%ad %ae %s' 2017-11-20 jmadill D3D11: Lazy evaluation for draw call vertex params. 2017-11-20 oetuaho Remove unreferenced struct types from the AST Created with: roll-dep src/third_party/angle BUG= 786535 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I6242b15e81048eee80e86cca5198bfbe8699a90c Reviewed-on: https://chromium-review.googlesource.com/782443 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518351} [modify] https://crrev.com/a3bb6ffbf9f5c462508be96fe54318fa53d15c0f/DEPS
,
Nov 21 2017
Thanks, Olli, test passes now! https://ci.chromium.org/buildbot/chromium.gpu.fyi/Android%20Release%20%28Nexus%206%29/10601 https://ci.chromium.org/buildbot/chromium.gpu.fyi/Android%20Release%20%28Nexus%205%29/8148
,
Nov 22 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/d86a4f7c4a8f3cb08c88579f1f0d514a7bfc20af commit d86a4f7c4a8f3cb08c88579f1f0d514a7bfc20af Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Wed Nov 22 18:06:14 2017 Roll skia/third_party/externals/angle2/ c7965001b..5a654f5ff (16 commits) https://chromium.googlesource.com/angle/angle.git/+log/c7965001b32f..5a654f5ff30f $ git log c7965001b..5a654f5ff --date=short --no-merges --format='%ad %ae %s' 2017-11-22 geofflang Fix reinterpret_cast size missmatch warning on 64-bit Windows. 2017-11-21 geofflang Optimize Texture initialization tracking with extra caching. 2017-09-26 oetuaho Support arrays of arrays in the API 2017-11-21 jmadill Apply Chromium style fixes. 2017-11-21 jmadill Fix ComputeGenericHash. 2017-11-06 jiawei.shao ES31: Implement creation and attaching geometry shader on OpenGL 2017-11-21 jmadill Reland "Update cq.cfg for new compile-only builders." 2017-11-22 jmadill Revert "Update cq.cfg for new compile-only builders." 2017-11-21 jmadill Update cq.cfg for new compile-only builders. 2017-11-18 jmadill Reland "Make TType store a const char * for mangled name." 2017-11-21 geofflang Add configurations of the TexturePerf benchmark that use robust init. 2017-11-20 jmadill Vulkan: Refactor CommandBuffer helper class. 2017-11-21 jmadill Fix Clang dEQP build on Win. 2017-11-20 jmadill D3D11: Lazy evaluation for draw call vertex params. 2017-11-20 oetuaho Remove unreferenced struct types from the AST 2017-11-20 jmadill D3D11: Push index range computation deeper. Created with: roll-dep skia/third_party/externals/angle2 BUG= 786535 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=herb@google.com Change-Id: I7f82e0f643cee78f1434317879343d1060e8463f Reviewed-on: https://skia-review.googlesource.com/75301 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> [modify] https://crrev.com/d86a4f7c4a8f3cb08c88579f1f0d514a7bfc20af/DEPS
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29f24ef75e14192ab58dc4f1d7c9e5ca52433655 commit 29f24ef75e14192ab58dc4f1d7c9e5ca52433655 Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Wed Nov 22 22:17:02 2017 Roll src/third_party/skia/ a0ec54829..4f99e5825 (12 commits) https://skia.googlesource.com/skia.git/+log/a0ec54829eb7..4f99e5825217 $ git log a0ec54829..4f99e5825 --date=short --no-merges --format='%ad %ae %s' 2017-11-22 brianosman Remove a huge pile of views code 2017-11-22 fmalita Use SkSafeMath for text blob storage calculations 2017-11-22 angle-deps-roller Roll skia/third_party/externals/angle2/ c7965001b..5a654f5ff (16 commits) 2017-11-22 liyuqian Add threaded backend to viewer 2017-11-22 fmalita Fix SkTextblob deserialization fuzzer issues 2017-11-22 brianosman Fix XferDemo by sending push button events directly to parent 2017-11-21 brianosman Remove obsolete iOSShell references from infra scripts 2017-11-21 brianosman VisualBench is not a thing anymore 2017-11-22 jvanverth Viewer doc cleanup. 2017-11-22 update-skps Update SKP version 2017-11-22 kjlubick Fix scaling on Nexus 7 bots 2017-11-21 jvanverth Update Viewer docs. Created with: roll-dep src/third_party/skia BUG= 786535 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I403c081661be251c7b3dbb75b7f1fdfc4a34ca4a Reviewed-on: https://chromium-review.googlesource.com/786254 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518769} [modify] https://crrev.com/29f24ef75e14192ab58dc4f1d7c9e5ca52433655/DEPS |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ynovikov@chromium.org
, Nov 17 2017