Not possible to call voice input after reentering VR |
|||||
Issue descriptionChrome Version: 64.0.3271.0 VRCore: 1.10.172754103 OS: Android O Platform: Pixel 2 XL What steps will reproduce the problem? 1. Make sure Chrome doesn't have access to microphone 2. Insert device into the headset and click Voice search icon => Popup informing the user they need to exit VR to give permission should appear, it has continue or cancel options. 3. Don't click "Cancel" or "Continue" buttons, remove device from the headset and exit Chrome VR using system back button or "cross" button in the upper left corner of the screen => Permission popup is absent in 2D Clank 4. Insert device in the headset and enter Chrome VR again 5. Click Voice input button What is the expected result? Popup informing the user they need to exit VR to give permission should appear again What happens instead? Nothing happens, clicks are ignored
,
Nov 20 2017
Thanks for the report! Can you clarify how did you enter Chrome VR again at step 4? Usually, if you exit VR, you should see a permission popup. And I am not sure if there is a way to enter VR without interact with the permission popup first.
,
Nov 20 2017
I updated description. Permission popup in 2D is absent after step #3, because we didn't click "Continue" button.
,
Nov 20 2017
,
Nov 20 2017
ha. I misunderstood step 3. Although, I am seeing a crash currently if I want to force exit VR at step 3.
,
Nov 20 2017
I'm trying most recent Chrome Dev 64.0.3272.0 and I don't see a crash.
,
Nov 20 2017
It only crashes on a debug build. And the reason it stopped working is because a condition which should be true is no longer true. We use DCHECK to make sure that condition is true. So only debug version can trigger crash while canary/dev still running but entering into a bad state.
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fefee0825b80ec3ebec5c661526818da9490180 commit 2fefee0825b80ec3ebec5c661526818da9490180 Author: Biao She <bshe@chromium.org> Date: Mon Nov 20 23:48:31 2017 Reset OnExitVrRequestListener when exit VR from top-right close button or back button Bug: 786495 Change-Id: I17bdf258d0e6f3321c7b2f06821ccc75c00ba972 Reviewed-on: https://chromium-review.googlesource.com/779088 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#517996} [modify] https://crrev.com/2fefee0825b80ec3ebec5c661526818da9490180/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Nov 21 2017
,
Dec 4 2017
verified on 64.0.3282.7
,
Dec 4 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ddorwin@chromium.org
, Nov 17 2017Labels: -Pri-3 Pri-1
Owner: bshe@chromium.org
Status: Assigned (was: Untriaged)