New issue
Advanced search Search tips

Issue 786485 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:7796


Sign in to add a comment

git-cl-upload reverted CL description

Project Member Reported by eugene...@chromium.org, Nov 17 2017 
Affected Version:

What steps will reproduce the problem?
1. Updated CL description in Gerrit
2. Reply


What do you see instead?
Description showed up in the email, but did not change in Gerrit

Please provide any additional information below.
https://chromium-review.googlesource.com/c/chromium/src/+/758718/8

Comment 1 by logan@google.com, Nov 17 2017

Components: -PolyGerrit
Labels: Proj-Gerrit-Migration
It happened when you uploaded PS8: https://chromium-review.googlesource.com/c/chromium/src/+/758718/7..8//COMMIT_MSG

I presume you used git cl upload? That usually respects the commit message that's already in Gerrit. Let me send this over to chrome-infra to determine whether your workflow is working as intended.

Comment 2 by logan@google.com, Nov 17 2017

Project: chromium
Moved issue gerrit:7796 to now be  issue chromium:786485 .

Comment 3 by aga...@chromium.org, Jan 3 2018

Components: Infra>SDK
Labels: -Proj-Gerrit-Migration
Status: Unconfirmed (was: New)
Summary: git-cl-upload reverted CL description (was: Gerrit reverted CL description)
This is a simple race: your git-cl-upload fetched (and therefore reused) and older version of the commit description.

Had you already started running git-cl-upload when you edited the message online? If so, there's not a lot we can do about that.

The other possibility is that it's due to gerrit replication lag, in which case we can follow up internally with them.

Comment 4 by eugene...@chromium.org, Jan 3 2018 

Sorry, I do not remember details. The issue happened more than a month ago.

Comment 5 by aga...@chromium.org, Jan 3 2018

Status: WontFix (was: Unconfirmed)
Darn. Sorry about the slow response, this ended up with a label but not the component that I regularly triage. Definitely let me know if you see this happen again.

Comment 6 by aga...@chromium.org, Jan 3 2018 

 Issue 761079  has been merged into this issue.
►

Sign in to add a comment