New issue
Advanced search Search tips

Issue 786482 link

Starred by 1 user
Status: Fixed
Owner:
xingliu@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Build download source for better content download metrics

Project Member Reported by xingliu@chromium.org, Nov 17 2017 
Currently there is an issue that we don't separate different source for key metrics for content download, and they can behave really differently.

For example, extension webstore installer will interact with google server, but user can download from any server. So each of these different source will affect the general metric and we don't know what's going on for a specific source or use case.

Also the new UKM download metric may use this enum.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a08c5cc742e31fa22f686c30e6fbcd57affe82b

commit 3a08c5cc742e31fa22f686c30e6fbcd57affe82b
Author: Xing Liu <xingliu@chromium.org>
Date: Wed Nov 29 00:39:55 2017

Download source enum for download better metrics.

This CL introduces a new enum that track the download source.

Currently it lives in content/public/browser, and passed in from
content::DownloadUrlParameters. In components/download, there is a one
to one mapping enum for usage in download in progress db, which can not
depend on content/public.

This enum is supposed to used in UMA as suffix for several key metrics
and UKM as Components, and saved in the new in progress level db.

Bug:  786482 
Change-Id: I19a2f959eb9e7b0787087cad6c9519acbde13281
Reviewed-on: https://chromium-review.googlesource.com/777548
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519928}
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/components/download/components_unittests.filter
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/components/download/downloader/in_progress/BUILD.gn
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/components/download/downloader/in_progress/download_entry.cc
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/components/download/downloader/in_progress/download_entry.h
[add] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/components/download/downloader/in_progress/download_source.h
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/components/download/downloader/in_progress/in_progress_conversions.cc
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/components/download/downloader/in_progress/in_progress_conversions.h
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/components/download/downloader/in_progress/in_progress_conversions_unittest.cc
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/components/download/downloader/in_progress/proto/BUILD.gn
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/components/download/downloader/in_progress/proto/download_entry.proto
[add] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/components/download/downloader/in_progress/proto/download_source.proto
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/content/browser/download/download_stats.cc
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/content/browser/download/download_stats.h
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/content/browser/download/download_utils.cc
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/content/browser/download/download_utils.h
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/content/public/browser/BUILD.gn
[add] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/content/public/browser/download_source.h
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/content/public/browser/download_url_parameters.cc
[modify] https://crrev.com/3a08c5cc742e31fa22f686c30e6fbcd57affe82b/content/public/browser/download_url_parameters.h
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcca7e4d8ec5df259ea52029de6696f54f094aee

commit dcca7e4d8ec5df259ea52029de6696f54f094aee
Author: Xing Liu <xingliu@chromium.org>
Date: Wed Jan 17 19:19:21 2018

Download metric: Use new DownloadSource enum.

In addition to current key metrics of content download system, specific
use cases are recorded with suffixes.

TBR=lazyboy@chromium.org, carlosk@chromium.org

Bug:  786482 
Change-Id: I191e4eb1d04a2c90ab2b945c154b909aa4332094
Reviewed-on: https://chromium-review.googlesource.com/851061
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529846}
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/chrome/browser/download/download_stats.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/chrome/browser/extensions/webstore_installer.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/components/download/content/internal/download_driver_impl.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/components/download/downloader/in_progress/download_entry.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/components/download/downloader/in_progress/download_entry.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/components/download/downloader/in_progress/download_source.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/components/download/downloader/in_progress/in_progress_conversions.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/components/download/downloader/in_progress/in_progress_conversions_unittest.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/components/download/downloader/in_progress/proto/download_source.proto
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_create_info.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_item_impl.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_manager_impl.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_request_core.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_request_core.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_resource_handler.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_response_handler.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_stats.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_stats.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_utils.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_utils.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/download_worker.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/drag_download_file.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/url_downloader.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/download/url_downloader.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/content/public/browser/download_source.h
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/dcca7e4d8ec5df259ea52029de6696f54f094aee/tools/metrics/histograms/histograms.xml

Comment 3 by xingliu@chromium.org, Mar 15 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment