This bug tracks the progress of the implementation of the AssistRanker as defined in go/chrome-ranker.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6956483a59954af83c442d1afb670645f533342f commit 6956483a59954af83c442d1afb670645f533342f Author: Philippe Hamel <hamelphi@chromium.org> Date: Wed Nov 22 20:39:48 2017 Move machine_intelligence component to assist_ranker. This CL is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/729060 where it was proposed by jochen@ to rename the component. Machine_intelligence was too broad, since this component is meant to hold only the AssistRanker code (go/chrome-ranker). This change only moves files and renames the namespace. It should not have any functional impact. Bug: 786472 Change-Id: Id79819b2271cfc3a45879ad390687f414aef52d7 Reviewed-on: https://chromium-review.googlesource.com/777440 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518731} [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/chrome/browser/BUILD.gn [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.h [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/chrome/browser/assist_ranker/OWNERS [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/chrome/browser/assist_ranker/assist_ranker_service_factory.cc [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/chrome/browser/assist_ranker/assist_ranker_service_factory.h [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/BUILD.gn [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/BUILD.gn [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/DEPS [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/OWNERS [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/assist_ranker_service.h [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/assist_ranker_service_impl.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/assist_ranker_service_impl.h [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/base_predictor.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/base_predictor.h [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/binary_classifier_predictor.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/binary_classifier_predictor.h [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/binary_classifier_predictor_unittest.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/fake_ranker_model_loader.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/fake_ranker_model_loader.h [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/generic_logistic_regression_inference.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/generic_logistic_regression_inference.h [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/generic_logistic_regression_inference_unittest.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/proto/BUILD.gn [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/proto/generic_logistic_regression_model.proto [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/proto/ranker_example.proto [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/proto/ranker_model.proto [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/proto/translate_ranker_model.proto [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_example_util.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_example_util.h [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_example_util_unittest.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_model.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_model.h [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_model_loader.h [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_model_loader_impl.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_model_loader_impl.h [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_model_loader_impl_unittest.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_model_unittest.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_url_fetcher.cc [rename] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/assist_ranker/ranker_url_fetcher.h [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/translate/core/browser/BUILD.gn [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/translate/core/browser/DEPS [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/translate/core/browser/translate_ranker_impl.cc [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/translate/core/browser/translate_ranker_impl.h [modify] https://crrev.com/6956483a59954af83c442d1afb670645f533342f/components/translate/core/browser/translate_ranker_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90c56c8fefa26fc1cd2427ca3e8626172751dfec commit 90c56c8fefa26fc1cd2427ca3e8626172751dfec Author: Philippe Hamel <hamelphi@chromium.org> Date: Wed Nov 29 20:36:37 2017 Add hex hash infor to ranker model metadata. This will give us more flexibility in the future on how we process feature names when training. No model with hashed features are in production yet, so this change is safe. The proto on the google3 side will also be updated with this change. Bug: 786472 Change-Id: I89a9b364533279da9d696a85beeb9794e5ca3d43 Reviewed-on: https://chromium-review.googlesource.com/794855 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Cr-Commit-Position: refs/heads/master@{#520230} [modify] https://crrev.com/90c56c8fefa26fc1cd2427ca3e8626172751dfec/components/assist_ranker/proto/ranker_model.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c97535bd07eb551d7dd0669e675b481d8eb87f30 commit c97535bd07eb551d7dd0669e675b481d8eb87f30 Author: Philippe Hamel <hamelphi@chromium.org> Date: Fri Dec 15 19:15:40 2017 Ranker owns predictor objects and uses a config for initialization. Ranker also takes care of logging and deals with field trials internally. Bug: 786472, 778468 Change-Id: Ie583616643ab8ad169df4739a4a18b81a950553f Reviewed-on: https://chromium-review.googlesource.com/788331 Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#524426} [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLoggerImpl.java [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.h [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/BUILD.gn [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/DEPS [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/assist_ranker_service.h [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/assist_ranker_service_impl.cc [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/assist_ranker_service_impl.h [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/base_predictor.cc [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/base_predictor.h [add] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/base_predictor_unittest.cc [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/binary_classifier_predictor.cc [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/binary_classifier_predictor.h [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/binary_classifier_predictor_unittest.cc [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/generic_logistic_regression_inference.cc [add] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/predictor_config.cc [add] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/predictor_config.h [add] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/predictor_config_definitions.cc [add] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/predictor_config_definitions.h [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/proto/ranker_example.proto [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/ranker_example_util.cc [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/ranker_example_util.h [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/components/assist_ranker/ranker_example_util_unittest.cc [modify] https://crrev.com/c97535bd07eb551d7dd0669e675b481d8eb87f30/services/metrics/public/cpp/ukm_recorder.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7be9c84cd226d6d29d40daec1fd642256ae26e6 commit d7be9c84cd226d6d29d40daec1fd642256ae26e6 Author: Philippe Hamel <hamelphi@chromium.org> Date: Wed Jan 03 17:28:01 2018 Nits for assist ranker. Bug: 786472 Change-Id: I03a23cc70529ff2854ec538d6954411d6d89abdd Reviewed-on: https://chromium-review.googlesource.com/830824 Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526722} [modify] https://crrev.com/d7be9c84cd226d6d29d40daec1fd642256ae26e6/components/assist_ranker/base_predictor.cc [modify] https://crrev.com/d7be9c84cd226d6d29d40daec1fd642256ae26e6/components/assist_ranker/binary_classifier_predictor.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/833515eafbc5d09f04d66d8babb802607c9d87b7 commit 833515eafbc5d09f04d66d8babb802607c9d87b7 Author: Charles Zhao <charleszhao@chromium.org> Date: Wed Apr 11 06:49:20 2018 Add normalizer and convert_to_string preprocessors. (1) Normalizer rescale a int32 or float feature by diving the normalizer. (2) Convert_to_string preprocessor sets a feature from int32 or bool to string_value. BUG=786472 Change-Id: Ia93bbb7a28be4fdd22a6d72e83c86852878bc0a6 Reviewed-on: https://chromium-review.googlesource.com/1001085 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549797} [modify] https://crrev.com/833515eafbc5d09f04d66d8babb802607c9d87b7/components/assist_ranker/example_preprocessing.cc [modify] https://crrev.com/833515eafbc5d09f04d66d8babb802607c9d87b7/components/assist_ranker/example_preprocessing.h [modify] https://crrev.com/833515eafbc5d09f04d66d8babb802607c9d87b7/components/assist_ranker/example_preprocessing_unittest.cc [modify] https://crrev.com/833515eafbc5d09f04d66d8babb802607c9d87b7/components/assist_ranker/proto/example_preprocessor.proto
Comment 1 by hamelphi@chromium.org
, Nov 17 2017