In attempting to upload a new PS to https://chromium-review.googlesource.com/773635 (base PS 1) I got the following error:

rdsmith-macbookpro:../2.chrome/src [SSLInfoServiceMove] $ git cl upload
git cl upload
Running presubmit upload checks ...
Traceback (most recent call last):
  File "/Users/rdsmith/Sandboxen/depot_tools/git_cl.py", line 6126, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/Users/rdsmith/Sandboxen/depot_tools/git_cl.py", line 6108, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/Users/rdsmith/Sandboxen/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/Users/rdsmith/Sandboxen/depot_tools/git_cl.py", line 4969, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/Users/rdsmith/Sandboxen/depot_tools/git_cl.py", line 1644, in CMDUpload
    change=change)
  File "/Users/rdsmith/Sandboxen/depot_tools/git_cl.py", line 1576, in RunHook
    gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
  File "/Users/rdsmith/Sandboxen/depot_tools/presubmit_support.py", line 1403, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/Users/rdsmith/Sandboxen/depot_tools/presubmit_support.py", line 1311, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 2721, in CheckChangeOnUpload
  File "<string>", line 2450, in _CommonChecks
  File "<string>", line 899, in _CheckUnwantedDependencies
TypeError: CheckAddedJavaImports() takes exactly 2 arguments (3 given)

I have effectively no idea how to figure out this problem and fix it--a more informative error message (at least pointing me at the DEPS file I'm having problems with) would be very useful.

(I'm going to do printf debugging in the python, but that's not ideal.)

I've attached the patch I was trying to upload.  It was based on r517494 == 635dc26920b95551f670fc4f3434396b70e3c92c.

 

Deleted: SSLInfoServiceMove.patch 20.8 KB

SSLInfoServiceMove.patch 20.8 KB Download