Pin ANGLE dEQP builders to specific Clang revision |
||||
Issue descriptionIssue 727437 fixes the ability for ANGLE to build with Clang on all platforms, and split the dEQP tests into their own separate builders. The remaining work os to pin Clang and the compiler options on the dEQP bots, so they can be switched to the pinned version of Clang. Assigning to Ken for when issue 756686 is fixed.
,
Apr 13 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5 commit a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5 Author: Nico Weber <thakis@chromium.org> Date: Fri Apr 13 20:02:23 2018 Switch deqp windows bots to use clang. deqp used to not build with clang, but nowadays it does. We wanted to wait with the switch until we can pin clang on the deqp bots to an older clang if necessary, but we already don't do that on mac and linux, so this doesn't make things any worse, and it removes one blocker for the msvc bot turndown and makes the deqp bots run tests with the compiler that we use for building shipping chromium. Bug: 727437 , 786460 Change-Id: I3bd76f7e2939e33b28262ca509259b37e8bbe582 Reviewed-on: https://chromium-review.googlesource.com/1012740 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550737} [modify] https://crrev.com/a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5/tools/mb/mb_config.pyl
,
Apr 13 2018
,
Apr 13 2018
I certainly hope that we don't see a situation where a Clang roll completely breaks these bots. We should have worked on Issue 756686 before making that change above.
,
Apr 14 2018
I'm not actually sure how this bug is different from bug 756686 ? Is bug 756686 for the underlying mechanism, and this for using the mechanism?
,
Apr 14 2018
We already had a clang roll today that broke the linux and mac deqp bots, so there's 0 benefits on keeping the win bots on msvc and making everyone support msvc. Having said that, I'll work on issue 786460 starting monday. I agree this and issue 756686 are the same.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5 commit a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5 Author: Nico Weber <thakis@chromium.org> Date: Fri Apr 13 20:02:23 2018 Switch deqp windows bots to use clang. deqp used to not build with clang, but nowadays it does. We wanted to wait with the switch until we can pin clang on the deqp bots to an older clang if necessary, but we already don't do that on mac and linux, so this doesn't make things any worse, and it removes one blocker for the msvc bot turndown and makes the deqp bots run tests with the compiler that we use for building shipping chromium. Bug: 727437 , 786460 Change-Id: I3bd76f7e2939e33b28262ca509259b37e8bbe582 Reviewed-on: https://chromium-review.googlesource.com/1012740 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550737} [modify] https://crrev.com/a506d4425eb55369a5d0b0bf8e2ef28d8e19d4b5/tools/mb/mb_config.pyl |
||||
►
Sign in to add a comment |
||||
Comment 1 by thakis@chromium.org
, Mar 9 2018