Decouple the dependency on viz, so that mus can run without viz turned on. In this mode, the display compositor will remain in the chrome browser, and the regular chrome gpu process will run.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b66fa2f1c3f1c9d033fd997a9252bb46ef5e538 commit 7b66fa2f1c3f1c9d033fd997a9252bb46ef5e538 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Fri Nov 17 20:46:19 2017 mus/viz: Make the viz related code in content more explicit. Update code in content/browser to not always assume mus is hosting viz, and instead make the code more explicit. For now, mus does still host viz, of course, but that will change soon. BUG= 786453 Change-Id: I51d22cbcf2da2d9c5f5ebcdb14d3fe5c0400b519 Reviewed-on: https://chromium-review.googlesource.com/775755 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#517545} [modify] https://crrev.com/7b66fa2f1c3f1c9d033fd997a9252bb46ef5e538/content/browser/browser_main_loop.cc [modify] https://crrev.com/7b66fa2f1c3f1c9d033fd997a9252bb46ef5e538/content/browser/browser_main_loop.h [modify] https://crrev.com/7b66fa2f1c3f1c9d033fd997a9252bb46ef5e538/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/7b66fa2f1c3f1c9d033fd997a9252bb46ef5e538/content/browser/gpu/browser_gpu_channel_host_factory.cc [modify] https://crrev.com/7b66fa2f1c3f1c9d033fd997a9252bb46ef5e538/content/browser/mus_util.cc [modify] https://crrev.com/7b66fa2f1c3f1c9d033fd997a9252bb46ef5e538/content/browser/mus_util.h [modify] https://crrev.com/7b66fa2f1c3f1c9d033fd997a9252bb46ef5e538/content/browser/renderer_host/render_widget_host_view_aura.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd commit 1dbe3b42b8e24c9853674360b48ceb341ca9b7fd Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Sat Nov 18 02:27:43 2017 mus/viz: Rename is-running-in-mash flag. Rename the flag to is-running-with-mus instead, since it is possible to run with mus, without running in mash. Also, provide an optional value for the flag. If value for the flag is set to 'viz', that means mus is the viz host. Otherwise, the browser will be hosting viz. BUG= 786453 Change-Id: I14385c16ee36ac8c46788955ab2381bf8b53d334 Reviewed-on: https://chromium-review.googlesource.com/777359 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#517682} [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/browser/browser_main_loop.cc [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/ppapi_plugin/ppapi_thread.cc [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/public/common/content_switches.cc [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/public/common/content_switches.h [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/renderer/browser_plugin/browser_plugin.cc [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/renderer/mash_util.cc [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/renderer/mash_util.h [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/renderer/mus/renderer_window_tree_client.cc [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/renderer/render_thread_impl.cc [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/content/renderer/render_widget.cc [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/ui/base/ui_base_switches.cc [modify] https://crrev.com/1dbe3b42b8e24c9853674360b48ceb341ca9b7fd/ui/base/ui_base_switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aadadcd50a1d016be7ee1d8882ac69c19b8dbeb1 commit aadadcd50a1d016be7ee1d8882ac69c19b8dbeb1 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Sat Nov 18 06:15:36 2017 mus/viz: Renderer needs to know the real viz host. Renderer needs to talk to the browser if browser is hosting viz, even when running with mus. So make sure renderer talks to the right process for viz-related communication. BUG= 786453 Change-Id: I3561d9f1d8ae14bc35a34125fd55df773afeeca1 Reviewed-on: https://chromium-review.googlesource.com/777439 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#517704} [modify] https://crrev.com/aadadcd50a1d016be7ee1d8882ac69c19b8dbeb1/content/renderer/render_thread_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fda7299d6c2dcd7bf13d46051fb5a875265f5e91 commit fda7299d6c2dcd7bf13d46051fb5a875265f5e91 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Mon Nov 20 23:27:46 2017 mus/viz: Allow mus to run without being the viz host. Notable changes: . Introduce |InProcessConfig::should_host_viz| that can be used to decide whether mus should be the viz host or not. . Do not create ws::GpuHost, viz::HostFrameSinkManager, and components that depend on these (e.g. VideoDetectorImpl, FrameGenerator) when mus is not hosting viz. . Notify the window manager about the AcceleratedWidget associated with a display, when mus is not hosting-viz. This allows the compositors in the browser to set up the widget correctly. . Introduce VizHostProxy, which WindowServer/ServerWindow etc. talk to. When mus is hosting viz, it forwards the call to the correct HostFrameSinkManager. When mus is not hosting viz, these calls are deliberately dropped, since the chrome-browser is responsible for managing the viz host. BUG= 786453 Change-Id: I04111207ab7d7228cf40f44dab0f01acf93e16d4 Reviewed-on: https://chromium-review.googlesource.com/777506 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#517985} [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/public/interfaces/window_manager.mojom [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/service.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/service.h [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/display.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/display.h [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/drag_controller_unittest.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/event_dispatcher_unittest.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/focus_controller_unittest.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/modal_window_controller_unittest.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/platform_display_default.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/platform_display_default_unittest.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/platform_display_delegate.h [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/server_window.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/server_window_delegate.h [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/server_window_drawn_tracker_unittest.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/test_server_window_delegate.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/test_server_window_delegate.h [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/test_utils.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/test_utils.h [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/transient_windows_unittest.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/window_coordinate_conversions_unittest.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/window_finder_unittest.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/window_server.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/window_server.h [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/window_tree.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/window_tree.h [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/window_tree_client_unittest.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/services/ui/ws/window_tree_unittest.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/fda7299d6c2dcd7bf13d46051fb5a875265f5e91/ui/aura/mus/window_tree_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab commit 55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Tue Nov 28 17:18:01 2017 aura: Allow injecting the AcceleratedWidget into aura. mus can delegate managing the gfx::AcceleratedWidget it creates to the window manager. The window manager (i.e. ash/aura) in this case needs to support injecting this AcceleratedWidget into its compositor. BUG= 786453 Change-Id: If9de911ab70e84e750728b0b46a8d4470c1e7da8 Reviewed-on: https://chromium-review.googlesource.com/792272 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#519717} [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/ash/window_manager.cc [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/ash/window_manager.h [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/mash/simple_wm/simple_wm.h [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/services/ui/demo/mus_demo_internal.h [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/services/ui/test_wm/test_wm.cc [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/services/ui/ws/window_manager_client_unittest.cc [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/services/ui/ws/window_server_test_base.h [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/ui/aura/mus/window_manager_delegate.h [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/ui/aura/mus/window_tree_host_mus.cc [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/ui/aura/mus/window_tree_host_mus.h [modify] https://crrev.com/55cd40ffbbb8af845ddc7cc3fd15a8d8bbe15eab/ui/aura/test/aura_test_base.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9 commit eeb5a94c83b11e7f2e61901e28ce600daa7f48c9 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Tue Nov 28 21:17:23 2017 mus: Use a cmd flag when mus is hosting viz. Use --mus=viz if the mus window-server is the viz-host. If --mus is not set to viz, then mus is used, but chrome still is the viz host. For now, always set it to 'viz', so that mus still remains the viz host. Once some more fixes land, we can turn it off by default. BUG= 786453 Change-Id: If8f6fca0178322311a0a14b718b08f9084bda35c Reviewed-on: https://chromium-review.googlesource.com/792276 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#519840} [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/ash/test/ash_test_suite.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/chrome/app/chrome_main.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/chrome/browser/chromeos/first_run/goodies_displayer_browsertest.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/chrome/test/base/mash_browser_tests_main.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/content/browser/browser_main_loop.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/content/browser/gpu/browser_gpu_channel_host_factory.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/content/browser/mus_util.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/content/browser/mus_util.h [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/content/browser/utility_process_host_impl.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/content/renderer/render_thread_impl.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/content/test/content_test_launcher.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/mash/test/mash_test_suite.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/services/ui/demo/mus_demo_unittests.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/services/ui/ws/window_server_test_base.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/ui/aura/test/aura_test_helper.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/ui/base/ui_base_switches.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/ui/base/ui_base_switches.h [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/ui/base/ui_base_switches_util.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/ui/base/ui_base_switches_util.h [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/ui/views/mus/views_mus_test_suite.cc [modify] https://crrev.com/eeb5a94c83b11e7f2e61901e28ce600daa7f48c9/ui/wm/test/wm_test_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30daff6502d23b98a544c110e598f42c477a390c commit 30daff6502d23b98a544c110e598f42c477a390c Author: Scott Violet <sky@chromium.org> Date: Fri Dec 01 07:04:52 2017 chromeos: update content to deal with ui-service not implying viz When the ui-service is running without viz we need to run some of the classic behavior (around creating frame ids). This patch updates a handful of sites. This gets the login case working, but pdfs (webview guest) still don't work. Will continue looking at it. BUG= 786453 TEST=none Change-Id: I0ce2934a667195608bcecb0c00a0f181f249bd74 Reviewed-on: https://chromium-review.googlesource.com/802182 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#520880} [modify] https://crrev.com/30daff6502d23b98a544c110e598f42c477a390c/content/browser/browser_plugin/browser_plugin_guest.cc [modify] https://crrev.com/30daff6502d23b98a544c110e598f42c477a390c/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/30daff6502d23b98a544c110e598f42c477a390c/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc [modify] https://crrev.com/30daff6502d23b98a544c110e598f42c477a390c/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/30daff6502d23b98a544c110e598f42c477a390c/content/renderer/render_thread_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6d6208b313b3975e9429ef13ef3bbb7abf7aa31 commit b6d6208b313b3975e9429ef13ef3bbb7abf7aa31 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Fri Dec 01 20:03:59 2017 mus: Initialize ozone correctly without viz. If mus is not hosting viz, then it does not need to provide the connector to ozone. BUG= 786453 Change-Id: I6053ca45f7338c3fa2a08ea27845f7da33117b03 Reviewed-on: https://chromium-review.googlesource.com/803838 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521029} [modify] https://crrev.com/b6d6208b313b3975e9429ef13ef3bbb7abf7aa31/services/ui/service.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/faa974734a75c2fc4b855f2b67afda7f2aa4efe0 commit faa974734a75c2fc4b855f2b67afda7f2aa4efe0 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Mon Dec 04 16:10:17 2017 ozone: Workaround a start up race for OzonePlatform. With mus, OzonePlatform is created in the mus-ws thread, and it can be accessed from the IO thread in GpuProcessHost. There is a race here, since the IO thread and the mus-ws thread do not know about each other. So, instead of immediately talking to the OzonePlatform instance from GpuProcessHost, register a callback that gets run once the instance is created and initialized. This way, with regular chrome (where OzonePlatform is created on the UI thread), the callback is run immediately. But with mus, it waits until the OzonePlatform instance is available. BUG= 786453 Change-Id: I9c4553333ef29d5541cf3b65fed475c3cc7ef2db Reviewed-on: https://chromium-review.googlesource.com/794103 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521353} [modify] https://crrev.com/faa974734a75c2fc4b855f2b67afda7f2aa4efe0/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/faa974734a75c2fc4b855f2b67afda7f2aa4efe0/ui/ozone/public/ozone_platform.cc [modify] https://crrev.com/faa974734a75c2fc4b855f2b67afda7f2aa4efe0/ui/ozone/public/ozone_platform.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/418217886ac8dd904b0ba1e53ed42d34d6ae8cff commit 418217886ac8dd904b0ba1e53ed42d34d6ae8cff Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Mon Dec 04 16:23:23 2017 mus: Do not host viz by default. By default, mus will not host viz when chrome is run with --mus. Instead, it will expect chrome to host viz. mus will continue to always host viz when chrome is run with --mash. Bug: 786453 Change-Id: Ifea1a6a953d3e4d20b9d624e156c627a0122a344 Reviewed-on: https://chromium-review.googlesource.com/798776 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521357} [modify] https://crrev.com/418217886ac8dd904b0ba1e53ed42d34d6ae8cff/chrome/app/chrome_main.cc [modify] https://crrev.com/418217886ac8dd904b0ba1e53ed42d34d6ae8cff/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc [modify] https://crrev.com/418217886ac8dd904b0ba1e53ed42d34d6ae8cff/content/test/content_test_launcher.cc [modify] https://crrev.com/418217886ac8dd904b0ba1e53ed42d34d6ae8cff/testing/buildbot/filters/mus.content_browsertests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07094984cc93a5aaaec32714e71e0cb483e6e4ba commit 07094984cc93a5aaaec32714e71e0cb483e6e4ba Author: Scott Violet <sky@chromium.org> Date: Mon Dec 04 18:55:04 2017 chromeos: make webviewguest work with ui-service and not viz When the ui-service is running without viz we need to run some of the classic behavior (around creating frame ids). This patch updates a handful of sites. BUG= 786453 TEST=none Change-Id: I61bef556e8fb21e467741619736067df01c3af88 Reviewed-on: https://chromium-review.googlesource.com/804194 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521399} [modify] https://crrev.com/07094984cc93a5aaaec32714e71e0cb483e6e4ba/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/07094984cc93a5aaaec32714e71e0cb483e6e4ba/content/browser/web_contents/web_contents_view_aura.cc [modify] https://crrev.com/07094984cc93a5aaaec32714e71e0cb483e6e4ba/content/browser/web_contents/web_contents_view_guest.cc [modify] https://crrev.com/07094984cc93a5aaaec32714e71e0cb483e6e4ba/content/renderer/browser_plugin/browser_plugin.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33ddb34f29fc7a71ed55447041fd616162ca15fa commit 33ddb34f29fc7a71ed55447041fd616162ca15fa Author: Scott Violet <sky@chromium.org> Date: Mon Dec 04 23:26:27 2017 aura: don't append --viz in AuraTestHelper Setting --viz in AuraTestHelper means we can't run tests as they would run when --mus is specified on the command line. If this is necessary, it's better to push to the testsuite. BUG= 786453 TEST=none Change-Id: I4b6f6b9685f16abdcf4c8e69347239368ad9a6b3 Reviewed-on: https://chromium-review.googlesource.com/806797 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521507} [modify] https://crrev.com/33ddb34f29fc7a71ed55447041fd616162ca15fa/ui/aura/test/aura_test_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/709431d570a2d4eca8cb619090ace92bc2784e0b commit 709431d570a2d4eca8cb619090ace92bc2784e0b Author: Scott Violet <sky@chromium.org> Date: Tue Dec 05 04:53:28 2017 mus: couple of changes for running tests with --mus Tests configure an environment this is a bit different than real code, so need some early outs. BUG= 786453 TEST=none Change-Id: I44621add71a17821293949aa837c39c2b5394d9d Reviewed-on: https://chromium-review.googlesource.com/807168 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521618} [modify] https://crrev.com/709431d570a2d4eca8cb619090ace92bc2784e0b/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/709431d570a2d4eca8cb619090ace92bc2784e0b/content/test/test_render_view_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97756170be9d72ee4444285300a3424cb9da0b33 commit 97756170be9d72ee4444285300a3424cb9da0b33 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Tue Dec 05 18:43:27 2017 mus/ash: Fix a few tests. When mus is not hosting viz, ash is still responsible for managing the mirroring. So update the MirrorWindowController as appropriate. Also, do not have mus host viz for ash_unittests --mus. BUG= 786453 Change-Id: I964bb030113f1c0e8a5375056687e2c0ffdba53a Reviewed-on: https://chromium-review.googlesource.com/808004 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521760} [modify] https://crrev.com/97756170be9d72ee4444285300a3424cb9da0b33/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/97756170be9d72ee4444285300a3424cb9da0b33/ash/test/ash_test_suite.cc [modify] https://crrev.com/97756170be9d72ee4444285300a3424cb9da0b33/testing/buildbot/filters/ash_unittests_mus.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6b0861086b3fd286bbacb581bb6ebc57707bf52 commit f6b0861086b3fd286bbacb581bb6ebc57707bf52 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Tue Dec 05 18:45:22 2017 mus/aura: Make sure the root window always has a valid LocalSurfaceId. When running with mus, and mus is not hosting viz, aura has to generate the LocalSurfaceId. It needs to make sure the root window always has a valid LocalSurfaceId, because that's what is fed into ui::Compositor, and without a valid id, it never shows anything on screen. BUG= 786453 Change-Id: Ie075246937f7e607afdc945ea1cea0b021595e50 Reviewed-on: https://chromium-review.googlesource.com/807886 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521762} [modify] https://crrev.com/f6b0861086b3fd286bbacb581bb6ebc57707bf52/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/f6b0861086b3fd286bbacb581bb6ebc57707bf52/ui/aura/window_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2784cad2a14c50e174482743949ec12f577d7492 commit 2784cad2a14c50e174482743949ec12f577d7492 Author: Scott Violet <sky@chromium.org> Date: Tue Dec 05 20:39:26 2017 aura: changes EventInjector to query WindowTreeHost for display Previously the code queried TestScreen. This is problematic as content_browsertests uses TestScreen, which *always* returns a display id of 2000. When mus gets the event the event is then dropped (because it doesn't know about 2000). This changes EventInjector to query WindowTreeHost and has WindowTreeHostMus override GetDisplayId() to return the real display id. BUG= 786453 TEST=none Change-Id: I01b9ce9096a0a3e7d6ca9cf85706afb0213035a7 Reviewed-on: https://chromium-review.googlesource.com/809493 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521813} [modify] https://crrev.com/2784cad2a14c50e174482743949ec12f577d7492/ui/aura/event_injector.cc [modify] https://crrev.com/2784cad2a14c50e174482743949ec12f577d7492/ui/aura/mus/window_tree_host_mus.cc [modify] https://crrev.com/2784cad2a14c50e174482743949ec12f577d7492/ui/aura/mus/window_tree_host_mus.h [modify] https://crrev.com/2784cad2a14c50e174482743949ec12f577d7492/ui/aura/window_tree_host.cc [modify] https://crrev.com/2784cad2a14c50e174482743949ec12f577d7492/ui/aura/window_tree_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bc008c9124e0aa4ec4f5c720b00e7ee98e6643f commit 1bc008c9124e0aa4ec4f5c720b00e7ee98e6643f Author: Scott Violet <sky@chromium.org> Date: Tue Dec 05 22:46:09 2017 chromeos: fix up locations of events in RemoteEventInjector The ui service DCHECKs if the root_location and location don't match. This is always the case for events coming in from the platform, but RemoteEventInjector circumvents that and could supply different locations. This makes EventInjector set the locations to match. Non-mus path does this by way of LocatedEvent::UpdateForRootTransform. BUG= 786453 TEST=none Change-Id: If70378c18d354b29290d0545cfa6bf2f546a60f7 Reviewed-on: https://chromium-review.googlesource.com/809610 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521871} [modify] https://crrev.com/1bc008c9124e0aa4ec4f5c720b00e7ee98e6643f/services/ui/ws/remote_event_dispatcher.cc [modify] https://crrev.com/1bc008c9124e0aa4ec4f5c720b00e7ee98e6643f/ui/aura/event_injector.cc [modify] https://crrev.com/1bc008c9124e0aa4ec4f5c720b00e7ee98e6643f/ui/aura/event_injector.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ae6cf7e61175b7bfcf1e5e3aab238785dc3d0f0 commit 6ae6cf7e61175b7bfcf1e5e3aab238785dc3d0f0 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Tue Dec 05 23:49:16 2017 mus/aura: Wait for the real AcceleratedWidget. When mus does not host viz, aura handles the real AcceleratedWidget. So in such cases, WindowTreeHostMus needs to wait for the widget to be avaiable, which is still created by mus and sent to aura over mojom. BUG= 786453 , 791619 Change-Id: I335365bfe4793c8fafb8d08eaa45c09c50e17a59 Reviewed-on: https://chromium-review.googlesource.com/807887 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521903} [modify] https://crrev.com/6ae6cf7e61175b7bfcf1e5e3aab238785dc3d0f0/ash/shell_port_mus.cc [modify] https://crrev.com/6ae6cf7e61175b7bfcf1e5e3aab238785dc3d0f0/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/6ae6cf7e61175b7bfcf1e5e3aab238785dc3d0f0/ui/aura/mus/window_tree_host_mus.cc [modify] https://crrev.com/6ae6cf7e61175b7bfcf1e5e3aab238785dc3d0f0/ui/aura/mus/window_tree_host_mus_init_params.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbe89b730b652156b1e621a87c686f75179f86a5 commit bbe89b730b652156b1e621a87c686f75179f86a5 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Wed Dec 06 01:12:02 2017 ozone-x11: Always initialize in multi-thread mode. Like single-process mode, chrome uses x11 from multiple threads in --mus mode too (the window-server thread, and the viz thread). So always initialize ozone-x11 in multi-thread mode. It would be possible to introduce a new flag in InitParams for this mode, but considering this is only used for development purposes on developer workstation, just init multi-thread mode unconditionally. BUG= 786453 , 791619 Change-Id: I930fc325ef1a52f531a419f660d31f55af03d1c6 Reviewed-on: https://chromium-review.googlesource.com/809943 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521933} [modify] https://crrev.com/bbe89b730b652156b1e621a87c686f75179f86a5/ui/ozone/platform/x11/ozone_platform_x11.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/904d1dfc4a5bad0842a09c41a659bb18a0bb6bc4 commit 904d1dfc4a5bad0842a09c41a659bb18a0bb6bc4 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Wed Dec 06 05:33:49 2017 Revert "mus/aura: Wait for the real AcceleratedWidget." This reverts commit 6ae6cf7e61175b7bfcf1e5e3aab238785dc3d0f0. Reason for revert: Speculative revert for ash_unittests-mus failure on chromium.chromiumos/linux-chromeos-rel, started here: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-rel/builds/3239 This is the only mus related CL in the regression range. Original change's description: > mus/aura: Wait for the real AcceleratedWidget. > > When mus does not host viz, aura handles the real AcceleratedWidget. So > in such cases, WindowTreeHostMus needs to wait for the widget to be > avaiable, which is still created by mus and sent to aura over mojom. > > BUG= 786453 , 791619 > > Change-Id: I335365bfe4793c8fafb8d08eaa45c09c50e17a59 > Reviewed-on: https://chromium-review.googlesource.com/807887 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521903} TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org Change-Id: I9b15d1ad8fc36e6a4b4864e1f7bfd6df2b3745a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 786453 , 791619 Reviewed-on: https://chromium-review.googlesource.com/810404 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#522019} [modify] https://crrev.com/904d1dfc4a5bad0842a09c41a659bb18a0bb6bc4/ash/shell_port_mus.cc [modify] https://crrev.com/904d1dfc4a5bad0842a09c41a659bb18a0bb6bc4/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/904d1dfc4a5bad0842a09c41a659bb18a0bb6bc4/ui/aura/mus/window_tree_host_mus.cc [modify] https://crrev.com/904d1dfc4a5bad0842a09c41a659bb18a0bb6bc4/ui/aura/mus/window_tree_host_mus_init_params.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3bc451253f61b44141af7c6377841659c027aac commit f3bc451253f61b44141af7c6377841659c027aac Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Wed Dec 06 06:25:21 2017 mus/ash: Notify the client about AcceleratedWidget in tests. Send the AcceleratedWidget to the client on init, so that the compositor can be correctly initialized. BUG= 786453 Change-Id: Iad74feb8d669abf2470702fad890f33c2fe11f91 Reviewed-on: https://chromium-review.googlesource.com/810210 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#522027} [modify] https://crrev.com/f3bc451253f61b44141af7c6377841659c027aac/ash/test/ash_test_helper.cc [modify] https://crrev.com/f3bc451253f61b44141af7c6377841659c027aac/ui/aura/test/mus/test_window_tree.cc [modify] https://crrev.com/f3bc451253f61b44141af7c6377841659c027aac/ui/aura/test/mus/test_window_tree.h [modify] https://crrev.com/f3bc451253f61b44141af7c6377841659c027aac/ui/aura/test/mus/test_window_tree_client_setup.cc [modify] https://crrev.com/f3bc451253f61b44141af7c6377841659c027aac/ui/aura/test/mus/test_window_tree_client_setup.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97152ee5e7093c0e1b9cea15209dc5985a36c2a3 commit 97152ee5e7093c0e1b9cea15209dc5985a36c2a3 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Thu Dec 07 04:55:27 2017 mus: Run browser_tests in the now-default mode for --mus. mus should no longer host viz for browser_tests --mus. So it should not have --mus=viz flag set. With this change, the browser_tests no longer need the filter file. So remove it (from main and fyi waterfalls). BUG= 786453 , 785536 Change-Id: Ia9ecfdc8f667bb07cf53debbc98f960938f6d452 Reviewed-on: https://chromium-review.googlesource.com/812169 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#522341} [modify] https://crrev.com/97152ee5e7093c0e1b9cea15209dc5985a36c2a3/chrome/test/base/mash_browser_tests_main.cc [modify] https://crrev.com/97152ee5e7093c0e1b9cea15209dc5985a36c2a3/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/97152ee5e7093c0e1b9cea15209dc5985a36c2a3/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/97152ee5e7093c0e1b9cea15209dc5985a36c2a3/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/43225a397b57f9df2b5fbfa2a7917d89bbf6f09a/testing/buildbot/filters/mojo.fyi.mus.browser_tests.filter [delete] https://crrev.com/43225a397b57f9df2b5fbfa2a7917d89bbf6f09a/testing/buildbot/filters/mus.browser_tests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b9697f87ae4d463e2a7b7c7d58ee9b2537303aa commit 6b9697f87ae4d463e2a7b7c7d58ee9b2537303aa Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Fri Dec 08 04:13:43 2017 cc: Fix unregistering from memory coordinator. If Shutdown() was called on StagingBufferPool before it has a chance to run the callback to add itself as a client to the memory-coordinator, then the pool would remain registered even after it has been destroyed. Fix this by just registering to the memory-coordinator as a client in the ctor, instead of posting a task on the task-runner. Similarly, unregister from the dtor. BUG= 786453 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I62e88e6a397468294e5ac5c0f6ef1cc1c2aa91ee Reviewed-on: https://chromium-review.googlesource.com/812546 Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#522709} [modify] https://crrev.com/6b9697f87ae4d463e2a7b7c7d58ee9b2537303aa/cc/BUILD.gn [modify] https://crrev.com/6b9697f87ae4d463e2a7b7c7d58ee9b2537303aa/cc/raster/staging_buffer_pool.cc [modify] https://crrev.com/6b9697f87ae4d463e2a7b7c7d58ee9b2537303aa/cc/raster/staging_buffer_pool.h [add] https://crrev.com/6b9697f87ae4d463e2a7b7c7d58ee9b2537303aa/cc/raster/staging_buffer_pool_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b34782ec012125060545fb68b9fc2d70870996be commit b34782ec012125060545fb68b9fc2d70870996be Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Fri Dec 08 17:05:43 2017 mus/aura: Wait for the real AcceleratedWidget. When mus does not host viz, aura handles the real AcceleratedWidget. So in such cases, WindowTreeHostMus needs to wait for the widget to be avaiable, which is still created by mus and sent to aura over mojom. BUG= 786453 , 791619 Change-Id: I4e206211ffabdc6f0ae09066f7a3ec720659322b Reviewed-on: https://chromium-review.googlesource.com/809242 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#522800} [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ash/shell_port_mus.cc [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ash/test/ash_test_base.cc [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ash/test/ash_test_helper.cc [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ash/test/ash_test_helper.h [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ui/aura/BUILD.gn [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ui/aura/mus/window_tree_host_mus.cc [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ui/aura/mus/window_tree_host_mus_init_params.h [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ui/aura/test/mus/test_window_tree.cc [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ui/aura/test/mus/test_window_tree.h [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ui/aura/test/mus/test_window_tree_client_setup.cc [modify] https://crrev.com/b34782ec012125060545fb68b9fc2d70870996be/ui/aura/test/mus/test_window_tree_client_setup.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8e9ba13a2a0c49faeb1e28d70c638a91b36fbfa commit b8e9ba13a2a0c49faeb1e28d70c638a91b36fbfa Author: Scott Violet <sky@chromium.org> Date: Sat Dec 09 02:13:25 2017 chromeos: fix oopifs for mus We need to ignore FrameSinkIds from mus when not running with viz. BUG= 786453 TEST=covered by tests Change-Id: I36c0ae7da151866ec7464846cb3498b1d6b3bc2c Reviewed-on: https://chromium-review.googlesource.com/815754 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#522961} [modify] https://crrev.com/b8e9ba13a2a0c49faeb1e28d70c638a91b36fbfa/content/browser/renderer_host/input/composited_scrolling_browsertest.cc [modify] https://crrev.com/b8e9ba13a2a0c49faeb1e28d70c638a91b36fbfa/content/browser/renderer_host/input/touch_action_browsertest.cc [modify] https://crrev.com/b8e9ba13a2a0c49faeb1e28d70c638a91b36fbfa/content/renderer/browser_plugin/browser_plugin.cc [modify] https://crrev.com/b8e9ba13a2a0c49faeb1e28d70c638a91b36fbfa/content/renderer/mus/renderer_window_tree_client.cc [modify] https://crrev.com/b8e9ba13a2a0c49faeb1e28d70c638a91b36fbfa/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/b8e9ba13a2a0c49faeb1e28d70c638a91b36fbfa/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/b8e9ba13a2a0c49faeb1e28d70c638a91b36fbfa/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/ebba406b71bf8b8d53868df5f3435247c0c29fb9/testing/buildbot/filters/mojo.fyi.mus.content_browsertests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15cb8c6756df8232cdd975b8bd95aa5dca2b1d54 commit 15cb8c6756df8232cdd975b8bd95aa5dca2b1d54 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Mon Dec 11 17:54:36 2017 mus/aura: Run tests where mus is hosting viz. The mus-backend for aura sometimes does things differently depending on whether mus is hosting viz or not. So run the unit-tests with mus hosting viz (which is the case when chrome is run with --mash), and also with mus not hosting viz (which is the case when chrome is run with --mus). Make sure context_fatory(), context_factory_private() are set up correctly when mus is not hosting viz. BUG= 786453 Change-Id: Icb968cb1fff386f174ffe798315fa7e2301aa341 Reviewed-on: https://chromium-review.googlesource.com/818546 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#523130} [modify] https://crrev.com/15cb8c6756df8232cdd975b8bd95aa5dca2b1d54/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/15cb8c6756df8232cdd975b8bd95aa5dca2b1d54/ui/aura/test/aura_test_base.cc [modify] https://crrev.com/15cb8c6756df8232cdd975b8bd95aa5dca2b1d54/ui/aura/test/aura_test_base.h [modify] https://crrev.com/15cb8c6756df8232cdd975b8bd95aa5dca2b1d54/ui/aura/window_event_dispatcher_unittest.cc [modify] https://crrev.com/15cb8c6756df8232cdd975b8bd95aa5dca2b1d54/ui/aura/window_targeter_unittest.cc [modify] https://crrev.com/15cb8c6756df8232cdd975b8bd95aa5dca2b1d54/ui/aura/window_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4864aaae6923e2970a96bdaaf33146568acb07ae commit 4864aaae6923e2970a96bdaaf33146568acb07ae Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Mon Dec 11 21:00:18 2017 mus/aura: Embed windows should have valid LocalSurfaceId. If a window is embedding another client, then it needs to be able to generate a LocalSurfaceId that the embedded client will use. BUG= 786453 Change-Id: I2fa66355399a057536f5c07d512f5c82df10fe90 Reviewed-on: https://chromium-review.googlesource.com/818156 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523204} [modify] https://crrev.com/4864aaae6923e2970a96bdaaf33146568acb07ae/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/4864aaae6923e2970a96bdaaf33146568acb07ae/ui/aura/window_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d04afb748bd39048c0a27556fcbcdf86f080bc7b commit d04afb748bd39048c0a27556fcbcdf86f080bc7b Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Mon Dec 11 21:09:03 2017 mus/aura: Fix setting up LayerTreeFrameSink for a window. Make sure the LayerTreeFrameSink has the LocalSurfaceId correctly set, even if the LocalSurfaceId is generated before a LayerTreeFrameSink is created. BUG= 786453 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I768f06ab84ede54218afd2f9c3dbaf8bbb27296a Reviewed-on: https://chromium-review.googlesource.com/817632 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523206} [modify] https://crrev.com/d04afb748bd39048c0a27556fcbcdf86f080bc7b/components/viz/client/client_layer_tree_frame_sink.h [modify] https://crrev.com/d04afb748bd39048c0a27556fcbcdf86f080bc7b/ui/aura/BUILD.gn [modify] https://crrev.com/d04afb748bd39048c0a27556fcbcdf86f080bc7b/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/d04afb748bd39048c0a27556fcbcdf86f080bc7b/ui/aura/mus/window_port_mus.h [add] https://crrev.com/d04afb748bd39048c0a27556fcbcdf86f080bc7b/ui/aura/mus/window_port_mus_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ac9c2c048c26f92de97a698e2565b6bc81a75f4 commit 0ac9c2c048c26f92de97a698e2565b6bc81a75f4 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Tue Dec 12 21:05:13 2017 mus: Run content_unittests with --mus Start running content_unittests with the --mus flags on linux-chromeos bots. BUG= 786453 Change-Id: Ied53b0f651dbec49ee7a3224623bb69343eaf891 Reviewed-on: https://chromium-review.googlesource.com/817691 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#523541} [modify] https://crrev.com/0ac9c2c048c26f92de97a698e2565b6bc81a75f4/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/0ac9c2c048c26f92de97a698e2565b6bc81a75f4/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/0ac9c2c048c26f92de97a698e2565b6bc81a75f4/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/0ac9c2c048c26f92de97a698e2565b6bc81a75f4/testing/buildbot/chromium.memory.json [modify] https://crrev.com/0ac9c2c048c26f92de97a698e2565b6bc81a75f4/testing/buildbot/test_suites.pyl
Comment 1 by bugdroid1@chromium.org
, Nov 17 2017