New issue
Advanced search Search tips

Issue 786447 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove some of test-only state in AutofillAgent

Project Member Reported by ekaramad@chromium.org, Nov 17 2017

Issue description

We should remove the variables added and change the corresponding tests using them.
 
Components: UI>Browser>Autofill
Labels: Hotlist-TechnicalDebt
For reference issue 712754 dealt with the removal of PageClickTracker and PageClickListener from the codebase. For that to happen, we had to introduce some test only state into AutofillAgent, namely, |last_clicked_form_control_element*| and also made one method FormControlElementClicked() public. This was needed for "page_click_tracker_browsertest.cc" which is now "form_control_click_detection_browsertest.cc" to still work with the new refactor.

Eventually we should rid ourselves off of the added test variables. But this could involve changing the tests themselves. Essentially, one good idea is to use AutofillAgent::QueryAutofillSuggestions as a signal and/or perhaps use a mock AutofillDriver for that matter.

See here for more context:
https://chromium-review.googlesource.com/c/chromium/src/+/773450/5//COMMIT_MSG#25
Cc: vabr@chromium.org
Summary: Remove some of test-only state in AutofillAgent (was: Move some of test-only state state inside AutofillAgent)

Comment 4 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Available)
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Cc: -vabr@chromium.org
vabr going hobby only -> reducing involvement.
Please contact me directly in urgent matters.

Sign in to add a comment