New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786439 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocked on:
issue 565219



Sign in to add a comment

Experiment cleanup: NTPOfflinePages

Project Member Reported by dgn@chromium.org, Nov 17 2017

Issue description

The feature is enabled by default and the only related Finch config expired in April 2016. We could remove the flag to kill branching
 
Labels: zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2

commit 590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Mon Dec 11 11:26:24 2017

📰 Remove NTPOfflinePages feature flag

The feature has been enable by default for months and has no
live finch experiment associated.

Bug:  786439 
Change-Id: I0302b0f642681bf911dc7820e75f5a3a6f2500f7
Reviewed-on: https://chromium-review.googlesource.com/809044
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523076}
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsCarouselAdapter.java
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroupDelegateImpl.java
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/SuggestionsCarouselTest.java
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupUnitTest.java
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/chrome/browser/about_flags.cc
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/590400eb6e878a2c0c3f94b9ad79a55ffcf5e0b2/testing/variations/fieldtrial_testing_config.json

Comment 3 by dgn@chromium.org, Dec 11 2017

Status: Fixed (was: Assigned)

Sign in to add a comment