New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 786418 link

Starred by 1 user
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Nov 2017
Cc:
tbuck...@chromium.org
█ mcirimele@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Stylus warm welcome shows on every Guest mode session

Project Member Reported by tbuck...@chromium.org, Nov 17 2017 
Version: 64.0.3261.0 canary
Device: Eve

Every time I enter Guest Mode, I get the warm welcome. We should simply not show the warm welcome in Guest Mode.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1b13367b1f66174ff93a174ffddb9b67b10dd1c

commit f1b13367b1f66174ff93a174ffddb9b67b10dd1c
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Nov 30 16:43:44 2017

palette: Do not show welcome bubble if guest mode or not in active state.

Originally tries to show bubble when the pref service (user) changes.
Added checks in PaletteWelcomeBubble::ShowIfNeeded to check for the
two cases where the bubble is not wanted. PaletteTray tries to show the
bubble again when the session state changes.

Test: ash_unittests PaletteWelcomeBubbleTest.*
Bug:  786418 ,  786590 
Change-Id: I0695a83383ce6c9d79f8d8f6dfda2eab0fb37071
Reviewed-on: https://chromium-review.googlesource.com/780841
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520575}
[modify] https://crrev.com/f1b13367b1f66174ff93a174ffddb9b67b10dd1c/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/f1b13367b1f66174ff93a174ffddb9b67b10dd1c/ash/system/palette/palette_welcome_bubble.cc
[modify] https://crrev.com/f1b13367b1f66174ff93a174ffddb9b67b10dd1c/ash/system/palette/palette_welcome_bubble_unittest.cc

Comment 2 by sammiequon@chromium.org, Nov 30 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment