Migrate IsolateClientEvent from event_mon to new pipeline |
|||||
Issue descriptionmaruel@, yours to re-assign as desired Please let me know how I can help!
,
Nov 29 2017
It seems like this event data has been useful for the analysis work that mcgreevy is currently doing. @maruel, do you think this is worth doing then? If so, when do you think you or someone else will be able to get to it? If not, we will need to take steps to remove the event_mon instrumentation after mcgreevy is done with his analysis.
,
Dec 1 2017
,
Dec 8 2017
,
Dec 15 2017
@maruel, thoughts on this?
,
Dec 20 2017
Once mcgreevy is done with the analysis, we can remove the event_mon code from the client. That's still nice to have data for mass analysis later on, to do on BQ. I think we can live without time series.
,
Dec 20 2017
Thanks for the update! It's actually event data, and not time series data. We can always add new instrumentation for BigQuery if we find we need it. Thanks to the new pipeline, this should be much easier than it used to be.
,
Dec 21 2017
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/2c110abe941d6732369c7655b82fa65bc97d7087 commit 2c110abe941d6732369c7655b82fa65bc97d7087 Author: Katie Thomas <katthomas@google.com> Date: Fri Jan 05 16:38:38 2018 [isolate] remove IsolateClientEvent sending Bug:786415 Change-Id: I90799968fa023c73cca11c40a241907a2c272ceb Reviewed-on: https://chromium-review.googlesource.com/839942 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Katie Thomas <katthomas@google.com> [modify] https://crrev.com/2c110abe941d6732369c7655b82fa65bc97d7087/client/cmd/isolate/archive.go [modify] https://crrev.com/2c110abe941d6732369c7655b82fa65bc97d7087/client/cmd/isolate/batch_archive.go [delete] https://crrev.com/d1be5461de9b4a910c24ad4e699b3c986c34a4c4/client/cmd/isolate/isolate_event_logger.go [delete] https://crrev.com/d1be5461de9b4a910c24ad4e699b3c986c34a4c4/client/cmd/isolate/isolate_event_logger_test.go
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/9ca18ff161cc51eb426fa26ce0fc10130c58faa7 commit 9ca18ff161cc51eb426fa26ce0fc10130c58faa7 Author: Katie Thomas <katthomas@google.com> Date: Tue Jan 09 23:27:46 2018 Roll infra/go/src/go.chromium.org/luci/ d1be5461d..2c110abe9 (1 commit) https://chromium.googlesource.com/infra/luci/luci-go/+log/d1be5461de9b..2c110abe941d $ git log d1be5461d..2c110abe9 --date=short --no-merges --format='%ad %ae %s' 2017-12-21 katthomas [isolate] remove IsolateClientEvent sending Created with: roll-dep infra/go/src/go.chromium.org/luci Bug:786415 Change-Id: Icda6d18a83bb357e5e0bcad0d13c54a826baaa88 Reviewed-on: https://chromium-review.googlesource.com/857517 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Katie Thomas <katthomas@google.com> [modify] https://crrev.com/9ca18ff161cc51eb426fa26ce0fc10130c58faa7/DEPS
,
Feb 8 2018
,
Feb 27 2018
https://critique.corp.google.com/#review/182813444 CL removing proto |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by katthomas@google.com
, Nov 21 2017