New issue
Advanced search Search tips

Issue 786414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocked on:
issue 787503

Blocking:
issue 794408



Sign in to add a comment

Support usage tracking of SVG docs in browser-side UseCounter

Project Member Reported by loonyb...@chromium.org, Nov 17 2017

Issue description

Override ShouldObserveMimeType in UseCounterPageLoadMetricsObserver.

Blink counts SVG usage when containing document is an HTML document.
PageLoadMetrics restrict mime type to text/html or xhtml, which filter out SVG document.

 
Blockedon: 787503
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/778c1adfcbbbf551e81706f0a9088ff3d6bf1859

commit 778c1adfcbbbf551e81706f0a9088ff3d6bf1859
Author: Luna Lu <loonybear@chromium.org>
Date: Tue Dec 12 16:26:39 2017

Override ShouldObserveMimeType in UseCounterPageLoadMetricsObserver support SVG docs

Blink side UseCounter counts SVG usage when containing document is an HTML doc.
PageLoadMetrics restrict mime type to text/html or xhtml, which might filter out
SVG document.
Overriding mime type restriction supports usage tracking SVG docs in UseCounterPageLoadMetricsObserver.

Bug:  786414 
Change-Id: I53e4afcae51166ce6f9cdde7c35d9a249dd94d2a
Reviewed-on: https://chromium-review.googlesource.com/776164
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523443}
[modify] https://crrev.com/778c1adfcbbbf551e81706f0a9088ff3d6bf1859/chrome/browser/page_load_metrics/browser_page_track_decider.cc
[modify] https://crrev.com/778c1adfcbbbf551e81706f0a9088ff3d6bf1859/chrome/browser/page_load_metrics/browser_page_track_decider.h
[modify] https://crrev.com/778c1adfcbbbf551e81706f0a9088ff3d6bf1859/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/778c1adfcbbbf551e81706f0a9088ff3d6bf1859/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.cc
[modify] https://crrev.com/778c1adfcbbbf551e81706f0a9088ff3d6bf1859/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.h
[modify] https://crrev.com/778c1adfcbbbf551e81706f0a9088ff3d6bf1859/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/778c1adfcbbbf551e81706f0a9088ff3d6bf1859/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/778c1adfcbbbf551e81706f0a9088ff3d6bf1859/chrome/common/page_load_metrics/page_track_decider.cc
[modify] https://crrev.com/778c1adfcbbbf551e81706f0a9088ff3d6bf1859/chrome/common/page_load_metrics/page_track_decider.h
[add] https://crrev.com/778c1adfcbbbf551e81706f0a9088ff3d6bf1859/chrome/test/data/page_load_metrics/circle.svg
[add] https://crrev.com/778c1adfcbbbf551e81706f0a9088ff3d6bf1859/chrome/test/data/page_load_metrics/circle.svg.mock-http-headers

Status: Fixed (was: Started)

Comment 4 by kbr@chromium.org, Dec 14 2017

Blocking: 794408

Sign in to add a comment