New issue
Advanced search Search tips

Issue 786403 link

Starred by 1 user
Status: Verified
Owner:
wzang@chromium.org
Closed: Nov 2017
Cc:
zalcorn@chromium.org
r...@chromium.org
alemate@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
64



Sign in to add a comment

CrOS lock screen no longer shows version number and S/N on dev channel

Reported by mhan...@duosecurity.com, Nov 17 2017 
UserAgent: Mozilla/5.0 (X11; CrOS x86_64 10134.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3270.0 Safari/537.36
Platform: 10134.0.0 (Official Build) dev-channel eve

Steps to reproduce the problem:
1. Boot ChromeOS
2. Observe lack of version info and device S/N in upper-right corner of screen
3. 

What is the expected behavior?
Version number, platform build information, and serial number are displayed

What went wrong?
This information is no longer present.

Did this work before? Yes prior dev channel release of CrOS on eve board

Chrome version: 64.0.3270.0  Channel: dev
OS Version: 10134.0.0
Flash Version:

Comment 1 by osh...@chromium.org, Nov 17 2017

Components: -UI UI>Shell>Wallpaper
Labels: 64 OS-iOS
Owner: zalcorn@chromium.org
Status: Assigned (was: Unconfirmed)
This is because lock screen has blur.

Comment 2 by mhan...@duosecurity.com, Nov 17 2017 

Prior to this release the lock screen also had blur, but the text was "in front of" the blur and appeared normally.  The text is now absent entirely and there is no evidence that it is "behind" the blur.

Comment 3 by zalcorn@chromium.org, Nov 21 2017

Cc: r...@chromium.org alemate@chromium.org zalcorn@chromium.org
Labels: -OS-iOS
Owner: jdufault@chromium.org
Jacob is this something we could add back with views?

Comment 4 by r...@chromium.org, Nov 21 2017

Cc: jdufault@chromium.org
Labels: -Pri-2 Pri-1
Owner: wzang@chromium.org

Comment 5 by wzang@chromium.org, Nov 26 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b876a6eab5e84a8c772f8d585d646595d3a906d7

commit b876a6eab5e84a8c772f8d585d646595d3a906d7
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Nov 29 23:31:10 2017

cros: Add dev channel version info to views-based lock screen

1) |ViewsScreenLocker| uses the same logic in |CoreOobeHandler| and
   display_manager.js.

2) The three values (version, enterprise and bluetooth) are updated
   asynchronously. To reduce code duplication, send them together in
   one call.

3) Make sure the version info label is not blocking the lock screen
   note action button.

Bug:  786403 
Change-Id: Id04a99f8f5da091e4be3ce4e2ed2bfcae2ad02e7
Reviewed-on: https://chromium-review.googlesource.com/786635
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520304}
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/ash/login/login_screen_controller.cc
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/ash/login/login_screen_controller.h
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/ash/login/ui/note_action_launch_button.cc
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/ash/login/ui/note_action_launch_button.h
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/ash/login/ui/note_action_launch_button_unittest.cc
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/chrome/browser/chromeos/login/lock/views_screen_locker.h
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/b876a6eab5e84a8c772f8d585d646595d3a906d7/chrome/browser/ui/ash/login_screen_client.h

Comment 7 by wzang@chromium.org, Nov 29 2017

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02169af92a21029fba14b4c80ded6ed7b154f7f3

commit 02169af92a21029fba14b4c80ded6ed7b154f7f3
Author: Timothy Loh <timloh@chromium.org>
Date: Thu Nov 30 02:57:19 2017

Revert "cros: Add dev channel version info to views-based lock screen"

This reverts commit b876a6eab5e84a8c772f8d585d646595d3a906d7.

Reason for revert:
The added test (LockContentsViewUnitTest.NoteActionButtonVisibilityChanges) fails on ASAN

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/24971

Original change's description:
> cros: Add dev channel version info to views-based lock screen
> 
> 1) |ViewsScreenLocker| uses the same logic in |CoreOobeHandler| and
>    display_manager.js.
> 
> 2) The three values (version, enterprise and bluetooth) are updated
>    asynchronously. To reduce code duplication, send them together in
>    one call.
> 
> 3) Make sure the version info label is not blocking the lock screen
>    note action button.
> 
> Bug:  786403 
> Change-Id: Id04a99f8f5da091e4be3ce4e2ed2bfcae2ad02e7
> Reviewed-on: https://chromium-review.googlesource.com/786635
> Reviewed-by: Oliver Chang <ochang@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520304}

TBR=xiyuan@chromium.org,oshima@chromium.org,ochang@chromium.org,wzang@chromium.org

Change-Id: I0d7ae305bbdf26a523e56e4ff00d3b016ea4f44a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  786403 
Reviewed-on: https://chromium-review.googlesource.com/798990
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520400}
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/ash/login/login_screen_controller.cc
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/ash/login/login_screen_controller.h
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/ash/login/ui/note_action_launch_button.cc
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/ash/login/ui/note_action_launch_button.h
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/ash/login/ui/note_action_launch_button_unittest.cc
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/chrome/browser/chromeos/login/lock/views_screen_locker.h
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/02169af92a21029fba14b4c80ded6ed7b154f7f3/chrome/browser/ui/ash/login_screen_client.h
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a05dcefca902cddc4ffcc32b93cb91580b69516e

commit a05dcefca902cddc4ffcc32b93cb91580b69516e
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Nov 30 05:50:03 2017

Reland "cros: Add dev channel version info to views-based lock screen"

The original CL forgot to call SetWidget in one of the unit test setup.

The original description:
1) |ViewsScreenLocker| uses the same logic in |CoreOobeHandler| and
    display_manager.js.

2) The three values (version, enterprise and bluetooth) are updated
   asynchronously. To reduce code duplication, send them together in
   one call.

3) Make sure the version info label is not blocking the lock screen
   note action button.

TBR=xiyuan@chromium.org,oshima@chromium.org,ochang@chromium.org

Bug:  786403 
Change-Id: I61b52cc2baed17ff06c256d23d1bcf8d64c5a6b2
Reviewed-on: https://chromium-review.googlesource.com/798754
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520451}
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/ash/login/login_screen_controller.cc
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/ash/login/login_screen_controller.h
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/ash/login/ui/note_action_launch_button.cc
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/ash/login/ui/note_action_launch_button.h
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/ash/login/ui/note_action_launch_button_unittest.cc
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/chrome/browser/chromeos/login/lock/views_screen_locker.h
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/a05dcefca902cddc4ffcc32b93cb91580b69516e/chrome/browser/ui/ash/login_screen_client.h

Comment 10 by sdantul...@chromium.org, Jan 5 2018

Status: Verified (was: Fixed)
10281.0.0, 65.0.3312.0
►

Sign in to add a comment