Blacklisted form still displayed in Settings>Save Passwords after being deleted from the detail screen |
|||
Issue descriptionPrecondition (1) Have at least one form for which you chose to never save passwords. What steps will reproduce the problem? (1)Open Chrome. (2)Navigate to Settings > Save Passwords. (3)Tap on one item in the Never Saved section. (4)Select Delete and delete the entry. What is the expected result? When returning to the previous view (Save Passwords), the deleted entry should not appear anymore in the Never Saved section. What happens instead? When returning to the previous view (Save Passwords), the deleted entry is still displayed in the Never Saved section.
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2714c42c6f5d0a7ad322b30147adcf155a40629b commit 2714c42c6f5d0a7ad322b30147adcf155a40629b Author: Ioana Pandele <ioanap@chromium.org> Date: Thu Nov 23 13:22:21 2017 Remove blacklisted form from |blacklistedForms_| when deleted from the detail view When deleting a blacklisted form from the password detail view, the entry is deleted from the password store, but it persists in the already loaded list on the Save Passwords page. This change makes sure it is deleted from the list being displayed. Bug: 786350 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idb5780ffabaa89ddb5473259dd550748ae264db3 Reviewed-on: https://chromium-review.googlesource.com/776802 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#518912} [modify] https://crrev.com/2714c42c6f5d0a7ad322b30147adcf155a40629b/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [modify] https://crrev.com/2714c42c6f5d0a7ad322b30147adcf155a40629b/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm [modify] https://crrev.com/2714c42c6f5d0a7ad322b30147adcf155a40629b/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm
,
Nov 24 2017
,
Nov 29 2017
Verified on chrome canary version 64.0.3264.0 on iPhone 8 plus and iPad Air with iOS 11.2, iPhone 6 plus iOS 10.3.3, following the steps mentioned in comment #0. On returning to Save Password, deleted password is not displayed. Looks good. |
|||
►
Sign in to add a comment |
|||
Comment 1 by ioanap@chromium.org
, Nov 17 2017