New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 786344 link

Starred by 4 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Feb 2018
Cc:
█ krajshree@chromium.org
█ rpattumani@chromium.org
ajha@chromium.org
█ brajkumar@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : 'ENTER' button is still seen enabled even after entering PIN in Cellular connected page

Project Member Reported by mmanchala@chromium.org, Nov 17 2017 
Chrome Version: 64.0.3270.0/10136.0.0 dev-channel Peppy,Gnawty and Paine
OS: Chrome

What steps will reproduce the problem?
1)Sign into User ->Insert Mobile Dongle and ensure it is connected
(2)Now go to chrome://settings page -> At Internet Connection click on Cellular connection -> Navigates to Cellular connected page
(3)Now Enable 'Enable SIM Card locking(require PIN to use Mobile data) option -> 'ENTER SIM PIN' Dialog box is seen -> enter wrong pin and now click on 'ENTER' button 
(4)Observe 'ENTER' button is still seen enabled  even after clicking on it and also able to click again on 'ENTER' button(Please refer Video)

Expected: 
'ENTER' button should be disabled after entering pin and clicking on it
or
'INVALID PIN' error message should be seen immediately after entering wrong PIN and clicking on 'ENTER' button

Actual: Instead
'ENTER' button is still seen enabled even after entering PIN and also again able to click on 'ENTER' button

This is Regression issue as same is working fine in old settings page i.e. in 'ENTER SIM PIN' Dialog box PIN Text field, 'OK' ,"Cancel' button are disabled  after entering 4 digit SIM PIN

@stevenjb : Please confirm the Issue
Actual_EnabledEnterButton.webm
809 KB View Download
Expected_DisabledButtons.webm
815 KB View Download

Comment 1 by steve...@chromium.org, Dec 1 2017

Labels: -Pri-1 -M-64 M-65 Pri-3
This quialifies as polish. I agree it could be better but this doesn't seem very high priority.

Comment 2 by dsunk...@chromium.org, Jan 30 2018

Cc: rpattumani@chromium.org

Comment 3 by steve...@chromium.org, Feb 1 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/add89c261260aa4c2b196f6ee0fdd60d6fd91c7f

commit add89c261260aa4c2b196f6ee0fdd60d6fd91c7f
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Feb 01 20:28:11 2018

Network sim unlock: fix focus and disable buttons when in progress

This fixes a couple of minor sim unlock polish issues.

Bug:  797749 ,  786344 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9140397f4723c27514e09ce38cd2e527c231e9a9
Reviewed-on: https://chromium-review.googlesource.com/897823
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533798}
[modify] https://crrev.com/add89c261260aa4c2b196f6ee0fdd60d6fd91c7f/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/add89c261260aa4c2b196f6ee0fdd60d6fd91c7f/ui/webui/resources/cr_components/chromeos/network/network_siminfo.js

Comment 5 by steve...@chromium.org, Feb 1 2018

Labels: -Pri-3 Merge-Request-65 Pri-2
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 2 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 5 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9130c715daa88497843d09c66de6d7eacdec8ae2

commit 9130c715daa88497843d09c66de6d7eacdec8ae2
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 05 20:05:10 2018

Network sim unlock: fix focus and disable buttons when in progress

This fixes a couple of minor sim unlock polish issues.

TBR=stevenjb@chromium.org

(cherry picked from commit add89c261260aa4c2b196f6ee0fdd60d6fd91c7f)

Bug:  797749 ,  786344 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9140397f4723c27514e09ce38cd2e527c231e9a9
Reviewed-on: https://chromium-review.googlesource.com/897823
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533798}
Reviewed-on: https://chromium-review.googlesource.com/902428
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#314}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/9130c715daa88497843d09c66de6d7eacdec8ae2/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/9130c715daa88497843d09c66de6d7eacdec8ae2/ui/webui/resources/cr_components/chromeos/network/network_siminfo.js

Comment 8 by mmanchala@chromium.org, Oct 4 

Checked and Issue is working fine on latest M-70 70.0.3538.41/11021.37.0 beta-channel Candy

Thanks..!!
►

Sign in to add a comment