New issue
Advanced search Search tips

Issue 786332 link

Starred by 7 users

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 827065



Sign in to add a comment

Replace base::ThreadTaskRunnerHandle::Get() with other appropriate task runners

Project Member Reported by hajimehoshi@chromium.org, Nov 17 2017

Issue description

This is a meta issue to replace base::ThreadTaskRunnerHandle::Get() with other appropriate task runners.

EDIT:

Our goal is to replace thread-local task runners with per-frame task runners with task types so that
* We will be able to get information what type of tasks take long time for execution
* Based on the information, we will be able to make the task scheduling.

This issue treats ThreadTaskRunnerHandle that is the thread-local task runner. Which task type should be used depends on where and how the task runner is used.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b

commit abb3c8f751ab5b0da94ac92872b3ee9a45cd796b
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Dec 04 18:41:39 2017

Use appropriate task runners for RenderWidget

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
with other appropriate task runners in the renderer.

Bug: 786332
Change-Id: I60a347a77fe9c948e63e8b38086bc2969dee32de
Reviewed-on: https://chromium-review.googlesource.com/778755
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521395}
[modify] https://crrev.com/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b/content/public/test/render_view_test.cc
[modify] https://crrev.com/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b/content/renderer/render_view_impl.cc
[modify] https://crrev.com/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b/content/renderer/render_view_impl.h
[modify] https://crrev.com/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b/content/renderer/render_widget.cc
[modify] https://crrev.com/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b/content/renderer/render_widget.h
[modify] https://crrev.com/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b/content/test/layouttest_support.cc
[modify] https://crrev.com/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/abb3c8f751ab5b0da94ac92872b3ee9a45cd796b/third_party/WebKit/public/web/WebViewClient.h

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7e564426b4bff15e69a5cec84a1e4f1af03ad02

commit a7e564426b4bff15e69a5cec84a1e4f1af03ad02
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Dec 05 04:22:01 2017

Use appropriate tasks at RenderWidgetCompositor

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
with other appropriate task runners in the renderer.

Bug: 786332
Change-Id: Ic63ac5a7cef4546603ec211c81fa64c49595cee2
Reviewed-on: https://chromium-review.googlesource.com/805576
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521614}
[modify] https://crrev.com/a7e564426b4bff15e69a5cec84a1e4f1af03ad02/content/renderer/gpu/render_widget_compositor.cc

Cc: japhet@chromium.org hajimehoshi@chromium.org tzik@chromium.org
 Issue 765623  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 6 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb3b14569390a04f3b458f75163930b713b033f5

commit bb3b14569390a04f3b458f75163930b713b033f5
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Dec 07 08:40:27 2017

Use appropriate task runners at DevToolAgent::IOSession

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
with other appropriate task runners in the renderer.

Bug: 786332
Change-Id: I71f58741822d6515d72210b93edba326c84f89b9
Reviewed-on: https://chromium-review.googlesource.com/807867
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522382}
[modify] https://crrev.com/bb3b14569390a04f3b458f75163930b713b033f5/content/renderer/devtools/devtools_agent.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afcdd0d1ee9f50889c69e7757905034a7c72fe20

commit afcdd0d1ee9f50889c69e7757905034a7c72fe20
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Dec 07 12:11:18 2017

Use appropriate task runners at RTCPeerConnectionHandle

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
with other appropriate task runners in the renderer.

I adopted kUnthrottled not to change the current behavior, and we need
to replace a more appropriate task type in near future.

Bug: 786332
Change-Id: I0b7f399007f6999cb276c35057ae5526aa5477fc
Reviewed-on: https://chromium-review.googlesource.com/813655
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522402}
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/content/renderer/media/peer_connection_tracker_unittest.cc
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/content/renderer/media/rtc_peer_connection_handler.cc
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/content/renderer/media/rtc_peer_connection_handler.h
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/content/renderer/media/webrtc/peer_connection_dependency_factory.h
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/content/renderer/media/webrtc/peer_connection_dependency_factory_unittest.cc
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithWebRTC.cpp
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithWebRTC.h
[modify] https://crrev.com/afcdd0d1ee9f50889c69e7757905034a7c72fe20/third_party/WebKit/public/platform/Platform.h

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07716a9982d840c716e6377cfbdea5453b854c76

commit 07716a9982d840c716e6377cfbdea5453b854c76
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Dec 11 04:03:29 2017

Use appropriate task runners at PrintFrameAsync (pixel_dump.cc)

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
with other appropriate task runners in the renderer.

Bug: 786332
Change-Id: I3e7a8b88dbb85c1af56554507ec71f87e64a3d89
Reviewed-on: https://chromium-review.googlesource.com/807762
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523043}
[modify] https://crrev.com/07716a9982d840c716e6377cfbdea5453b854c76/content/shell/test_runner/pixel_dump.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73bbc69bba56e88f35574df1a042d4f4809c3512

commit 73bbc69bba56e88f35574df1a042d4f4809c3512
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Dec 13 10:05:31 2017

HTMLMediaElementCapture: use Blink-provided foreground task runner

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
with other appropriate task runners in the renderer.

Bug: 786332
Change-Id: I431671dc03fa7157c25433575c3cdd5cf75d098a
Reviewed-on: https://chromium-review.googlesource.com/808447
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523734}
[modify] https://crrev.com/73bbc69bba56e88f35574df1a042d4f4809c3512/content/renderer/media_capture_from_element/html_video_element_capturer_source.cc
[modify] https://crrev.com/73bbc69bba56e88f35574df1a042d4f4809c3512/content/renderer/media_capture_from_element/html_video_element_capturer_source.h
[modify] https://crrev.com/73bbc69bba56e88f35574df1a042d4f4809c3512/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/73bbc69bba56e88f35574df1a042d4f4809c3512/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/73bbc69bba56e88f35574df1a042d4f4809c3512/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/73bbc69bba56e88f35574df1a042d4f4809c3512/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp
[modify] https://crrev.com/73bbc69bba56e88f35574df1a042d4f4809c3512/third_party/WebKit/public/platform/Platform.h

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0755c943610259ed719e3759428970e282dc79c9

commit 0755c943610259ed719e3759428970e282dc79c9
Author: Alexander Timin <altimin@chromium.org>
Date: Fri Dec 15 02:15:57 2017

[blink] Use per-frame task runner in AsyncMethodRunner

Posting async tasks to the default timer queue can lead to media tasks
being throttled, which may lead to videos being stopped in background.

R=haraken@chromium.org,hajimehoshi@chromium.org
BUG= 779962 , 786332

Change-Id: Ic50890f909ed824a9d8048d5ef5af590b3cd086b
Reviewed-on: https://chromium-review.googlesource.com/822931
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524292}
[modify] https://crrev.com/0755c943610259ed719e3759428970e282dc79c9/third_party/WebKit/Source/core/css/FontFaceSet.h
[modify] https://crrev.com/0755c943610259ed719e3759428970e282dc79c9/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp
[modify] https://crrev.com/0755c943610259ed719e3759428970e282dc79c9/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/0755c943610259ed719e3759428970e282dc79c9/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
[modify] https://crrev.com/0755c943610259ed719e3759428970e282dc79c9/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/0755c943610259ed719e3759428970e282dc79c9/third_party/WebKit/Source/modules/mediastream/MediaDevices.h
[modify] https://crrev.com/0755c943610259ed719e3759428970e282dc79c9/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/0755c943610259ed719e3759428970e282dc79c9/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/0755c943610259ed719e3759428970e282dc79c9/third_party/WebKit/Source/platform/AsyncMethodRunner.h
[modify] https://crrev.com/0755c943610259ed719e3759428970e282dc79c9/third_party/WebKit/Source/platform/Timer.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c3194b50a044aaecd2948cfbe1aa290ba31fee6

commit 6c3194b50a044aaecd2948cfbe1aa290ba31fee6
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Dec 15 03:02:11 2017

VideoDecodeStatsReporter: use Blink-provided foreground task runner

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
with other appropriate task runners in the renderer.

Bug: 786332
Change-Id: I6310554d4cdbc93cd6420398ecfe9e668059dd99
Reviewed-on: https://chromium-review.googlesource.com/826605
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524305}
[modify] https://crrev.com/6c3194b50a044aaecd2948cfbe1aa290ba31fee6/media/blink/video_decode_stats_reporter.cc
[modify] https://crrev.com/6c3194b50a044aaecd2948cfbe1aa290ba31fee6/media/blink/video_decode_stats_reporter.h
[modify] https://crrev.com/6c3194b50a044aaecd2948cfbe1aa290ba31fee6/media/blink/video_decode_stats_reporter_unittest.cc
[modify] https://crrev.com/6c3194b50a044aaecd2948cfbe1aa290ba31fee6/media/blink/webmediaplayer_impl.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b32164697acb8cda5c9286500ffd2e737367574f

commit b32164697acb8cda5c9286500ffd2e737367574f
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Dec 19 05:45:14 2017

content/renderer/media: Use Blink-provided task runners for timers

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I2ee7b4e070087ec0886c22106eab8defec83a9cf
Reviewed-on: https://chromium-review.googlesource.com/831926
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524949}
[modify] https://crrev.com/b32164697acb8cda5c9286500ffd2e737367574f/content/renderer/media/renderer_webmediaplayer_delegate.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bb37dc7df38abbc83ed40fc0df191e793a417f5

commit 8bb37dc7df38abbc83ed40fc0df191e793a417f5
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Dec 19 09:35:10 2017

media/blink: Use Blink-provided task runners for timers

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I7c687b86e866b226022fc03580bc47c5a923a708
Reviewed-on: https://chromium-review.googlesource.com/831789
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524981}
[modify] https://crrev.com/8bb37dc7df38abbc83ed40fc0df191e793a417f5/media/blink/watch_time_reporter.cc
[modify] https://crrev.com/8bb37dc7df38abbc83ed40fc0df191e793a417f5/media/blink/watch_time_reporter.h
[modify] https://crrev.com/8bb37dc7df38abbc83ed40fc0df191e793a417f5/media/blink/watch_time_reporter_unittest.cc
[modify] https://crrev.com/8bb37dc7df38abbc83ed40fc0df191e793a417f5/media/blink/webmediaplayer_impl.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/747cb1afa7ec0b160837f87626161d29f97063af

commit 747cb1afa7ec0b160837f87626161d29f97063af
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Dec 21 07:37:39 2017

Use kInternalTest in tests of third_party/WebKit

Bug: 786332
Change-Id: Ie21faf194d11fe1156836e0711ca4e815e66dacc
Reviewed-on: https://chromium-review.googlesource.com/839022
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525640}
[modify] https://crrev.com/747cb1afa7ec0b160837f87626161d29f97063af/third_party/WebKit/Source/platform/TimerTest.cpp
[modify] https://crrev.com/747cb1afa7ec0b160837f87626161d29f97063af/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 3 2018

Labels: merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0fdddca6a341d664241c1563e0f4d5c61c5dc95

commit c0fdddca6a341d664241c1563e0f4d5c61c5dc95
Author: Alexander Timin <altimin@chromium.org>
Date: Wed Jan 03 15:41:55 2018

[blink] Use per-frame task runner in AsyncMethodRunner

Posting async tasks to the default timer queue can lead to media tasks
being throttled, which may lead to videos being stopped in background.

R=hajimehoshi@chromium.org, haraken@chromium.org
TBR=altimin@chromium.org
BUG= 779962 , 786332

(cherry picked from commit f841a10836c67904024381b00419de87cb406423)

Change-Id: Ic50890f909ed824a9d8048d5ef5af590b3cd086b
Reviewed-on: https://chromium-review.googlesource.com/822931
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524292}
Reviewed-on: https://chromium-review.googlesource.com/849003
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#397}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/c0fdddca6a341d664241c1563e0f4d5c61c5dc95/third_party/WebKit/Source/core/css/FontFaceSet.h
[modify] https://crrev.com/c0fdddca6a341d664241c1563e0f4d5c61c5dc95/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp
[modify] https://crrev.com/c0fdddca6a341d664241c1563e0f4d5c61c5dc95/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/c0fdddca6a341d664241c1563e0f4d5c61c5dc95/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
[modify] https://crrev.com/c0fdddca6a341d664241c1563e0f4d5c61c5dc95/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/c0fdddca6a341d664241c1563e0f4d5c61c5dc95/third_party/WebKit/Source/modules/mediastream/MediaDevices.h
[modify] https://crrev.com/c0fdddca6a341d664241c1563e0f4d5c61c5dc95/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/c0fdddca6a341d664241c1563e0f4d5c61c5dc95/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/c0fdddca6a341d664241c1563e0f4d5c61c5dc95/third_party/WebKit/Source/platform/AsyncMethodRunner.h
[modify] https://crrev.com/c0fdddca6a341d664241c1563e0f4d5c61c5dc95/third_party/WebKit/Source/platform/Timer.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20578c6457bffebea7baca862a14901aa5bb017a

commit 20578c6457bffebea7baca862a14901aa5bb017a
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Jan 12 09:43:26 2018

Deprecate RenderThradImpl::GetMainTaskRunner() and replace its usages

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: If002697262af2982eec003e89aba9039b120d838
Reviewed-on: https://chromium-review.googlesource.com/858880
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528914}
[modify] https://crrev.com/20578c6457bffebea7baca862a14901aa5bb017a/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/20578c6457bffebea7baca862a14901aa5bb017a/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/20578c6457bffebea7baca862a14901aa5bb017a/content/renderer/render_thread_impl.h

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/138652c9e5bc18add6649a2651162193b2053dc6

commit 138652c9e5bc18add6649a2651162193b2053dc6
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Jan 12 15:11:44 2018

Make task runners at RTCPeerConnectionHandle in WaitableEventWatcher changeable

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
or base::SequencedTaskRunnerHandle::Get() with other appropriate task
runners in the renderer.

This CL changes WaitableEventWatcher to have task runners, and enables users
of the watcher decide which task runner they use.

Bug: 786332
Change-Id: Iff3e2ae6096037d99790a8484ce2ee970f9d4028
Reviewed-on: https://chromium-review.googlesource.com/816643
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528945}
[modify] https://crrev.com/138652c9e5bc18add6649a2651162193b2053dc6/base/message_loop/message_pump_libevent_unittest.cc
[modify] https://crrev.com/138652c9e5bc18add6649a2651162193b2053dc6/base/synchronization/waitable_event_watcher.h
[modify] https://crrev.com/138652c9e5bc18add6649a2651162193b2053dc6/base/synchronization/waitable_event_watcher_mac.cc
[modify] https://crrev.com/138652c9e5bc18add6649a2651162193b2053dc6/base/synchronization/waitable_event_watcher_posix.cc
[modify] https://crrev.com/138652c9e5bc18add6649a2651162193b2053dc6/base/synchronization/waitable_event_watcher_unittest.cc
[modify] https://crrev.com/138652c9e5bc18add6649a2651162193b2053dc6/base/synchronization/waitable_event_watcher_win.cc
[modify] https://crrev.com/138652c9e5bc18add6649a2651162193b2053dc6/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/138652c9e5bc18add6649a2651162193b2053dc6/ipc/ipc_channel_proxy.h
[modify] https://crrev.com/138652c9e5bc18add6649a2651162193b2053dc6/ipc/ipc_sync_channel.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/757009b75b285c6918364d0a0159824a639a491b

commit 757009b75b285c6918364d0a0159824a639a491b
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Jan 16 06:42:40 2018

WebCrypto: Use Blink-provided task runners for timers

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Idec5b202c5e408829ba256d27a115ab834ead714
Reviewed-on: https://chromium-review.googlesource.com/839385
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529370}
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/components/webcrypto/webcrypto_impl.cc
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/components/webcrypto/webcrypto_impl.h
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/third_party/WebKit/Source/platform/testing/MockWebCrypto.h
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/third_party/WebKit/public/platform/TaskType.h
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/third_party/WebKit/public/platform/WebCrypto.h
[modify] https://crrev.com/757009b75b285c6918364d0a0159824a639a491b/tools/metrics/histograms/enums.xml

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db0761a449c7d09125e16932ec1b8ed04e64c469

commit db0761a449c7d09125e16932ec1b8ed04e64c469
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Jan 18 08:10:19 2018

media: Use per-frame task runners at media::PipelineImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: If3f06d8880d6b158e326eb04ae9fc9e9d9ba6ac1
Reviewed-on: https://chromium-review.googlesource.com/870015
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530088}
[modify] https://crrev.com/db0761a449c7d09125e16932ec1b8ed04e64c469/media/base/pipeline_impl.cc
[modify] https://crrev.com/db0761a449c7d09125e16932ec1b8ed04e64c469/media/base/pipeline_impl.h
[modify] https://crrev.com/db0761a449c7d09125e16932ec1b8ed04e64c469/media/base/pipeline_impl_unittest.cc
[modify] https://crrev.com/db0761a449c7d09125e16932ec1b8ed04e64c469/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/db0761a449c7d09125e16932ec1b8ed04e64c469/media/test/pipeline_integration_test_base.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9530e58186af0b329bc66ce96d025cd03ce279f

commit b9530e58186af0b329bc66ce96d025cd03ce279f
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Jan 18 22:19:41 2018

indexdb: Use Blink-provided task runners for callbacks

The old CL (https://chromium-review.googlesource.com/c/chromium/src/+/839321)
passed the main task runner at RendererBlinkPlatformImpl initialization,
and this caused thread-mismatching when the IndexedDB is used at workers.

This CL instead passes task runners from IndexedDB user side.

This CL also adds a new internal TaskType kInternalIndexedDB for
our task-execution-time analyzation.

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I5513fe071407664dffb985d9961f773ce5b736a7
Reviewed-on: https://chromium-review.googlesource.com/867970
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530297}
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/indexed_db_callbacks_impl.h
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/indexed_db_database_callbacks_impl.h
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/webidbcursor_impl.cc
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/webidbcursor_impl.h
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/webidbcursor_impl_unittest.cc
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/webidbdatabase_impl.cc
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/webidbdatabase_impl.h
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/webidbdatabase_impl_unittest.cc
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/webidbfactory_impl.cc
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/content/renderer/indexed_db/webidbfactory_impl.h
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/third_party/WebKit/public/platform/TaskType.h
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/third_party/WebKit/public/platform/modules/indexeddb/WebIDBFactory.h
[modify] https://crrev.com/b9530e58186af0b329bc66ce96d025cd03ce279f/tools/metrics/histograms/enums.xml

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d8a485850760b3d35785c4088e1128c4929cacf

commit 7d8a485850760b3d35785c4088e1128c4929cacf
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Jan 23 08:44:53 2018

media: Use per-frame task runners at RenderMediaLog

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Ia812986308a92b4169548bb788ae14b9905f7010
Reviewed-on: https://chromium-review.googlesource.com/872832
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531186}
[modify] https://crrev.com/7d8a485850760b3d35785c4088e1128c4929cacf/content/renderer/media/media_factory.cc
[modify] https://crrev.com/7d8a485850760b3d35785c4088e1128c4929cacf/content/renderer/media/render_media_log.cc
[modify] https://crrev.com/7d8a485850760b3d35785c4088e1128c4929cacf/content/renderer/media/render_media_log.h
[modify] https://crrev.com/7d8a485850760b3d35785c4088e1128c4929cacf/content/renderer/media/render_media_log_unittest.cc
[modify] https://crrev.com/7d8a485850760b3d35785c4088e1128c4929cacf/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc
[modify] https://crrev.com/7d8a485850760b3d35785c4088e1128c4929cacf/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/7d8a485850760b3d35785c4088e1128c4929cacf/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/7d8a485850760b3d35785c4088e1128c4929cacf/third_party/WebKit/public/platform/TaskType.h
[modify] https://crrev.com/7d8a485850760b3d35785c4088e1128c4929cacf/tools/metrics/histograms/enums.xml

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2f2ce6989291ada20b50bae26a7449f719cd683

commit d2f2ce6989291ada20b50bae26a7449f719cd683
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Jan 25 05:39:49 2018

media: Use per-frame task runners at WebRTCMediaStreamAdapterMap and WebRtcMediaStreamTrackAdapterMap

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I300a38816bef6bb8f371203aaad52cb31154309a
Reviewed-on: https://chromium-review.googlesource.com/882713
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531820}
[modify] https://crrev.com/d2f2ce6989291ada20b50bae26a7449f719cd683/content/renderer/media/rtc_peer_connection_handler.cc
[modify] https://crrev.com/d2f2ce6989291ada20b50bae26a7449f719cd683/content/renderer/media/webrtc/rtc_rtp_sender_unittest.cc
[modify] https://crrev.com/d2f2ce6989291ada20b50bae26a7449f719cd683/content/renderer/media/webrtc/webrtc_media_stream_adapter_map.cc
[modify] https://crrev.com/d2f2ce6989291ada20b50bae26a7449f719cd683/content/renderer/media/webrtc/webrtc_media_stream_adapter_map.h
[modify] https://crrev.com/d2f2ce6989291ada20b50bae26a7449f719cd683/content/renderer/media/webrtc/webrtc_media_stream_adapter_map_unittest.cc
[modify] https://crrev.com/d2f2ce6989291ada20b50bae26a7449f719cd683/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[modify] https://crrev.com/d2f2ce6989291ada20b50bae26a7449f719cd683/content/renderer/media/webrtc/webrtc_media_stream_track_adapter_map.cc
[modify] https://crrev.com/d2f2ce6989291ada20b50bae26a7449f719cd683/content/renderer/media/webrtc/webrtc_media_stream_track_adapter_map.h
[modify] https://crrev.com/d2f2ce6989291ada20b50bae26a7449f719cd683/content/renderer/media/webrtc/webrtc_media_stream_track_adapter_map_unittest.cc
[modify] https://crrev.com/d2f2ce6989291ada20b50bae26a7449f719cd683/content/renderer/media/webrtc/webrtc_set_remote_description_observer_unittest.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b0206984fe8d7ef9711240f0c6ff265f7e66852

commit 1b0206984fe8d7ef9711240f0c6ff265f7e66852
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Feb 01 10:50:21 2018

media: Use per-frame task runners in VideoTrackRecoder

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Ic48ed9957db962978f8f82c21d21aea0b634490f
Reviewed-on: https://chromium-review.googlesource.com/890981
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533626}
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/media_recorder/media_recorder_handler.cc
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/media_recorder/media_recorder_handler.h
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/media_recorder/media_recorder_handler_unittest.cc
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/media_recorder/vea_encoder.cc
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/media_recorder/vea_encoder.h
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/media_recorder/video_track_recorder.cc
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/media_recorder/video_track_recorder.h
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/media_recorder/video_track_recorder_unittest.cc
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/media_recorder/vpx_encoder.cc
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/media_recorder/vpx_encoder.h
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/third_party/WebKit/public/platform/TaskType.h
[modify] https://crrev.com/1b0206984fe8d7ef9711240f0c6ff265f7e66852/tools/metrics/histograms/enums.xml

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/034684a2429125f8b5ac35dd8fd7620c11346929

commit 034684a2429125f8b5ac35dd8fd7620c11346929
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Feb 01 11:16:11 2018

Revert "media: Use per-frame task runners in VideoTrackRecoder"

This reverts commit 1b0206984fe8d7ef9711240f0c6ff265f7e66852.

Reason for revert: Compile error on Google Chrome Linux x64:

../../content/renderer/media_recorder/h264_encoder.cc:40:7: error: no matching constructor for initialization of 'VideoTrackRecorder::Encoder'
    : Encoder(on_encoded_video_callback, bits_per_second) {
      ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../content/renderer/media_recorder/video_track_recorder.h:161:30: note: candidate constructor not viable: requires 1 argument, but 2 were provided
    DISALLOW_COPY_AND_ASSIGN(Encoder);
                             ^
../../content/renderer/media_recorder/video_track_recorder.h:88:5: note: candidate constructor not viable: requires at least 3 arguments, but 2 were provided
    Encoder(const OnEncodedVideoCB& on_encoded_video_callback,

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F27069%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

Original change's description:
> media: Use per-frame task runners in VideoTrackRecoder
> 
> This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
> and SequencedTaskRunnerHandle::Get() with other appropriate task runners
> in the renderer.
> 
> Bug: 786332
> Change-Id: Ic48ed9957db962978f8f82c21d21aea0b634490f
> Reviewed-on: https://chromium-review.googlesource.com/890981
> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533626}

TBR=mcasas@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,mlamouri@chromium.org,altimin@chromium.org

Change-Id: I800504dacec8da23affc92381cb4d0b0da7e8030
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 786332
Reviewed-on: https://chromium-review.googlesource.com/897642
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533630}
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/media_recorder/media_recorder_handler.cc
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/media_recorder/media_recorder_handler.h
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/media_recorder/media_recorder_handler_unittest.cc
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/media_recorder/vea_encoder.cc
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/media_recorder/vea_encoder.h
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/media_recorder/video_track_recorder.cc
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/media_recorder/video_track_recorder.h
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/media_recorder/video_track_recorder_unittest.cc
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/media_recorder/vpx_encoder.cc
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/media_recorder/vpx_encoder.h
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/third_party/WebKit/public/platform/TaskType.h
[modify] https://crrev.com/034684a2429125f8b5ac35dd8fd7620c11346929/tools/metrics/histograms/enums.xml

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e3efaaa10193945c0d6ea369cd8962f20d40af0

commit 0e3efaaa10193945c0d6ea369cd8962f20d40af0
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Feb 01 16:00:24 2018

media: Use per-frame task runners in VideoTrackRecoder (reland)

This is basically same as https://chromium-review.googlesource.com/c/chromium/src/+/890981,
but includes fix for H264 encoder.

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

TBR=hajimehoshi@chromium.org

Bug: 786332
Change-Id: Ifffbfbfb5fffb2e9b8619ba4e4b2e116633b6ebb
Reviewed-on: https://chromium-review.googlesource.com/897319
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533684}
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/h264_encoder.cc
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/h264_encoder.h
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/media_recorder_handler.cc
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/media_recorder_handler.h
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/media_recorder_handler_unittest.cc
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/vea_encoder.cc
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/vea_encoder.h
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/video_track_recorder.cc
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/video_track_recorder.h
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/video_track_recorder_unittest.cc
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/vpx_encoder.cc
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/media_recorder/vpx_encoder.h
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/third_party/WebKit/public/platform/TaskType.h
[modify] https://crrev.com/0e3efaaa10193945c0d6ea369cd8962f20d40af0/tools/metrics/histograms/enums.xml

Description: Show this description
Project Member

Comment 27 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36154b50792ab6e10d608373da7397ead7503b23

commit 36154b50792ab6e10d608373da7397ead7503b23
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Feb 05 05:18:09 2018

media: Use per-web-frame task runners in MediaStreamVideoWebRtcSink

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Icab73ee772261c2a21dc38d4abdc34b806021751
Reviewed-on: https://chromium-review.googlesource.com/890999
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534333}
[modify] https://crrev.com/36154b50792ab6e10d608373da7397ead7503b23/content/renderer/media/webrtc/media_stream_video_webrtc_sink.cc
[modify] https://crrev.com/36154b50792ab6e10d608373da7397ead7503b23/content/renderer/media/webrtc/media_stream_video_webrtc_sink.h
[modify] https://crrev.com/36154b50792ab6e10d608373da7397ead7503b23/content/renderer/media/webrtc/media_stream_video_webrtc_sink_unittest.cc
[modify] https://crrev.com/36154b50792ab6e10d608373da7397ead7503b23/content/renderer/media/webrtc/webrtc_media_stream_track_adapter.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2232731be4da9e278b65919c6ef2f8a3f3e10fc9

commit 2232731be4da9e278b65919c6ef2f8a3f3e10fc9
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Feb 20 03:19:03 2018

Use test task runner at TestMediaStreamVideoRenderer

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Ia2d707ef8de3a9addcbec2d3da9f7214225e9f78
Reviewed-on: https://chromium-review.googlesource.com/923252
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537702}
[modify] https://crrev.com/2232731be4da9e278b65919c6ef2f8a3f3e10fc9/content/shell/renderer/layout_test/test_media_stream_video_renderer.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812

commit ad6f4e88ca12720b561f3c5e7e2b3831a73e0812
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Feb 20 03:20:43 2018

Use per-frame task runner at AssociateBiding::Bind usages at RenderFrameImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 780785, 786332
Change-Id: I78cb3555cdf9e77c65db286fd37c887d6ac30d56
Reviewed-on: https://chromium-review.googlesource.com/923626
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537703}
[modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc
[modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/third_party/WebKit/public/platform/TaskType.h
[modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/tools/metrics/histograms/enums.xml

Project Member

Comment 30 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62669efc451e64be26455e7901da155a56d871d7

commit 62669efc451e64be26455e7901da155a56d871d7
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Feb 21 04:39:06 2018

media: Use per-frame task runners at MediaFactory's compositor task runner

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I78cc6a085c2644f2188cb8e90203924c735861a1
Reviewed-on: https://chromium-review.googlesource.com/873250
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538022}
[modify] https://crrev.com/62669efc451e64be26455e7901da155a56d871d7/content/renderer/media/media_factory.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Feb 22 2018

Labels: merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6732c99e8f1417077d36ca726154690d768e9df8

commit 6732c99e8f1417077d36ca726154690d768e9df8
Author: Guido Urdaneta <guidou@chromium.org>
Date: Thu Feb 22 20:32:49 2018

media: Use per-frame task runners at WebRTCMediaStreamAdapterMap and WebRtcMediaStreamTrackAdapterMap

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

TBR=hajimehoshi@chromium.org

(cherry picked from commit d2f2ce6989291ada20b50bae26a7449f719cd683)

Bug: 786332
Change-Id: I300a38816bef6bb8f371203aaad52cb31154309a
Reviewed-on: https://chromium-review.googlesource.com/882713
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531820}
Reviewed-on: https://chromium-review.googlesource.com/931803
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#554}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/6732c99e8f1417077d36ca726154690d768e9df8/content/renderer/media/rtc_peer_connection_handler.cc
[modify] https://crrev.com/6732c99e8f1417077d36ca726154690d768e9df8/content/renderer/media/webrtc/rtc_rtp_sender_unittest.cc
[modify] https://crrev.com/6732c99e8f1417077d36ca726154690d768e9df8/content/renderer/media/webrtc/webrtc_media_stream_adapter_map.cc
[modify] https://crrev.com/6732c99e8f1417077d36ca726154690d768e9df8/content/renderer/media/webrtc/webrtc_media_stream_adapter_map.h
[modify] https://crrev.com/6732c99e8f1417077d36ca726154690d768e9df8/content/renderer/media/webrtc/webrtc_media_stream_adapter_map_unittest.cc
[modify] https://crrev.com/6732c99e8f1417077d36ca726154690d768e9df8/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
[modify] https://crrev.com/6732c99e8f1417077d36ca726154690d768e9df8/content/renderer/media/webrtc/webrtc_media_stream_track_adapter_map.cc
[modify] https://crrev.com/6732c99e8f1417077d36ca726154690d768e9df8/content/renderer/media/webrtc/webrtc_media_stream_track_adapter_map.h
[modify] https://crrev.com/6732c99e8f1417077d36ca726154690d768e9df8/content/renderer/media/webrtc/webrtc_media_stream_track_adapter_map_unittest.cc
[modify] https://crrev.com/6732c99e8f1417077d36ca726154690d768e9df8/content/renderer/media/webrtc/webrtc_set_remote_description_observer_unittest.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efa3bdc371761e9c1934816c3b3b1bb6ec2ee884

commit efa3bdc371761e9c1934816c3b3b1bb6ec2ee884
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Feb 23 01:23:35 2018

Use per-frame task runner at ResourceFetcherImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 780785, 786332
Change-Id: I044ee9e5d29f82d133faab3dd7097615e452683e
Reviewed-on: https://chromium-review.googlesource.com/930982
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538654}
[modify] https://crrev.com/efa3bdc371761e9c1934816c3b3b1bb6ec2ee884/content/renderer/fetchers/resource_fetcher_impl.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a05c4b140df29bcef7e2b7747f158b4227629db

commit 9a05c4b140df29bcef7e2b7747f158b4227629db
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Feb 26 05:10:17 2018

media: Use task runner for testing in MockPeerConnectionTrackerHost

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 780785, 786332
Change-Id: Ic9801a4896dd4d9a70f9b9fa4f5b26dc474db224
Reviewed-on: https://chromium-review.googlesource.com/930524
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539071}
[modify] https://crrev.com/9a05c4b140df29bcef7e2b7747f158b4227629db/content/renderer/media/webrtc/peer_connection_tracker_unittest.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d45800c05cd94d58da5627510bfc397b75800dc3

commit d45800c05cd94d58da5627510bfc397b75800dc3
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Feb 27 07:45:51 2018

Pass a task runner to mojo::SimpleWatcher at web_service_worker_installed_scripts_manager_impl.cc

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

This avoids the SequencedTaskRunnerHandle::Get() call when the constructor's
default parameter is used. We are trying to ban SequencedTaskRunnerHandle::Get()
in content/renderer because it usually is not the right task runner to use,
as a per-frame runner should be used instead. In this case, it doesn't
really matter since frames are not involved, but we still want to remove the
calls for the bigger benefit of banning it in content/renderer.

Bug: 780785, 786332
Change-Id: I307cd4923912809b0577074585ea9fd953a84ef3
Reviewed-on: https://chromium-review.googlesource.com/937104
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539410}
[modify] https://crrev.com/d45800c05cd94d58da5627510bfc397b75800dc3/content/renderer/service_worker/web_service_worker_installed_scripts_manager_impl.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd69a4d508258c854a94c8c40ebb70abfbec614c

commit bd69a4d508258c854a94c8c40ebb70abfbec614c
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Mar 01 09:43:55 2018

Use per-frame task runners at WebDataConsumerHandleImpl::handle_watcher_

This CL also fixes WebDataConsumerHandle and its children classes.

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 780785, 786332
Change-Id: Ia0ab834c52614190a49d74b177f07b2f3b3193e0
Reviewed-on: https://chromium-review.googlesource.com/934381
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540118}
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/shared_memory_data_consumer_handle.cc
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/shared_memory_data_consumer_handle.h
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/shared_memory_data_consumer_handle_unittest.cc
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/web_data_consumer_handle_impl.cc
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/web_data_consumer_handle_impl.h
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/web_data_consumer_handle_impl_unittest.cc
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/fetch/BytesConsumerForDataConsumerHandle.cpp
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/fetch/BytesConsumerForDataConsumerHandleTest.cpp
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/fetch/DataConsumerHandleTestUtil.cpp
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/fetch/DataConsumerHandleTestUtil.h
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/fetch/FetchManager.cpp
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/public/platform/WebDataConsumerHandle.h

Project Member

Comment 36 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/605413f349ecd6bcb0e82f2e8f5c1006437e129f

commit 605413f349ecd6bcb0e82f2e8f5c1006437e129f
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Mar 02 11:49:54 2018

Use more appropriate task runners at WorkerThreadMessageFilter

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 780785, 786332
Change-Id: If4653c563a28d5afaa544fdf8d3450df2ad0bb2e
Reviewed-on: https://chromium-review.googlesource.com/939144
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540495}
[modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/cache_storage/cache_storage_message_filter.cc
[modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/cache_storage/cache_storage_message_filter.h
[modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/notifications/notification_dispatcher.cc
[modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/notifications/notification_dispatcher.h
[modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/service_worker/service_worker_message_filter.cc
[modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/service_worker/service_worker_message_filter.h
[modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/worker_thread_message_filter.cc
[modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/worker_thread_message_filter.h

Project Member

Comment 37 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f34374413586041c722b15a92a9777fa739e999e

commit f34374413586041c722b15a92a9777fa739e999e
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Mar 05 14:32:54 2018

Pass a task runner to base::Timer at RenderViewImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

This avoids the SequencedTaskRunnerHandle::Get() call when the constructor's
default parameter is used. We are trying to ban SequencedTaskRunnerHandle::Get()
in content/renderer because it usually is not the right task runner to use,
as a per-frame runner should be used instead. In this case, it doesn't
really matter since frames are not involved, but we still want to remove the
calls for the bigger benefit of banning it in content/renderer.

Bug: 786332
Change-Id: I96a5c6657c029bd685e2302a778316b69b3af683
Reviewed-on: https://chromium-review.googlesource.com/942287
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540820}
[modify] https://crrev.com/f34374413586041c722b15a92a9777fa739e999e/content/renderer/render_view_impl.cc
[modify] https://crrev.com/f34374413586041c722b15a92a9777fa739e999e/content/renderer/render_view_impl.h

Project Member

Comment 38 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b20babf105de02d90d61e1f206e557abc802541

commit 9b20babf105de02d90d61e1f206e557abc802541
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Mar 07 11:20:34 2018

Pass a task runner to base::Timer at RenderThreadImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

This avoids the SequencedTaskRunnerHandle::Get() call when the constructor's
default parameter is used. We are trying to ban SequencedTaskRunnerHandle::Get()
in content/renderer because it usually is not the right task runner to use,
as a per-frame runner should be used instead. In this case, it doesn't
really matter since frames are not involved, but we still want to remove the
calls for the bigger benefit of banning it in content/renderer.

Bug: 786332
Change-Id: Ie4774c11b5c8a69985a7fb5ba583429426069d48
Reviewed-on: https://chromium-review.googlesource.com/942702
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541410}
[modify] https://crrev.com/9b20babf105de02d90d61e1f206e557abc802541/content/renderer/render_thread_impl.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c4744005269723f94a01405787dbeb1dd408aee

commit 3c4744005269723f94a01405787dbeb1dd408aee
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Mar 09 15:28:03 2018

Pass a task runner to ServiceWorkerContextClient explicitly

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

This avoids the ThreadTaskRunnerHandle::Get() usage. We are trying to
ban ThreadTaskRunnerHandle::Get() in content/renderer because it usually
is not the right task runner to use, as a per-frame runner should be
used instead. In this case, it doesn't really matter since frames are
not involved, but we still want to remove the calls for the bigger
benefit of banning it in content/renderer.

Bug: 786332
Change-Id: Ia492ce20737e04f4fc0f031ecfb7a1994756588a
Reviewed-on: https://chromium-review.googlesource.com/939210
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542117}
[modify] https://crrev.com/3c4744005269723f94a01405787dbeb1dd408aee/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/3c4744005269723f94a01405787dbeb1dd408aee/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/3c4744005269723f94a01405787dbeb1dd408aee/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/3c4744005269723f94a01405787dbeb1dd408aee/content/renderer/service_worker/service_worker_context_client_unittest.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c97b846696b521de7dd22e5da1a3c5138e8177b

commit 1c97b846696b521de7dd22e5da1a3c5138e8177b
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Mar 16 07:10:10 2018

mojo: Pass task runners explicitly to SimpleWatcher's constructor

We try to remove the default argument (task runner) of SimpleWatcher's
constructor and use more appropriate task runners than
base::SequencedTaskRunnerHandle::Get(), and this CL is the first steps.
Our goal is to eliminate base::STRH::Get() usages in renderer since in
most cases, sequenced-local task runner is not appropriate in renderers.

For now, only FileReaderLoader and FetchDataLoaderAsDataPipe are the
users of the default argument since base::STRH::Get() is not available
there due to presubmit.py.

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id03c8dc750fe5696be3358de761af7f29f22e5e9
Reviewed-on: https://chromium-review.googlesource.com/959948
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543641}
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/components/download/internal/common/stream_handle_input_stream.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/content/browser/appcache/appcache_update_url_loader_request.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/content/browser/appcache/appcache_url_loader_job.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/content/browser/cache_storage/cache_storage_blob_to_disk_cache.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/content/browser/loader/data_pipe_to_source_stream.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/content/browser/loader/source_stream_to_data_pipe.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/content/browser/service_worker/service_worker_data_pipe_reader.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/content/browser/service_worker/service_worker_installed_script_reader.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/content/browser/service_worker/service_worker_new_script_loader.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/media/mojo/common/mojo_data_pipe_read_write.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/media/mojo/common/mojo_decoder_buffer_converter.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/mojo/android/system/watcher_impl.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/mojo/common/data_pipe_drainer.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/mojo/edk/system/data_pipe_unittest.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/mojo/edk/system/multiprocess_message_pipe_unittest.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/mojo/public/cpp/system/file_data_pipe_producer.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/mojo/public/cpp/system/handle_signal_tracker.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/mojo/public/cpp/system/string_data_pipe_producer.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/mojo/public/cpp/system/tests/file_data_pipe_producer_unittest.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/mojo/public/cpp/system/tests/simple_watcher_unittest.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/mojo/public/cpp/system/tests/string_data_pipe_producer_unittest.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/services/network/chunked_data_pipe_upload_data_stream.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/services/network/data_pipe_element_reader.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/services/network/public/cpp/simple_url_loader.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/services/network/test/test_data_pipe_getter.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/services/network/url_loader.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/services/network/url_loader_unittest.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/storage/browser/blob/blob_builder_from_stream.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/storage/browser/blob/blob_transport_strategy.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/storage/browser/blob/mojo_blob_reader.cc
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/third_party/WebKit/Source/core/fetch/FetchDataLoader.cpp
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/third_party/WebKit/Source/platform/blob/BlobBytesProvider.cpp
[modify] https://crrev.com/1c97b846696b521de7dd22e5da1a3c5138e8177b/third_party/WebKit/Source/platform/blob/BlobBytesProviderTest.cpp

Project Member

Comment 41 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4874b0c8a18d43be5c3462e8aa0463abe77214f

commit f4874b0c8a18d43be5c3462e8aa0463abe77214f
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Mar 19 05:49:54 2018

core/fetch: Pass an appropriate task runner to SimpleWatcher via FetchDataLoader

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I2069aba52ec65f4ff6fd7cda0f7c437f072eac89
Reviewed-on: https://chromium-review.googlesource.com/965902
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543977}
[modify] https://crrev.com/f4874b0c8a18d43be5c3462e8aa0463abe77214f/third_party/WebKit/Source/core/fetch/FetchDataLoader.cpp
[modify] https://crrev.com/f4874b0c8a18d43be5c3462e8aa0463abe77214f/third_party/WebKit/Source/core/fetch/FetchDataLoader.h
[modify] https://crrev.com/f4874b0c8a18d43be5c3462e8aa0463abe77214f/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[modify] https://crrev.com/f4874b0c8a18d43be5c3462e8aa0463abe77214f/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.h

Project Member

Comment 42 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7826cf96937d8bdb66cc17f5d40987bc25effbb3

commit 7826cf96937d8bdb66cc17f5d40987bc25effbb3
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Mar 22 18:55:54 2018

dom_storage: Pass approprite task runners to AssociatedBinding::Bind via LocalStorageCachedArea

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Idcb3266ee3077817254290fb827fadb2a9d820a7
Reviewed-on: https://chromium-review.googlesource.com/975322
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545177}
[modify] https://crrev.com/7826cf96937d8bdb66cc17f5d40987bc25effbb3/content/renderer/dom_storage/local_storage_cached_area.cc

Project Member

Comment 43 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8255fec60ed374e15f7ef5b990bb7fd32bdd53b

commit a8255fec60ed374e15f7ef5b990bb7fd32bdd53b
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Mon Mar 26 19:43:21 2018

[Blobs] Make task runner used by BlobBytesProvider more explicit.

Rather than just documenting that the class should be bound to a mojo
pipe on a different thread than the main/worker threads, explicitly make
the API such that it creates its own task runner to bind on.

That same task runner is then also passed on to BlobBytesStreamer, to
replace its usage of SequencedTaskRunnerHandle::Get().

Bug: 786332
Change-Id: Ic2e38a53514bc612ffaf579c3eb1bc4a88b29efe
Reviewed-on: https://chromium-review.googlesource.com/976098
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545863}
[modify] https://crrev.com/a8255fec60ed374e15f7ef5b990bb7fd32bdd53b/third_party/WebKit/Source/platform/blob/BlobBytesProvider.cpp
[modify] https://crrev.com/a8255fec60ed374e15f7ef5b990bb7fd32bdd53b/third_party/WebKit/Source/platform/blob/BlobBytesProvider.h
[modify] https://crrev.com/a8255fec60ed374e15f7ef5b990bb7fd32bdd53b/third_party/WebKit/Source/platform/blob/BlobBytesProviderTest.cpp
[modify] https://crrev.com/a8255fec60ed374e15f7ef5b990bb7fd32bdd53b/third_party/WebKit/Source/platform/blob/BlobData.cpp

Project Member

Comment 44 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f21f20c404f8a627f09a327eeb5336d991cceb2b

commit f21f20c404f8a627f09a327eeb5336d991cceb2b
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Mar 27 04:07:03 2018

Pass approprite task runners to AssociatedBinding::Bind via RenderThreadImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Ibabee0c19403e3a2b1273f9b98eb6ca7f1d114a3
Reviewed-on: https://chromium-review.googlesource.com/980095
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546006}
[modify] https://crrev.com/f21f20c404f8a627f09a327eeb5336d991cceb2b/content/renderer/render_thread_impl.cc

Project Member

Comment 45 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70ff9cf73b5d3fc677b17efb2733f1d2292a4c3a

commit 70ff9cf73b5d3fc677b17efb2733f1d2292a4c3a
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Mar 28 07:39:06 2018

Pass approprite task runners to Binding::Bind via RenderFrameImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I79f39e3ace6a584bd9ec56438519e041438da974
Reviewed-on: https://chromium-review.googlesource.com/981844
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546431}
[modify] https://crrev.com/70ff9cf73b5d3fc677b17efb2733f1d2292a4c3a/content/renderer/render_frame_impl.cc

Project Member

Comment 46 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3cef2a9d2ba64068c1fe7de81500d9d33cf4f87

commit a3cef2a9d2ba64068c1fe7de81500d9d33cf4f87
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Mar 28 10:54:29 2018

Pass approprite task runners to AssociatedBinding::Bind via LayoutTestRenderFrameObserver

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Ic841585f71bb9a8ae71a185d2bf484b37b78eff7
Reviewed-on: https://chromium-review.googlesource.com/980096
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546452}
[modify] https://crrev.com/a3cef2a9d2ba64068c1fe7de81500d9d33cf4f87/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

Project Member

Comment 47 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a923f285819a3c22acec7750382acf5be69e3e2

commit 9a923f285819a3c22acec7750382acf5be69e3e2
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Mar 28 11:43:58 2018

Pass approprite task runners to Binding::Bind and InterfacePtr::Bind via URLLoaderClientImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I547ccc433afacfaf4d3f26c829cc12fcbe987961
Reviewed-on: https://chromium-review.googlesource.com/983274
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546457}
[modify] https://crrev.com/9a923f285819a3c22acec7750382acf5be69e3e2/content/renderer/loader/url_loader_client_impl.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/150b65c720320905158872b84b9643fb1e96ec86

commit 150b65c720320905158872b84b9643fb1e96ec86
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Mar 28 12:32:32 2018

Pass approprite task runners to InterfacePtr::Bind via RenderFrameImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I786735daa967f8a8d3ad007812fcba577951e43e
Reviewed-on: https://chromium-review.googlesource.com/983196
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546462}
[modify] https://crrev.com/150b65c720320905158872b84b9643fb1e96ec86/content/renderer/render_frame_impl.cc

Blockedon: 827065
Project Member

Comment 50 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd7848013890d90437d528380803fff10360695d

commit bd7848013890d90437d528380803fff10360695d
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Mar 29 09:32:27 2018

Pass approprite task runners to AssociatedBinding::Bind via AssociateInterfaceProviderImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Id56592620375d8a62825511a93a825e135c28f60
Reviewed-on: https://chromium-review.googlesource.com/980015
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546778}
[modify] https://crrev.com/bd7848013890d90437d528380803fff10360695d/content/common/associated_interface_provider_impl.cc
[modify] https://crrev.com/bd7848013890d90437d528380803fff10360695d/content/common/associated_interface_provider_impl.h
[modify] https://crrev.com/bd7848013890d90437d528380803fff10360695d/content/renderer/render_frame_impl.cc

Cc: skyos...@chromium.org
 Issue 676805  has been merged into this issue.
Project Member

Comment 52 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7a432a0ac34392014d42bf5beb289b63b5e5abf

commit e7a432a0ac34392014d42bf5beb289b63b5e5abf
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Mar 29 13:54:57 2018

Pass approprite task runners to AssociatedBinding::Bind via ChildThreadImpl

This CL passes |ipc_task_runner_| to AssociatedBinding::Bind() when
possible. If the IPC task runner is not present, pass base::TTRH::Get()
instead and this doesn't change the current behavior.

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332

Change-Id: I03d76c0e8007e4d32bc2e72b185e0644bdfd3c16
Reviewed-on: https://chromium-review.googlesource.com/979893
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546810}
[modify] https://crrev.com/e7a432a0ac34392014d42bf5beb289b63b5e5abf/content/child/child_thread_impl.cc

Project Member

Comment 53 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d17cb16e75fc22dad960c86e5ab6ddb16ef5411a

commit d17cb16e75fc22dad960c86e5ab6ddb16ef5411a
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Apr 04 07:22:52 2018

indexed_db: Pass appropriate task runners to AssociatedInterfacePtr::Bind via IndexedDB classes

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I2ab4e22c26cf710fbc22adeb951c1eb12440f354
Reviewed-on: https://chromium-review.googlesource.com/975281
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547997}
[modify] https://crrev.com/d17cb16e75fc22dad960c86e5ab6ddb16ef5411a/content/renderer/indexed_db/webidbcursor_impl.cc
[modify] https://crrev.com/d17cb16e75fc22dad960c86e5ab6ddb16ef5411a/content/renderer/indexed_db/webidbdatabase_impl.cc

Project Member

Comment 54 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/badc7fbe1438bb7a072ce184ad3d015e6181c4ac

commit badc7fbe1438bb7a072ce184ad3d015e6181c4ac
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Apr 12 07:21:14 2018

Pass approprite task runners to InterfacePtr::Bind via GpuVideoAcceleratorFactoriesImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Idf6f5dd37a0c6d510a17a6f4c5546a86d9c07333
Reviewed-on: https://chromium-review.googlesource.com/983155
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550069}
[modify] https://crrev.com/badc7fbe1438bb7a072ce184ad3d015e6181c4ac/content/renderer/media/gpu/gpu_video_accelerator_factories_impl.cc

Project Member

Comment 55 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e78228ac407f1a2fe4581101a3cfe7ed2eb21193

commit e78228ac407f1a2fe4581101a3cfe7ed2eb21193
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Sep 03 04:52:23 2018

Use a per-frame task runner at InputTargetClinentImpl

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Ie0737135f42d7abba55080c007687a19d8c08897
Reviewed-on: https://chromium-review.googlesource.com/1198654
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588328}
[modify] https://crrev.com/e78228ac407f1a2fe4581101a3cfe7ed2eb21193/content/renderer/input/input_target_client_impl.cc

Project Member

Comment 56 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc45865362236e229cfc9e16f066fd46475aafde

commit dc45865362236e229cfc9e16f066fd46475aafde
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Oct 23 04:45:50 2018

Pass approprite task runners to AssociatedBinding::Bind via FindInPage

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Ib271cb86d37c55cc1ad50e24003c8df675976d08
Reviewed-on: https://chromium-review.googlesource.com/c/1293429
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601849}
[modify] https://crrev.com/dc45865362236e229cfc9e16f066fd46475aafde/third_party/blink/renderer/core/frame/find_in_page.cc

Project Member

Comment 57 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39d3c64909da493d665a474e57a03b0d1d9fbbea

commit 39d3c64909da493d665a474e57a03b0d1d9fbbea
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Oct 23 04:45:53 2018

Pass approprite task runners to AssociatedBinding::Bind via ServiceWorker

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I7df2d7a4d0154d8b563c4d0e350a78c97067093b
Reviewed-on: https://chromium-review.googlesource.com/c/1293107
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601850}
[modify] https://crrev.com/39d3c64909da493d665a474e57a03b0d1d9fbbea/third_party/blink/renderer/modules/service_worker/service_worker.cc
[modify] https://crrev.com/39d3c64909da493d665a474e57a03b0d1d9fbbea/third_party/blink/renderer/modules/service_worker/service_worker_registration.cc

Project Member

Comment 58 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0f902cf9900d79032968fe1e08d9b868cd1d615

commit a0f902cf9900d79032968fe1e08d9b868cd1d615
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Oct 23 07:52:17 2018

Pass approprite task runners to AssociatedBinding::Bind via DevToolsAgent

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: I91647355e2e9d955fcf62020fca175182f35e467
Reviewed-on: https://chromium-review.googlesource.com/c/1293258
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601875}
[modify] https://crrev.com/a0f902cf9900d79032968fe1e08d9b868cd1d615/third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc
[modify] https://crrev.com/a0f902cf9900d79032968fe1e08d9b868cd1d615/third_party/blink/renderer/core/inspector/devtools_agent.cc
[modify] https://crrev.com/a0f902cf9900d79032968fe1e08d9b868cd1d615/third_party/blink/renderer/core/inspector/devtools_agent.h

Project Member

Comment 59 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a439bb43b655cac47d6ff53968f096fc0cbe54ee

commit a439bb43b655cac47d6ff53968f096fc0cbe54ee
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Oct 31 08:55:19 2018

Make sure WebLocalFrameImpl::frame_ exists when creating its binding

This CL makes binding initialization a little delayed so that |frame_|
always exists when the local frame's binding is created.

After this CL, more tasks via WebLocalFrameImpl are executed on a per-
frame task runner.

Bug: 786332
Change-Id: I2f632814acefa7cf1bb2411563405306c469b6fc
Reviewed-on: https://chromium-review.googlesource.com/c/1298532
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604188}
[modify] https://crrev.com/a439bb43b655cac47d6ff53968f096fc0cbe54ee/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/a439bb43b655cac47d6ff53968f096fc0cbe54ee/content/renderer/render_view_impl.cc

Sign in to add a comment