New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786327 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug


Previous locations:
v8:7076


Sign in to add a comment

text-overflow: ellipsis bug when a sibling inline element is moved

Reported by everdime...@gmail.com, Nov 13 2017

Issue description

Version: 62.0.3202.89
OS: macos 10.12.6 (16G1036)

What steps will reproduce the problem?
Go to: https://codepen.io/everdimension/pen/EbXVRK?editors=1100

What is the expected output?
The text should be ellipsised.


What do you see instead?
The text is not ellipsised.

Here's a gif showing the problem: https://i.imgur.com/Eq6Bsho.gifv
(sorry for the gifv format, I kinda messed up when saving the original gif)

My guess is that the problem has something to do with the fact that the moved element gets over the bounds of the content box of the `.wrapper` element.

Also as you can see in the gif if I apply font-size other than `1em` then the ellipsis starts working. Even if I remove font-size later.


 
Project: chromium
Moved issue v8:7076 to now be  issue chromium:786327 .
Components: Blink
not v8
Components: -Blink Blink>Layout

Comment 4 by robho...@gmail.com, Nov 20 2017

Owner: robho...@gmail.com
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/502eb9349ab09a3918cf3e51426a1dc73f39eba1

commit 502eb9349ab09a3918cf3e51426a1dc73f39eba1
Author: Robert Hogan <robhogan@gmail.com>
Date: Tue Nov 21 03:29:00 2017

Calculate the layout overflow of replaced inlines correctly

It should be a union of the replaced inline and the flow box's rect.

This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/563625
and https://chromium-review.googlesource.com/c/chromium/src/+/659077
which removed the default union of child overflow rects with the framebox
in InlineFlowBox::ComputeOverflow. It was removed
so that overflow_ could be used to fully reflect the shifted rect due to relative
positioning. We do this by uniting the overflow rects created by inline children
with the framebox and shift the union according to the relative position.

If we encounter a replaced inline child we need to ensure its overflow rect is
united with the framebox, just like when we encounter a normal inline. Unlike
normal inlines we don't have to worry about its relative offset affecting the
dimensions of the framebox.

Bug:  786327 
Change-Id: I9c877f44e8f3572ab2852479d3d39433b1af9063
Reviewed-on: https://chromium-review.googlesource.com/779999
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518083}
[add] https://crrev.com/502eb9349ab09a3918cf3e51426a1dc73f39eba1/third_party/WebKit/LayoutTests/fast/text/ellipsis-in-relative-inline-3-expected.html
[add] https://crrev.com/502eb9349ab09a3918cf3e51426a1dc73f39eba1/third_party/WebKit/LayoutTests/fast/text/ellipsis-in-relative-inline-3.html
[modify] https://crrev.com/502eb9349ab09a3918cf3e51426a1dc73f39eba1/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp

Comment 6 by robho...@gmail.com, Nov 23 2017

Cc: sc00335...@techmahindra.com robho...@gmail.com
 Issue 787611  has been merged into this issue.

Comment 7 by robho...@gmail.com, Dec 2 2017

Status: Fixed (was: Assigned)

Sign in to add a comment