Issue metadata
Sign in to add a comment
|
Regression : ‘Close’ (x) icon is seen in black color in incognito tab.
Reported by
avsha...@etouch.net,
Nov 17 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version : 64.0.3271.0 (Official Build) 71f07f2c6c77c9e67158a193516e2f0c6229ce64-refs/heads/master@{#517250} 64-bit OS : Mac(10.12.6), (10.13.2) What steps will reproduce the problem? 1. Launch chrome and press ‘Cmd + Shift + N’ to open incognito window. 2. Observe the ‘Close’ (x) icon on a tab. Actual Result : ‘Close’ (x) icon is seen in black color in incognito tab. Expected Result : ‘Close’ (x) icon for incognito tab should have white color. This is a regression issue broken in ‘M-64’ and using the per-revision bisect providing the bisect results, Good build : 64.0.3270.0 (Revision : 516943) Bad build : 64.0.3271.0 (Revision : 517250) You are probably looking for a change made after 517126 (known good), but no later than 517127 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/5efc3d9ec2759c5efdea7e97369f0f7d881e63f4..1d5b995e2b8ecd02d25ce3617dede75c26cf10e4 Suspect : https://chromium.googlesource.com/chromium/src/+/1d5b995e2b8ecd02d25ce3617dede75c26cf10e4 @shrike : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note : Issue is not observed on Windows(7,8,10) & Linux(14.04 LTS) OS.
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/082bcd2a68fa714c5eba28aeed23ef17e0856208 commit 082bcd2a68fa714c5eba28aeed23ef17e0856208 Author: Jayson Adams <shrike@chromium.org> Date: Mon Nov 20 16:32:44 2017 [Mac] Fix regression with incognito tab close button. https://chromium-review.googlesource.com/769238 cleans up the TabView initialization code but the reordering causes the TabView to never receive a pointer to its closeButton. This cl ensures closeButton creation occurs before TabView creation. Bug: 786326 , 786387 Change-Id: Id1fce1b8dcd1014ae015b7806df3541981d08253 Reviewed-on: https://chromium-review.googlesource.com/777394 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Jayson Adams <shrike@chromium.org> Cr-Commit-Position: refs/heads/master@{#517843} [modify] https://crrev.com/082bcd2a68fa714c5eba28aeed23ef17e0856208/chrome/browser/ui/cocoa/tabs/tab_controller.mm [modify] https://crrev.com/082bcd2a68fa714c5eba28aeed23ef17e0856208/chrome/browser/ui/cocoa/tabs/tab_view.mm
,
Nov 21 2017
Update : Retested above issue on Mac(10.12.6) & (10.13.2) OS using latest Canary #64.0.3274.0 and issue is fixed now. Kindly review an attached screen cast. Thank you!
,
Nov 27 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Nov 17 2017