New issue
Advanced search Search tips

Issue 786314 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

3.9%-281.6% regression in system_health.memory_desktop at 506289:506509

Project Member Reported by marja@chromium.org, Nov 17 2017

Issue description

peak mem regresses
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 17 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=786314

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=210a39804aff31e3f8652dbe777b2a1518fcbfa8bc57c226030e7e780c6be8ec


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
linux-release
win-high-dpi

Comment 3 by marja@chromium.org, Nov 17 2017

Labels: Merge-Request-63
The commit that fixes this: 

commit a0d1e58fdd1e13284e0352d9f54a2c8da5e55bca
Author: Marja Hölttä <marja@chromium.org>
Date:   Thu Nov 2 10:07:42 2017 +0100

    [parser] Skipping inner funcs: use ZoneChunkList instead of ZoneDeque.
    
    ZoneDeque is memory-inefficient, see
    https://bugs.chromium.org/p/chromium/issues/detail?id=674287
    
    As a downside, ZoneChunkList is not const correct, see
    
    https: //bugs.chromium.org/p/v8/issues/detail?id=6473 .
    Bug:  v8:5516 
    Change-Id: I2db15006afd78aa932ab831cd9c0cff659229321
    Reviewed-on: https://chromium-review.googlesource.com/750782
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49182}

Project Member

Comment 4 by sheriffbot@chromium.org, Nov 17 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 -Merge-Review-63 Merge-Approved-63 Pri-1
Please set to fixed if the regressions are fixed by the commit.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2017

Labels: merge-merged-6.3
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3bf3ba0e84ae2451650203877e33c7001d470cb9

commit 3bf3ba0e84ae2451650203877e33c7001d470cb9
Author: Marja Hölttä <marja@chromium.org>
Date: Fri Nov 17 10:27:49 2017

Merged: [parser] Skipping inner funcs: use ZoneChunkList instead of ZoneDeque.

Revision: a0d1e58fdd1e13284e0352d9f54a2c8da5e55bca

BUG= v8:5516 , chromium:786314 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org

Change-Id: Ib180f0c8dff6c89603f352ed08a1b3f37898cd0b
Reviewed-on: https://chromium-review.googlesource.com/776674
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.3@{#73}
Cr-Branched-From: 094a7c93dcdcd921de3883ba4674b7e1a0feffbe-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb528a8021e04a029e06eafee50b918bce0-refs/heads/master@{#48432}
[modify] https://crrev.com/3bf3ba0e84ae2451650203877e33c7001d470cb9/src/parsing/preparsed-scope-data.cc
[modify] https://crrev.com/3bf3ba0e84ae2451650203877e33c7001d470cb9/src/parsing/preparsed-scope-data.h

Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Nov 17 2017

Cc: hablich@chromium.org
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/15af2c8df80000

[parser] Skipping inner funcs: Turn flag back on.
By marja@chromium.org · Wed Oct 04 08:23:11 2017
v8 @ fa3b73fffe232b601d2a94f129446f41c765a86e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 8 by marja@chromium.org, Nov 20 2017

Status: Fixed (was: Assigned)
The graph recovers w/ the above mentioned commit, which I also merged to M63 now.
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 20 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by marja@chromium.org, Nov 22 2017

Labels: -Merge-Approved-63

Sign in to add a comment