Password manager does not move displayed passwords up after deleting an entry
Reported by
mr.ber...@gmail.com,
Nov 17 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36 Steps to reproduce the problem: 1. Have a bunch of passwords saved 2. Make some of them visible 3. Delete the top-most entry that has a password visible What is the expected behavior? All entries move up one spot What went wrong? Columns "Website" and "Username" do move up, but the visible passwords do not move up, so in the display, the columns are out of sync. Did this work before? N/A Chrome version: 62.0.3202.94 Channel: stable OS Version: 10.0 Flash Version:
,
Nov 17 2017
,
Nov 20 2017
,
Nov 20 2017
,
Nov 24 2017
,
Nov 24 2017
Issue 788280 has been merged into this issue.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/447990991a286e8085d04c41ef6c016dbdf25e0f commit 447990991a286e8085d04c41ef6c016dbdf25e0f Author: jdoerrie <jdoerrie@chromium.org> Date: Wed Nov 29 19:37:02 2017 Fix Behavior of Visible Passwords Prior to this change visible passwords were bound to a specific row in the list of passwords. This led to bugs when the list changed, e.g. when adding or deleting a password, or changing the list of passwords with a search filter. This change fixes this by grouping the password and the UiEntry into a newly introduced typedef. Bug: 786312 , 771126 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I25751d6a20b315290f2c52cc76946f85c413405f Reviewed-on: https://chromium-review.googlesource.com/779179 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#520200} [modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html [modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html [modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.js [modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js [modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/browser/resources/settings/passwords_and_forms_page/show_password_behavior.js [modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js [modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js [modify] https://crrev.com/447990991a286e8085d04c41ef6c016dbdf25e0f/third_party/closure_compiler/externs/passwords_private.js
,
Dec 4 2017
,
Dec 18 2017
Issue 795600 has been merged into this issue.
,
Dec 18 2017
Issue 795659 has been merged into this issue.
,
Dec 20 2017
Issue 782599 has been merged into this issue.
,
Jan 8 2018
Issue 799670 has been merged into this issue.
,
Jan 10 2018
Issue 800272 has been merged into this issue.
,
Jan 10 2018
Issue 799389 has been merged into this issue.
,
Jan 16 2018
Issue 801297 has been merged into this issue.
,
Jan 17 2018
,
Feb 20 2018
Issue 805360 has been merged into this issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mr.ber...@gmail.com
, Nov 17 2017