Issue metadata
Sign in to add a comment
|
Regression: Allow/Block permission bubble anchors on the wrong side in RTL
Reported by
db...@etouch.net,
Nov 17 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: Chrome Version : 64.0.3271.0 71f07f2c6c77c9e67158a193516e2f0c6229ce64-refs/heads/master@{#517250}(32/64-bit) OS: Windows(7,8,10), Mac(10.12.6), (10.13.2)), Linux(14.1 LTS) Pre-condition: Enable Force UI direction flag (Right-to-left) from chrome://flags. What steps will reproduce the problem? (1) Launch chrome, navigate to https://permission.site/ (2) Click on Location and observe Allow/Block permission bubble. Actual: Allow/Block permission bubble is seen misplaced. Expected: Allow/Block permission bubble should seen properly. This is a regression issue, broken in 'M64', below is bisect info: Good Build:64.0.3256.0 bad Build: 64.0.3257.0 You are probably looking for a change made after 513360 (known good), but no later than 513361 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/a28eb737c4c9424d7656ada19b688af854777968..1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc Suspect : https://chromium.googlesource.com/chromium/src/+/1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc
,
Nov 17 2017
bumping milestone since we're not launching that flag in m64
,
Nov 17 2017
cc ellyjones@, relevant to bug 700196
,
Nov 17 2017
Oops failed to actually update the cc
,
Nov 20 2017
This doesn't repro for me on trunk (e5c30e0bbf8dc7884cb4430e39444d62c19ad8fe), fyi. tapted@ is probably still the right assignee since he knows the bubble-anchoring code.
,
Nov 21 2017
I can repro on Windows 10. Both force-ui-direction and changing my language to Hebrew cause this. version 64.0.3273.3 (גירסה רשמית) canary (32 סיביות) (cohort: Clang-32) On Mac, the left side is actually correct until chrome://flags/#mac-rtl is default.
,
Dec 5 2017
Load balancing
,
Dec 7 2017
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f21f67ee5c5c30020859cc7f9a2eb15652ddc86 commit 7f21f67ee5c5c30020859cc7f9a2eb15652ddc86 Author: Allen Bauer <kylixrd@chromium.org> Date: Thu Dec 07 20:18:41 2017 Disable the code to swap the arrow position until anchor_view_ or anchor_rect_ are set. GetUpdatedWindowBounds is called lots of times before anchor_view_ or anchor_rect_ are set, thus leading to the arrow being swapped prematurely. Bug: 786311 Change-Id: I4c18bade31e179a645083f6a7c232982413967f2 Reviewed-on: https://chromium-review.googlesource.com/814897 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#522526} [modify] https://crrev.com/7f21f67ee5c5c30020859cc7f9a2eb15652ddc86/ui/views/bubble/bubble_dialog_delegate.cc
,
Dec 7 2017
,
Dec 8 2017
Just to update: Above issue is fixed on OS: Windows(7,8,10), Mac(10.12.6), (10.13.2)),Linux(14.1 LTS) using canary build #65.0.3288.0 Thank you. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Nov 17 2017