Regression: Misalignment of content is seen after changing flag to RTL
Reported by
nutan.ga...@etouch.net,
Nov 17 2017
|
|||||||||
Issue descriptionVersion: 64.0.3271.0 71f07f2c6c77c9e67158a193516e2f0c6229ce64-refs/heads/master@{#517250} 32/64 bits OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) Steps to reproduce? 1. Launch chrome, navigate to chrome://flags and change 'Force UI direction' to 'Right-to-Left' 2. Relaunch chrome, navigate to 'Unavailable' tab and observe the alignment of content Actual: Misalignment of content is seen after changing flag to RTL Expected: Alignment should be proper This is Regression issue seen from M-64 and will soon update bisect info: Good Build - 64.0.3254.0 Bad Build - 64.0.3255.0
,
Nov 17 2017
Adding release blocker for this issue.Please undo if not the case. Thank You!
,
Nov 17 2017
That CL doesn't affect webcontent - can you retry the bisect?
,
Nov 21 2017
With respect to comment 3: Re bisected for the above issue and getting below CL: You are probably looking for a change made after 512799 (known good), but no later than 512800 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/d53727e2c524a1c67bb666a19aa9b35f8e16f871..bf18e6e1fdcad9abe6395c8ed47bb16e90063b25 Suspect: https://chromium.googlesource.com/chromium/src/+/bf18e6e1fdcad9abe6395c8ed47bb16e90063b25
,
Nov 21 2017
Thanks for catching this. I'll look at a fix shortly.
,
Nov 29 2017
Still we are able to reproduce the issue on Windows 7 , Mac 10.12.6 & Ubuntu 14.04 using latest Canary-64.0.3279.0 as per C#0. edwardjung@,As it is marked as stable blocker,could you please take a look and update the thread accordingly. Thank you..!
,
Nov 29 2017
CL 788916 was just submitted. Should land shortly to fix this issue.
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4aa17b6fd8bd45e76480c64883bb09afa239b439 commit 4aa17b6fd8bd45e76480c64883bb09afa239b439 Author: Edward Jung <edwardjung@chromium.org> Date: Thu Nov 30 01:57:04 2017 chrome://flags layout fixes + Fix misaligning of content when displayed RTL. + Fix overlapping header and version number on smaller / zoomed screens. Bug: 788299 , 786307 Change-Id: If722cc1a9188ca7837049c29b3f67e3b9bf27c69 Reviewed-on: https://chromium-review.googlesource.com/788916 Commit-Queue: Edward Jung <edwardjung@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#520386} [modify] https://crrev.com/4aa17b6fd8bd45e76480c64883bb09afa239b439/components/flags_ui/resources/flags.css
,
Nov 30 2017
Thanks Nutan
,
Nov 30 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 30 2017
Shouldn't need a merge. The CL has landed in 64. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by nutan.ga...@etouch.net
, Nov 17 2017Owner: tapted@chromium.org
Status: Assigned (was: Unconfirmed)