Unresolved dependencies on beta branch |
||||||
Issue description
iOS beta branch bot fails setup-gn step:
ERROR Unresolved dependencies.
//ios/chrome/browser/ui/content_suggestions:eg_tests(//build/toolchain/mac:ios_clang_x64)
needs //ios/chrome/browser/ui/ntp:modal_ntp(//build/toolchain/mac:ios_clang_x64)
//ios/chrome/browser/ui/ntp:eg_tests(//build/toolchain/mac:ios_clang_x64)
needs //ios/chrome/browser/ui/ntp:modal_ntp(//build/toolchain/mac:ios_clang_x64)
Traceback (most recent call last):
File "/b/build/slave/beta-device/build/src/ios/build/tools/setup-gn.py", line 356, in <module>
sys.exit(Main(sys.argv[1:]))
File "/b/build/slave/beta-device/build/src/ios/build/tools/setup-gn.py", line 351, in Main
GenerateXcodeProject(gn_path, args.root, out_dir, settings)
File "/b/build/slave/beta-device/build/src/ios/build/tools/setup-gn.py", line 274, in GenerateXcodeProject
generator.Generate(gn_path, root_dir, temp_path)
File "/b/build/slave/beta-device/build/src/ios/build/tools/setup-gn.py", line 135, in Generate
self.GetGnCommand(gn_path, root_path, out_path, True))
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/b/depot_tools/gn', '--root=/b/build/slave/beta-device/build/src', '-q', '--ide=xcode', '--root-target=gn_all', '--filters=//base:base_unittests;//components:components_unittests;//crypto:crypto_unittests;//google_apis:google_apis_unittests;//ios/*;//ios_internal/*;//net:net_unittests;//services:services_unittests;//skia:skia_unittests;//sql:sql_unittests;//ui/base:ui_base_unittests;//ui/gfx:gfx_unittests;//url:url_unittests', 'gen', '//out/_temptFXf_O']' returned non-zero exit status 1
step returned non-zero exit code: 1
Seems like the ntp targets are incorrect somehow. Please take a look
,
Nov 17 2017
,
Nov 17 2017
Sorry for the break. gambard@, sdefresne@ after the revert, some egtests may break on 3239 build. However, I was wondering if there are waterfall or something keep running egtests for 3239? Do you think I need to reland the egtest fix CL?
,
Nov 17 2017
We are running the tests in an internal waterfall, so yes, please reland this CL once it is fixed.
,
Nov 17 2017
Issue 786342 has been merged into this issue.
,
Nov 17 2017
Fixed in the relanded CL crrev.com/776275 I verified by a successful compilation of 3239 on my local machine. sorry for the break again.
,
Nov 17 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 17 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by gambard@chromium.org
, Nov 17 2017