New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 786297 link

Starred by 2 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
mac-bugs-priority@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:After dragging tab out/back from original window flickering of fav icon is seen.

Reported by vku...@etouch.net, Nov 17 2017 
Chrome Version:64.0.3271.0 (Official Build) Revision 71f07f2c6c77c9e67158a193516e2f0c6229ce64-refs/heads/master@{#517250} (64-bit)
OS:Mac(10.12.6, 10.13.2)

What steps will reproduce the problem?
(1)Launch chrome and open chrome://settings or 2-3 webpages
(2)Now drag tab out from original window and again drag back, observe the favicon while dragging 

Actual: After dragging tab out/back from original window flickering of fav icon is seen.

Expected: No such flickering of fav icon should be seen after dragging tab out/back from original window.

This is a regression issue broken in 'M64' and below is the manual bisect info
Good Build: 64.0.3270.0
Bad Build:  64.0.3271.0
Actual_Favicon.mov
1.5 MB Download

Comment 1 by vku...@etouch.net, Nov 17 2017

Labels: hasbisect-per-revision
Owner: shrike@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 517126 (known good), but no later than 517127 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/5efc3d9ec2759c5efdea7e97369f0f7d881e63f4..1d5b995e2b8ecd02d25ce3617dede75c26cf10e4

Suspecting: https://chromium.googlesource.com/chromium/src/+/1d5b995e2b8ecd02d25ce3617dede75c26cf10e4
Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note:Issue not seen on Win & Linux OS
Expected_favicon.mov
1.5 MB Download

Comment 2 by shrike@chromium.org, Nov 17 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20b95dde5fa3fcac1f7753ce5f5bf33688f05729

commit 20b95dde5fa3fcac1f7753ce5f5bf33688f05729
Author: Jayson Adams <shrike@chromium.org>
Date: Fri Nov 17 21:58:37 2017

[Mac] Fix regression with favicon animating into view when it should not.

https://chromium-review.googlesource.com/769238 adds a method that
updates the favicon location and by default animates the change, but
this causes the favicon to move when you release a tab after dragging
it to a window. This cl adds a parameter specifying whether or not the
favicon position change should animate.

Bug:  786297 
Change-Id: If5453ac27c9d0c6943389e22df66efa1a8fcd6b1
Reviewed-on: https://chromium-review.googlesource.com/777463
Commit-Queue: Jayson Adams <shrike@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517576}
[modify] https://crrev.com/20b95dde5fa3fcac1f7753ce5f5bf33688f05729/chrome/browser/ui/cocoa/tabs/tab_controller.mm

Comment 4 by shrike@chromium.org, Nov 17 2017

Status: Fixed (was: Started)

Comment 5 by vku...@etouch.net, Nov 20 2017

Labels: TE-Verified-64.0.3273.0 TE-Verified-M64
Rechecked above issue on latest canary version 64.0.3273.0 (Official Build) on Mac (10.12.6, 10.13.2) and the issue is fixed. 

Please refer attached screencast
Current_behaviour.mov
3.5 MB Download
►

Sign in to add a comment