Surface Pro orientation event quaternions inconsistent with Android |
|||||||
Issue descriptionChrome Version: 64.0.3269.3 canary OS: Win10 surface pro, Android N Pixel Phone What steps will reproduce the problem? (1) turn on the Generic Sensor, Generic Sensor Extra Classes, and Experimental Web Platform features flags on both devices (2) Go to http://genericsensors.appspot.com (3) add an Absolute orientation sensor (4) rotate the devices around What is the expected result? When the devices are in the same orientation, the quaternion values should be the same What happens instead? The x, y, and z (but not w) components are negated.
,
Nov 17 2017
For http://googlesamples.github.io/web-fundamentals/fundamentals/native-hardware/device-orientation/dev-orientation.html, I found that it behaves similarly on Android, so I don't think it's a good sample of broken functionality.
,
Nov 30 2017
bug here maybe? https://cs.chromium.org/chromium/src/services/device/generic_sensor/platform_sensor_reader_win.cc?rcl=739c460d5c5acde91a235c37d69a8e1013c3bb98&l=210 Its at least interesting that we negate x/y/z there and not w.
,
Nov 30 2017
I don't know enough about quaternions to know which device is producing the wrong value. CCing alexander.shalamov@intel.com who wrote the original Windows code.
,
Nov 30 2017
I will take a look.
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf13abba80471edc4ad83ea3455684f691df3a3f commit cf13abba80471edc4ad83ea3455684f691df3a3f Author: Alexander Shalamov <alexander.shalamov@intel.com> Date: Thu Dec 07 08:23:30 2017 [sensors][win] Reverse axis signs for motion sensors This CL reverses axis signs for gyroscope, magnetometer and absolute orientation sensors. Before the change, wrong coordinate system was used based on the accelerometer's data. Integrating Motion and Orientation Sensors [1] document, explains what coordinate system must be used and why accelerometer's measurements differ from other platforms. [1] https://msdn.microsoft.com/en-us/library/windows/hardware/dn642102(v=vs.85).aspx Bug: 786252 Change-Id: I4afbc1a1d5fb03c3e2e0538a8ea7424c40020eca Reviewed-on: https://chromium-review.googlesource.com/804624 Reviewed-by: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Cr-Commit-Position: refs/heads/master@{#522380} [modify] https://crrev.com/cf13abba80471edc4ad83ea3455684f691df3a3f/services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc [modify] https://crrev.com/cf13abba80471edc4ad83ea3455684f691df3a3f/services/device/generic_sensor/platform_sensor_reader_win.cc
,
Dec 7 2017
,
Dec 8 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3285126bdc58be5b45fadc70aeb0ac784595cce commit e3285126bdc58be5b45fadc70aeb0ac784595cce Author: Alexander Shalamov <alexander.shalamov@intel.com> Date: Fri Dec 08 16:51:21 2017 [M-64][sensors][win] Reverse axis signs for motion sensors This CL reverses axis signs for gyroscope, magnetometer and absolute orientation sensors. Before the change, wrong coordinate system was used based on the accelerometer's data. Integrating Motion and Orientation Sensors [1] document, explains what coordinate system must be used and why accelerometer's measurements differ from other platforms. [1] https://msdn.microsoft.com/en-us/library/windows/hardware/dn642102(v=vs.85).aspx Bug: 786252 Change-Id: I4afbc1a1d5fb03c3e2e0538a8ea7424c40020eca Reviewed-on: https://chromium-review.googlesource.com/804624 Reviewed-by: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Cr-Original-Commit-Position: refs/heads/master@{#522380}(cherry picked from commit cf13abba80471edc4ad83ea3455684f691df3a3f) Reviewed-on: https://chromium-review.googlesource.com/817814 Cr-Commit-Position: refs/branch-heads/3282@{#97} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/e3285126bdc58be5b45fadc70aeb0ac784595cce/services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc [modify] https://crrev.com/e3285126bdc58be5b45fadc70aeb0ac784595cce/services/device/generic_sensor/platform_sensor_reader_win.cc
,
Dec 12 2017
@MTVTeam--Could someone from MTV team , please look into this as In-House team doesn't ahve the surface pro to verify the issue. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ddorwin@chromium.org
, Nov 17 2017Cc: bajones@chromium.org billorr@chromium.org
Labels: -OS-Android