New issue
Advanced search Search tips

Issue 786241 link

Starred by 1 user
Status: Fixed
Owner:
hinoka@chromium.org
Closed: Dec 2017
Cc:
hinoka@chromium.org
efoo@chromium.org
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Reduce Milo chromium main console load time to under 400ms

Project Member Reported by hinoka@chromium.org, Nov 17 2017 
This page:
https://ci.chromium.org/p/chromium/consoles/main

Takes about 800ms to load on the server side.  There are some improvements that can be made to reduce this down to under 400ms, including:

* Running RPCs (urlfetch, datastore, etc) concurrently, for RPCs that can be run concurrently.
* Memcaching console rows
* Fixing Memcaching of urlfetches (they don't seem to be memcached right now, according to logs)
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/06568d07f7b3caa126993e065e1332e5a7bc10af

commit 06568d07f7b3caa126993e065e1332e5a7bc10af
Author: Ryan Tseng <hinoka@google.com>
Date: Wed Nov 22 22:25:45 2017

[milo] Make console loading more parallel

This splits console loading into the following jobs:
* Console Summary (For the current console and headers)
* Header
** Header Oncall
** Header Status URL
* Console Rows

Also fixes the issue of urlfetches not getting memcached properly.

This reduces hot load time from ~800ms to ~400ms.

Misc changes:
* "Alt" text in header config now used for text-link hover.
* Console IDs are now defined as common.ConsoleID struct
* All builder summaries are fetched together in a single
  get multi and rearranged into their respective slots after.
Otherwise there are no behavior changes (Other than the bugfix)

Bug:  786241 
Change-Id: I6539e9170c26706c2b89261fd04749d444e2dff3
Reviewed-on: https://chromium-review.googlesource.com/775546
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/06568d07f7b3caa126993e065e1332e5a7bc10af/milo/buildsource/console.go
[modify] https://crrev.com/06568d07f7b3caa126993e065e1332e5a7bc10af/milo/common/config.go
[modify] https://crrev.com/06568d07f7b3caa126993e065e1332e5a7bc10af/milo/common/model/build_summary.go
[modify] https://crrev.com/06568d07f7b3caa126993e065e1332e5a7bc10af/milo/frontend/ui/build.go
[modify] https://crrev.com/06568d07f7b3caa126993e065e1332e5a7bc10af/milo/frontend/view_console.go

Comment 2 by hinoka@chromium.org, Dec 1 2017

Status: Fixed (was: Started)
This is faster now.  There are more improvements that can be made in the future also.

Comment 3 by efoo@chromium.org, Dec 5 2017

Labels: LUCI-M3-S12 LUCI-M3-Beta LUCI-KnownIssues-UI

Comment 4 by efoo@chromium.org, Jan 31 2018

Labels: LUCI-Beta

Comment 5 by efoo@chromium.org, Jan 31 2018

Labels: -LUCI-M3-Beta
►

Sign in to add a comment