New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786240 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Change matching of filename - db entry to use maps

Project Member Reported by romax@chromium.org, Nov 17 2017

Issue description

More context at: https://chromium-review.googlesource.com/c/chromium/src/+/770430/1/components/offline_pages/core/model/persistent_pages_consistency_check_task.cc#139

Currently we're using a M*N approach, and we can reduce the time cost by applying a map there.

Should be changing this for all consistency tasks:
TemporaryPages*
PersistentPages*
[Maybe]ClearLegacy*.
 

Comment 1 by romax@chromium.org, Dec 4 2017

Owner: romax@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3ce5d5452593ec5b6d1156d8e801cb813f92e1e

commit c3ce5d5452593ec5b6d1156d8e801cb813f92e1e
Author: Yafei Duan <romax@chromium.org>
Date: Mon Dec 04 23:56:12 2017

[Offline Pages] Minor improvement on consistency check.

Use set::find instead of std::find_if when looking for match of file
paths in order to make the process faster

Bug:  786240 
Change-Id: I84dfdb7eb910bc120671520c6aca9b52a4971c7a
Reviewed-on: https://chromium-review.googlesource.com/802520
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521534}
[modify] https://crrev.com/c3ce5d5452593ec5b6d1156d8e801cb813f92e1e/components/offline_pages/core/model/persistent_pages_consistency_check_task.cc
[modify] https://crrev.com/c3ce5d5452593ec5b6d1156d8e801cb813f92e1e/components/offline_pages/core/model/temporary_pages_consistency_check_task.cc

Comment 3 by romax@chromium.org, Dec 4 2017

Status: Fixed (was: Started)

Sign in to add a comment