New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786218 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 785961



Sign in to add a comment

CBORValues maps should accept integer (signed and unsigned) keys

Project Member Reported by kpaulhamus@chromium.org, Nov 17 2017

Issue description

The WebAuthN spec requires that the COSE_key encodings use their integer shorthands as map keys.
 
Blocking: 785961
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98a59e46948b2c71608926004fac8192b0ff2208

commit 98a59e46948b2c71608926004fac8192b0ff2208
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Thu Dec 14 23:04:09 2017

Allow CBOR maps to use integer keys

Currently, CBOR maps only permit keys to be UTF-8 strings. Add support
for unsigned integer keys. Support for negative integer type keys will
be integrated as CL 777807 is lands.

Bug:  786218 
Change-Id: Id28864a9c62d0b0d93e71a663b6e8b2b84b2de95
Reviewed-on: https://chromium-review.googlesource.com/781207
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524223}
[modify] https://crrev.com/98a59e46948b2c71608926004fac8192b0ff2208/content/browser/webauth/attestation_object.cc
[modify] https://crrev.com/98a59e46948b2c71608926004fac8192b0ff2208/content/browser/webauth/cbor/cbor_reader.cc
[modify] https://crrev.com/98a59e46948b2c71608926004fac8192b0ff2208/content/browser/webauth/cbor/cbor_reader.h
[modify] https://crrev.com/98a59e46948b2c71608926004fac8192b0ff2208/content/browser/webauth/cbor/cbor_reader_unittest.cc
[modify] https://crrev.com/98a59e46948b2c71608926004fac8192b0ff2208/content/browser/webauth/cbor/cbor_values.cc
[modify] https://crrev.com/98a59e46948b2c71608926004fac8192b0ff2208/content/browser/webauth/cbor/cbor_values.h
[modify] https://crrev.com/98a59e46948b2c71608926004fac8192b0ff2208/content/browser/webauth/cbor/cbor_values_unittest.cc
[modify] https://crrev.com/98a59e46948b2c71608926004fac8192b0ff2208/content/browser/webauth/cbor/cbor_writer.cc
[modify] https://crrev.com/98a59e46948b2c71608926004fac8192b0ff2208/content/browser/webauth/cbor/cbor_writer_unittest.cc
[modify] https://crrev.com/98a59e46948b2c71608926004fac8192b0ff2208/content/browser/webauth/ec_public_key.cc
[modify] https://crrev.com/98a59e46948b2c71608926004fac8192b0ff2208/content/browser/webauth/fido_attestation_statement.cc

Status: Fixed (was: Assigned)

Sign in to add a comment