New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786217 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 785961



Sign in to add a comment

CBORWriter should support negative integers (major type 1)

Project Member Reported by kpaulhamus@chromium.org, Nov 17 2017

Issue description

This is needed to use the COSE_Key format for WebAuthN public keys.
 
Blocking: 785961
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06ae32d640c8e4b86ea8914a80ee419ea16e56d8

commit 06ae32d640c8e4b86ea8914a80ee419ea16e56d8
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Thu Dec 21 21:33:39 2017

Support CBOR encoding and decoding of negative integers

Added support for major type 1 for CBORValue, CBORReader, and
CBORWriter, and reduced the accepted range of major type 0 to
what fits in an int64_t. While the CBOR major types 0 and 1
together can represent integers in the range [-2^64, 2^64-1], to
reduce the C++ interface complexity we now represent them both in
an int64_t, with the range [-2^63, 2^63-1].

Bug:  786217 
Change-Id: Ifee69efcddecea104532b99176d705b3d2801f41
Reviewed-on: https://chromium-review.googlesource.com/777807
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525809}
[modify] https://crrev.com/06ae32d640c8e4b86ea8914a80ee419ea16e56d8/content/browser/webauth/cbor/cbor_reader.cc
[modify] https://crrev.com/06ae32d640c8e4b86ea8914a80ee419ea16e56d8/content/browser/webauth/cbor/cbor_reader.h
[modify] https://crrev.com/06ae32d640c8e4b86ea8914a80ee419ea16e56d8/content/browser/webauth/cbor/cbor_reader_unittest.cc
[modify] https://crrev.com/06ae32d640c8e4b86ea8914a80ee419ea16e56d8/content/browser/webauth/cbor/cbor_values.cc
[modify] https://crrev.com/06ae32d640c8e4b86ea8914a80ee419ea16e56d8/content/browser/webauth/cbor/cbor_values.h
[modify] https://crrev.com/06ae32d640c8e4b86ea8914a80ee419ea16e56d8/content/browser/webauth/cbor/cbor_values_unittest.cc
[modify] https://crrev.com/06ae32d640c8e4b86ea8914a80ee419ea16e56d8/content/browser/webauth/cbor/cbor_writer.cc
[modify] https://crrev.com/06ae32d640c8e4b86ea8914a80ee419ea16e56d8/content/browser/webauth/cbor/cbor_writer.h
[modify] https://crrev.com/06ae32d640c8e4b86ea8914a80ee419ea16e56d8/content/browser/webauth/cbor/cbor_writer_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment