Combine Event.DownEventCount.* metrics |
||||
Issue description
Right now we have separate metrics for input, form factor, and destination.
We should instead combine these into one histogram with buckets for each combination of the above:
{mouse,touch,stylus}_{clamshell,touchviewlandscape,touchviewportrait}_{browser,arc,chromeapp,other}
So if the user touches a button in the browser in portrait-orientation touchview mode, it would increment the touch_touchviewportrait_browser bucket. There are 3x3x4=36 buckets.
,
Dec 5 2017
Also pushing to M65 since we're past branch...
,
Jan 4 2018
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08b963ad5e8a3b872cead3f6fedf91632d6b44c3 commit 08b963ad5e8a3b872cead3f6fedf91632d6b44c3 Author: Sarah Hu <xiaoyinh@chromium.org> Date: Thu Jan 11 17:40:22 2018 Combine Event.DownEventCount metrics Combine Event.DownEventCount.PerInput Event.DownEventCount.PerFormFactor Event.DownEventCount.PerDestination into Event.DownEventCount.PerInputFormFactorDestinationCombination Bug: 786214 Change-Id: I80cb10512bc9600836c334a5005ed7974b67ac9e Reviewed-on: https://chromium-review.googlesource.com/852855 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#528661} [modify] https://crrev.com/08b963ad5e8a3b872cead3f6fedf91632d6b44c3/ash/metrics/pointer_metrics_recorder.cc [modify] https://crrev.com/08b963ad5e8a3b872cead3f6fedf91632d6b44c3/ash/metrics/pointer_metrics_recorder.h [modify] https://crrev.com/08b963ad5e8a3b872cead3f6fedf91632d6b44c3/ash/metrics/pointer_metrics_recorder_unittest.cc [modify] https://crrev.com/08b963ad5e8a3b872cead3f6fedf91632d6b44c3/ash/public/cpp/app_types.h [modify] https://crrev.com/08b963ad5e8a3b872cead3f6fedf91632d6b44c3/tools/metrics/histograms/enums.xml [modify] https://crrev.com/08b963ad5e8a3b872cead3f6fedf91632d6b44c3/tools/metrics/histograms/histograms.xml
,
Jan 11 2018
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/455fc184db1479464a06ef4101daa0e06a923341 commit 455fc184db1479464a06ef4101daa0e06a923341 Author: James Cook <jamescook@chromium.org> Date: Mon Sep 24 19:32:05 2018 chromeos: Convert PointerMetricsRecorder to ui::EventHandler PointerWatchers aren't necessary in ash anymore. ui::EventHandler does everything that PointerWatcher can do, plus can mutate events. Once we eliminate PointerWatcher from ash we can delete some glue code I added to make them work. Also drop support for ui::EventPointerType::POINTER_TYPE_UNKNOWN, which is never recorded in practice. (I don't think we ever generate events with this type.) Bug: 872450 , 786214 Test: ash_unittests Change-Id: I08f781dd6e26b34870e7947c3a14e42edaf91080 Reviewed-on: https://chromium-review.googlesource.com/1239455 Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#593631} [modify] https://crrev.com/455fc184db1479464a06ef4101daa0e06a923341/ash/metrics/pointer_metrics_recorder.cc [modify] https://crrev.com/455fc184db1479464a06ef4101daa0e06a923341/ash/metrics/pointer_metrics_recorder.h [modify] https://crrev.com/455fc184db1479464a06ef4101daa0e06a923341/ash/metrics/pointer_metrics_recorder_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by tbuck...@chromium.org
, Dec 5 2017Owner: xiaoyinh@chromium.org