New issue
Advanced search Search tips

Issue 786212 link

Starred by 1 user
Status: Assigned
Owner:
qin...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Flaky test: ThumbnailDiskStorageTest#testRetrieveThumbnailShouldMakeEntryMostRecent

Project Member Reported by nyquist@chromium.org, Nov 17 2017 
Failed build: https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/17450

Flakiness: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.widget.ThumbnailDiskStorageTest%23testRetrieveThumbnailShouldMakeEntryMostRecent

org.chromium.chrome.browser.widget.ThumbnailDiskStorageTest#testRetrieveThumbnailShouldMakeEntryMostRecent

java.lang.AssertionError: expected:<0> but was:<1>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.junit.Assert.assertEquals(Assert.java:631)
	at org.chromium.chrome.browser.widget.ThumbnailDiskStorageTest.testRetrieveThumbnailShouldMakeEntryMostRecent(ThumbnailDiskStorageTest.java:226)
	at java.lang.reflect.Method.invoke(Native Method)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:184)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:41)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:166)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:100)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/607b25307f8c8ce7b50b23696863e9dd8b4fbd7e

commit 607b25307f8c8ce7b50b23696863e9dd8b4fbd7e
Author: Tommy Nyquist <nyquist@chromium.org>
Date: Fri Nov 17 00:42:00 2017

Disable flaky test for ThumbnailDiskStorageTest

Failing test:
ThumbnailDiskStorageTest#testRetrieveThumbnailShouldMakeEntryMostRecent

TBR=qinmin@chromium.org
BUG=786212
NOTRY=true

Change-Id: I3a52e5017406efe413f7cbc0f3e37a9762914653
Reviewed-on: https://chromium-review.googlesource.com/776129
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517228}
[modify] https://crrev.com/607b25307f8c8ce7b50b23696863e9dd8b4fbd7e/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorageTest.java
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29467520e7850fac4ab73de2be0f9557e6aa9085

commit 29467520e7850fac4ab73de2be0f9557e6aa9085
Author: Min Qin <qinmin@chromium.org>
Date: Mon Nov 27 21:15:09 2017

Fix flaky ThumbnailDiskStorageTest

When these tests start, there could be some files in the disk cache.
The tests did call mTestThumbnailDiskStorage.clear() in setUp().
However, they did not clear the removeCount value.
As a result, tests can fail if the removeCount is not initiazed to 0.

BUG=786212,778829

Change-Id: I0f797b019ed5e0cb3b6148da9b79d9679c125a43
Reviewed-on: https://chromium-review.googlesource.com/783494
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519405}
[modify] https://crrev.com/29467520e7850fac4ab73de2be0f9557e6aa9085/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorageTest.java

Comment 3 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment