Convert Launcher StateTransition animation to ThreadedTransformTransition animation |
|||
Issue descriptionCurrently Launcher StateTransition animation is using LayerAnimationElement::BoundsElement. BoundsTransition will SetBoundsFromAnimation on each OnProgress. Although there is no bound size change during the animation, there is overhead to update animation from ash/views and do a whole commit every frame. Converting to ThreadedTransformTransition can let compositor optimize and accelerate the animation.
,
Nov 17 2017
Will this animation work on mash? We will eventually need to make the launcher resize vertically instead of moving a large portion of the widget off screen. For context please see 768437
,
Nov 17 2017
,
Nov 17 2017
sg. Currently my change is only replacing the animation type. I am guessing to make it not fullscreen initially, will have huge changes to app_list_view, not only the animations.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e32c19691e53f4e3dc20e96721531a3b064b496 commit 9e32c19691e53f4e3dc20e96721531a3b064b496 Author: wutao <wutao@chromium.org> Date: Fri Nov 17 20:07:56 2017 cros: Use transform animation for Launcher state transition. Currently Launcher state transition animation is using layer animation element of BoundsElement, which will SetBoundsFromAnimation on each OnProgress. This will generate additional overhead with a whole commit every frame. This cl converts it to use ThreadedTransformTransition, which will let compositor optimize and accelerate the animation. Bug:786209 Test:On Cyan and EVE Average Smoothness Improved: Cyan: 1x slow-down-compositing-scale-factor: 88% -> 100% 10x slow-down-compositing-scale-factor: 63% -> 73% 1x slow-down-compositing-scale-factor: 93% -> 99% 5x slow-down-compositing-scale-factor: 46% -> 59% EVE: Change-Id: I960421d89762ff7fcb7c4e230d98137cd3e61170 Reviewed-on: https://chromium-review.googlesource.com/776195 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517525} [modify] https://crrev.com/9e32c19691e53f4e3dc20e96721531a3b064b496/ui/app_list/views/app_list_view.cc
,
Nov 27 2017
Close this one, UMA indicated that there is about 25% smoothness improvement at 50% percentile canary machines from 67% => 84%. https://uma.googleplex.com/p/chrome/timeline_v2/?sid=f2b7c920aaeda211ff502cc56121f62d |
|||
►
Sign in to add a comment |
|||
Comment 1 by wutao@chromium.org
, Nov 17 2017