Separate logic and flow. Move logic in pipelines to srevices/ module and make pipelines only control the flow.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/e164be0651c2d6f58e0ba96bf562fd2fd95b207a commit e164be0651c2d6f58e0ba96bf562fd2fd95b207a Author: Chan <chanli@chromium.org> Date: Fri Nov 17 17:44:38 2017 [Findit] move remaining logic in culprit action wrapper pipelines to service. Bug: 786201 Change-Id: I34740d7845c457253505876418488f84406afdc6 Reviewed-on: https://chromium-review.googlesource.com/775908 Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [add] https://crrev.com/e164be0651c2d6f58e0ba96bf562fd2fd95b207a/appengine/findit/services/compile_failure/test/compile_culprit_action_test.py [modify] https://crrev.com/e164be0651c2d6f58e0ba96bf562fd2fd95b207a/appengine/findit/services/test/monitoring_test.py [add] https://crrev.com/e164be0651c2d6f58e0ba96bf562fd2fd95b207a/appengine/findit/services/test/culprit_action_test.py [modify] https://crrev.com/e164be0651c2d6f58e0ba96bf562fd2fd95b207a/appengine/findit/pipelines/compile_failure/revert_and_notify_compile_culprit_pipeline.py [modify] https://crrev.com/e164be0651c2d6f58e0ba96bf562fd2fd95b207a/appengine/findit/pipelines/compile_failure/test/revert_and_notify_compile_culprit_pipeline_test.py [add] https://crrev.com/e164be0651c2d6f58e0ba96bf562fd2fd95b207a/appengine/findit/services/culprit_action.py [modify] https://crrev.com/e164be0651c2d6f58e0ba96bf562fd2fd95b207a/appengine/findit/pipelines/test_failure/revert_and_notify_test_culprit_pipeline.py [modify] https://crrev.com/e164be0651c2d6f58e0ba96bf562fd2fd95b207a/appengine/findit/services/monitoring.py [add] https://crrev.com/e164be0651c2d6f58e0ba96bf562fd2fd95b207a/appengine/findit/services/compile_failure/compile_culprit_action.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/cdcb665d7af90c9d6aa09e175e43ff3f3ac2f6ca commit cdcb665d7af90c9d6aa09e175e43ff3f3ac2f6ca Author: Chan <chanli@chromium.org> Date: Mon Nov 27 20:38:28 2017 [Findit] Move logic in monitor_try_job_pipeline to service module Bug: 786201 Change-Id: Id9b2bdd87eb2e27f643016772d0c21eaea3696ef Reviewed-on: https://chromium-review.googlesource.com/783841 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/cdcb665d7af90c9d6aa09e175e43ff3f3ac2f6ca/appengine/findit/services/test/monitoring_test.py [modify] https://crrev.com/cdcb665d7af90c9d6aa09e175e43ff3f3ac2f6ca/appengine/findit/services/test/try_job_test.py [modify] https://crrev.com/cdcb665d7af90c9d6aa09e175e43ff3f3ac2f6ca/appengine/findit/services/try_job.py [modify] https://crrev.com/cdcb665d7af90c9d6aa09e175e43ff3f3ac2f6ca/appengine/findit/waterfall/monitor_try_job_pipeline.py [modify] https://crrev.com/cdcb665d7af90c9d6aa09e175e43ff3f3ac2f6ca/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py [modify] https://crrev.com/cdcb665d7af90c9d6aa09e175e43ff3f3ac2f6ca/appengine/findit/services/monitoring.py
Comment 1 by bugdroid1@chromium.org
, Nov 17 2017