Issue metadata
Sign in to add a comment
|
Flaky test: VrShellControllerInputTest#testControllerScrolling |
||||||||||||||||||||||||
Issue descriptionFailed build: https://build.chromium.org/p/chromium.android/builders/Nougat%20Phone%20Tester/builds/1309 Flakiness: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_vr_apk-pixelxl-ddview-nougat&tests=org.chromium.chrome.browser.vr_shell.VrShellControllerInputTest%23testControllerScrolling org.chromium.chrome.browser.vr_shell.VrShellControllerInputTest#testControllerScrolling java.lang.AssertionError: Controller was able to scroll down at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.chromium.chrome.browser.vr_shell.VrShellControllerInputTest.testControllerScrolling(VrShellControllerInputTest.java:96) at java.lang.reflect.Method.invoke(Native Method) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) at org.chromium.chrome.browser.vr_shell.rules.ChromeTabbedActivityVrTestRule$1.evaluate(ChromeTabbedActivityVrTestRule.java:27) at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:116) at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:184) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:41) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:166) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59) at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:99) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)
,
Nov 17 2017
Re-assigning to Ian for now since he offered to take a look.
,
Nov 28 2017
I ran the affected test 500 times on the same swarming devices and with the same gn args with no repro. Any objections to re-enabling it?
,
Nov 28 2017
Up to you. But if you do, please follow along the build for a few days to see that it's still stable.
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1539faa06c2407693e89a78618eb150836934519 commit 1539faa06c2407693e89a78618eb150836934519 Author: bsheedy <bsheedy@chromium.org> Date: Tue Dec 05 23:26:50 2017 Re-enable VR Browser scrolling test Re-enables VrShellControllerInputTest#testControllerScrolling which was disabled due to a flake. Was unable to reproduce the flake after running the test on the swarmed devices with the same gn args 500 times. Bug: 786200 Change-Id: Iaf8e362381dd2da60ac2e155de99af0d2535e0b4 Reviewed-on: https://chromium-review.googlesource.com/809884 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521887} [modify] https://crrev.com/1539faa06c2407693e89a78618eb150836934519/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellControllerInputTest.java
,
Dec 11 2017
The test has been running without issue for the past 5 days, so I'll go ahead and close this.
,
Feb 8 2018
,
Jul 4
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 17 2017