SourceUrlRecorder should be recording all of the URLs that we allow to be recorded, so we should be able to use it's URLs as a whitelist and strip data from other sources. This would provide an extra check against incorrect uses of UpdateSourceUrl.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc8e22cb13f7897a9f3a45fb504f37b9813948ca commit bc8e22cb13f7897a9f3a45fb504f37b9813948ca Author: Steven Holte <holte@google.com> Date: Wed Dec 20 21:21:42 2017 Cleanup UkmSource interface. Replace setters with constructor args, simplify comments. Bug: 786190 Change-Id: I1aa9a8c085de9b1418ef9397c4d180394ed35842 Reviewed-on: https://chromium-review.googlesource.com/835271 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#525462} [modify] https://crrev.com/bc8e22cb13f7897a9f3a45fb504f37b9813948ca/components/ukm/ukm_recorder_impl.cc [modify] https://crrev.com/bc8e22cb13f7897a9f3a45fb504f37b9813948ca/components/ukm/ukm_source.cc [modify] https://crrev.com/bc8e22cb13f7897a9f3a45fb504f37b9813948ca/components/ukm/ukm_source.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a1aee6f2123c726eb60032977318318ed27b67a commit 3a1aee6f2123c726eb60032977318318ed27b67a Author: Steven Holte <holte@google.com> Date: Wed Jan 10 23:36:26 2018 Don't keep multiple URLs for non-navigation IDs. Bug: 786190 Change-Id: Ib158b7f08497008ceb50fb83b19e35f8b2f9be3b Reviewed-on: https://chromium-review.googlesource.com/835355 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#528482} [modify] https://crrev.com/3a1aee6f2123c726eb60032977318318ed27b67a/components/ukm/ukm_recorder_impl.cc [modify] https://crrev.com/3a1aee6f2123c726eb60032977318318ed27b67a/components/ukm/ukm_source.cc [modify] https://crrev.com/3a1aee6f2123c726eb60032977318318ed27b67a/components/ukm/ukm_source.h [modify] https://crrev.com/3a1aee6f2123c726eb60032977318318ed27b67a/services/metrics/public/cpp/ukm_source_id.cc [modify] https://crrev.com/3a1aee6f2123c726eb60032977318318ed27b67a/services/metrics/public/cpp/ukm_source_id.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8100cca0976a6a5d17b5a889c99fd87da22ab76c commit 8100cca0976a6a5d17b5a889c99fd87da22ab76c Author: Steven Holte <holte@google.com> Date: Wed Mar 07 20:36:01 2018 Use NavigationId based UKM sources as a URL whitelist. Bug: 786190 Change-Id: Ie97d20c6893865d876ea39083861e5400493de42 Reviewed-on: https://chromium-review.googlesource.com/833390 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#541561} [modify] https://crrev.com/8100cca0976a6a5d17b5a889c99fd87da22ab76c/components/ukm/ukm_recorder_impl.cc [modify] https://crrev.com/8100cca0976a6a5d17b5a889c99fd87da22ab76c/components/ukm/ukm_recorder_impl.h [modify] https://crrev.com/8100cca0976a6a5d17b5a889c99fd87da22ab76c/components/ukm/ukm_service_unittest.cc [modify] https://crrev.com/8100cca0976a6a5d17b5a889c99fd87da22ab76c/tools/metrics/histograms/enums.xml
Comment 1 by bugdroid1@chromium.org
, Dec 20 2017