New issue
Advanced search Search tips

Issue 786184 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS , Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Text in multiprofile dropdown is garbled

Project Member Reported by sdantul...@chromium.org, Nov 16 2017

Issue description

Google Chrome	64.0.3270.0 (Official Build) dev (64-bit)
Revision	0
Platform	10134.0.0 (Official Build) dev-channel samus

What steps will reproduce the problem?
(1) Add secondary user account using multi-profile feature
(2) Open uber tray and click on username section

What happens?
Text in the dropdown is garbled and overlaps with system menu entries

Attached repro video.
 
Nov 16 2017 3_27 PM.webm
923 KB View Download
Labels: ReleaseBlock-Stable Hotlist-Triaged
Owner: zork@chromium.org
Status: Assigned (was: Untriaged)
Seems related to  Issue 726595 .

Comment 2 by zork@chromium.org, Nov 20 2017

Cc: zork@chromium.org
Owner: x...@chromium.org
Daisy, could you have someone take a look?  The fix in the referenced bug seems straightforward to test.

Comment 3 by x...@chromium.org, Nov 21 2017

Will do a quick bisect.

Comment 4 by x...@chromium.org, Nov 21 2017

Owner: sammiequon@chromium.org
Bisect is done. culprit CL: https://chromium-review.googlesource.com/c/chromium/src/+/769162
Assign to the owner for further investigation.

Comment 5 by tetsui@chromium.org, Nov 28 2017

Cc: tetsui@chromium.org

Comment 6 by tetsui@chromium.org, Nov 28 2017

Cc: yhanada@chromium.org satorux@chromium.org
 Issue 789053  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e8dc3961a145c78c60e74b9c84081bc1857b4a7

commit 1e8dc3961a145c78c60e74b9c84081bc1857b4a7
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Nov 28 23:31:09 2017

tray: Fix garbled text in multiprofile dropdown.

Bug introduced when I was trying to show focus rectangle around user
card view by removing the background. Draw the background instead on
the parent, button_from_view, which the focus painter is on so that
the background does not cover the focus rectangle.

Also fix the separator between the user card view and the drop down,
before it only reached halfway (see bug for snapshot).

Test: manual
Bug:  786184 
Change-Id: I54481c414a373a9f761d4b2f6b8097160633fbdc
Reviewed-on: https://chromium-review.googlesource.com/794853
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519897}
[modify] https://crrev.com/1e8dc3961a145c78c60e74b9c84081bc1857b4a7/ash/system/user/button_from_view.cc
[modify] https://crrev.com/1e8dc3961a145c78c60e74b9c84081bc1857b4a7/ash/system/user/user_view.cc

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
Labels: Merge-Request-64 OS-iOS
Status: Assigned (was: Fixed)
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 30 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: We don't branch M64 until 2017-11-30.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-TBD -Merge-Review-64
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
10176.30.0, 64.0.3282.57

Sign in to add a comment