Print jobs killed prematurely |
|||||||||
Issue descriptionWe currently wait 20 seconds [1] between printer processing and print job cancellation if there is no progress. When this was added, it was believed that this is only relevant for printers that can't be reached. However, as evidenced by crbug.com/756878 and some manual testing, it is possible for a print job to spend more than 20 seconds in the filtering stage causing a timeout. Determine if we can differentiate between waiting for the filters and waiting for a printer and don't kill the job if the filters are still running. [1] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc?rcl=5c3c4ac899a17f8ceab3a6f5fc8090935a6e371b&l=43
,
Nov 17 2017
skau@ few questions about time out, -is it possible to create a patch to change this timeout value? because the customer has been working this issue since Aug 18 and we want to provide the solution ASAP.
,
Nov 17 2017
,
Nov 17 2017
I'll increase timeout to 60 seconds until we can figure out why this is failing.
,
Dec 1 2017
skau@ Is there any update that can be shared with the customer? Would be nice if you could arrange the batch file to change the timeout window.
,
Dec 2 2017
,
Dec 2 2017
I'm going to increase the timeout in M64. We'll have a proper fix in M65.
,
Dec 2 2017
luum@ please investigate if we can differentiate between an unreachable printer and a pipeline timeout.
,
Dec 2 2017
Issue 756878 has been merged into this issue.
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8229631e3aca5b48c77211ce443c5947c7c42f4f commit 8229631e3aca5b48c77211ce443c5947c7c42f4f Author: Sean Kau <skau@chromium.org> Date: Mon Dec 04 20:14:45 2017 Increase print job timeout to 120s from 20s. Some print jobs take a very long time to render. Add some buffer to allow rendering to complete. Long term, we hope to reduce the timeout to 20s to detect if a printer is reachable. If a printer is unreachable, this change will result in extending the time a user waits from 20 to 120s. This should only be encountered by users setting up their printer for the first time. Bug: 786182 , 791230 Change-Id: I5088654b3f8a68b1178efeef98c5cb66dfe4647c Reviewed-on: https://chromium-review.googlesource.com/804606 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#521425} [modify] https://crrev.com/8229631e3aca5b48c77211ce443c5947c7c42f4f/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15b251800452c14148a1cc06312313a1baaf4665 commit 15b251800452c14148a1cc06312313a1baaf4665 Author: Sean Kau <skau@chromium.org> Date: Tue Dec 05 22:11:00 2017 Increase print job timeout to 120s from 20s. Some print jobs take a very long time to render. Add some buffer to allow rendering to complete. Long term, we hope to reduce the timeout to 20s to detect if a printer is reachable. If a printer is unreachable, this change will result in extending the time a user waits from 20 to 120s. This should only be encountered by users setting up their printer for the first time. Bug: 786182 , 791230 Change-Id: I5088654b3f8a68b1178efeef98c5cb66dfe4647c Reviewed-on: https://chromium-review.googlesource.com/804606 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521425}(cherry picked from commit 8229631e3aca5b48c77211ce443c5947c7c42f4f) Reviewed-on: https://chromium-review.googlesource.com/809766 Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#39} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/15b251800452c14148a1cc06312313a1baaf4665/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
,
Dec 28 2017
skau@ Just letting you know the customer who reported crbug.com/756878 was solved by M64 Beta. Many thanks.
,
Feb 15 2018
,
Feb 15 2018
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4864102a269ee13e8f1b7ebaddb18b9a2a579f4f commit 4864102a269ee13e8f1b7ebaddb18b9a2a579f4f Author: Luum Habtemariam <luum@chromium.org> Date: Wed Mar 14 21:22:02 2018 Setting CUPS printer connection timeout Previous default timeout in CUPS was set to a week, now set to 20 seconds, bringing it inline with previous chrome sanctioned timeout. Also changes behavior so that in no cases does CUPS attempt to connect to the printer forever; treats all failures as such. BUG= chromium:786182 TEST=Manually ensured printing still succeeds and timeout kicks in when necessary Change-Id: I93ca0e6f175803056c83542961d1bf098c45ea5f Reviewed-on: https://chromium-review.googlesource.com/942081 Commit-Ready: Luum Habtemariam <luum@chromium.org> Tested-by: Luum Habtemariam <luum@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Reviewed-by: Luum Habtemariam <luum@chromium.org> [rename] https://crrev.com/4864102a269ee13e8f1b7ebaddb18b9a2a579f4f/net-print/cups/cups-2.1.4-r42.ebuild [modify] https://crrev.com/4864102a269ee13e8f1b7ebaddb18b9a2a579f4f/net-print/cups/cups-2.1.4.ebuild [add] https://crrev.com/4864102a269ee13e8f1b7ebaddb18b9a2a579f4f/net-print/cups/files/cups-2.1.4-timeout.patch
,
Mar 15 2018
,
Mar 15 2018
Can you change the timeout in Chrome back to something reasonable and verify the original behavior works now?
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d717d7626dc51d4fecaa38066189c4e8cb25e169 commit d717d7626dc51d4fecaa38066189c4e8cb25e169 Author: Luum Habtemariam <luum@chromium.org> Date: Tue Mar 20 19:17:27 2018 Removing Printer/CUPSd timeout We've shifted the printer connection timeout from chrome into CUPS, per https://chromium-review.googlesource.com/4864102. This change is just removing the chrome-side timeout. BUG= chromium:786182 TEST=Manually ensured original printing behavior and CUPS timeout works as chrome-side timeout intended Change-Id: I849595451c27f666503244418e3ac91403314663 Reviewed-on: https://chromium-review.googlesource.com/966795 Reviewed-by: Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#544477} [modify] https://crrev.com/d717d7626dc51d4fecaa38066189c4e8cb25e169/chrome/browser/chromeos/printing/cups_print_job.h [modify] https://crrev.com/d717d7626dc51d4fecaa38066189c4e8cb25e169/chrome/browser/chromeos/printing/cups_print_job_manager_impl.cc
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/cups/+/95406929f42777494eadc245becdce5928c281ab commit 95406929f42777494eadc245becdce5928c281ab Author: David Valleau <valleau@chromium.org> Date: Tue Jul 31 06:07:55 2018 Applying cups-2.1.4-timeout.patch Decrease printer connection timeout from a week to 20 seconds. Consider all failures timeout worthy; no more cases of waiting for a connection forever. This allows us to use a larger timeout on chrome, allowing ample time for large print jobs and still catching persistent non-connection failures. From: Luum Habtemariam <luum@chromium.org> Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=786182 BUG= chromium:865217 TEST=None Change-Id: Ibc6d20f80f636489442d2fa3681b0ad30f99a24a Reviewed-on: https://chromium-review.googlesource.com/1145668 Commit-Ready: David Valleau <valleau@chromium.org> Tested-by: David Valleau <valleau@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> [modify] https://crrev.com/95406929f42777494eadc245becdce5928c281ab/backend/ipp.c |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by skau@chromium.org
, Nov 16 2017