isolate: allow isolated "includes" to be mapped at relative path from the root isolated file |
|||
Issue description
Currently "includes" in an isolated file is a list of hashes. This is problem for swarmbucket which wants to accept an isolate hash from the user, create a new isolate that includes the user-defined isolate at *certain relative path* and forward it to swarming.
Please allow the following format of includes:
includes: {
"<isolated hash>": {
path: "<where to extract it>
},
"<another isolate hash>": {
# path defaults to "." where . is the path to the outer isolate
}
}
,
Nov 20 2017
Challenge: run_isolated.py was recently modified to ignore command defined in included isolated file. So if you create a synthetic isolated file, you need to copy the command and relative_cwd too. - The issue stem from the fact that we still put the command in the .isolated file, referencing issue 665183 to switch to setting the command as part of the swarming task description. Other that this hurdle, includes with relative path would be fairly straight forward. Supporting multiple inputs is also an option but I feel it's less clean :/ and it requires more API modifications. The solution proposed by Nodir is simpler refactoring-wise.
,
Nov 22 2017
I think it is better to do on the isolate level in case swarming is not the only thing that may benefit from this
,
Nov 22 2017
isolated* but yes, I tend to agree.
,
Dec 13 2017
,
May 30 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by iannucci@chromium.org
, Nov 16 2017