white list networkType in kRTCIceCandidatePairStats |
|||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36 Steps to reproduce the problem: networkType has been added in webrtc: https://webrtc-review.googlesource.com/c/src/+/14680 And the change will be merged to chromium. To make chromium pass the bot, it must be white listed in https://cs.chromium.org/chromium/src/chrome/test/data/webrtc/peerconnection_getstats.js What is the expected behavior? What went wrong? It's not white listed so chromium bot fails Did this work before? N/A Does this work in other browsers? N/A Chrome version: 62.0.3202.94 Channel: stable OS Version: Flash Version:
,
Nov 16 2017
It should be white listed in kRTCIceCandidateStats
,
Nov 16 2017
CL is out for review https://chromium-review.googlesource.com/c/chromium/src/+/776057
,
Nov 17 2017
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f31962851d8296f693e7c54c5828c3a83294c126 commit f31962851d8296f693e7c54c5828c3a83294c126 Author: Gary Liu <qinghualiu@google.com> Date: Fri Nov 17 22:18:09 2017 White list networkType in RTCIceCandidateStats networkType has been added in WebRTC code and it will be merged to chromium. To make chromium pass the bot, it must be white listed Bug: 786166 Change-Id: Ic578edc3b1d724fcee994f94dd3a0b19f67323a4 Reviewed-on: https://chromium-review.googlesource.com/776057 Commit-Queue: Gary Liu <qinghualiu@google.com> Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#517582} [modify] https://crrev.com/f31962851d8296f693e7c54c5828c3a83294c126/chrome/test/data/webrtc/peerconnection_getstats.js
,
Dec 13 2017
Correct me if I'm wrong, but wasn't this fixed for M-64? |
|||
►
Sign in to add a comment |
|||
Comment 1 by manoranj...@chromium.org
, Nov 16 2017Components: Blink>WebRTC
Labels: Needs-Triage-M62