New issue
Advanced search Search tips

Issue 786164 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-17
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

A11y: ChromeVox incorrect reading behavior on specific website

Project Member Reported by leberly@chromium.org, Nov 16 2017

Issue description

Report from an end user:

"I am using an acer chrome book and am losing speech.  The trouble occurs with n f b newsline.  The problem is when I select full section the speech halts and I can’t resume it.  I have no trouble reading every section title.  I would appreciate advice.  These selections seem to be a table to me."

Assigning to David S for investigation and repro on Chrome OS and JAWS/NVDA on Windows.

This is related to these table bugs:
https://bugs.chromium.org/p/chromium/issues/detail?id=785135
https://bugs.chromium.org/p/chromium/issues/detail?id=786161

 
I am currently testing with a section here: http://www.nfbnewslineonline.org/NOLFullSection.jsp?NewspaperId=511&IssueDate=17486&SectionId=10

If there is a specific section I should test instead, please include in a comment.

It doesn't present as a table on windows.
Cc: leberly@chromium.org
Components: UI>Accessibility>ChromeVox
Labels: -OS-Windows
Summary: A11y: ChromeVox incorrect reading behavior on specific website (was: A11y: Chrome + Jaws incorrect behavior with tables on specific website)
I don't think this is a table issue. It might be a scrolling issue.
Google Chrome 63.0.3239.42 (Official Build) beta (64-bit)
Firmware Version Google_Samus.6300.174.0

# With ChromeVox running: visit http://www.nfbnewslineonline.org/NOLFullSection.jsp?NewspaperId=511&IssueDate=17486&SectionId=10
# Note that you will need to login 
# Press search+3 to jump to the first article
# Press search+down arrow multiple times to read the article
# Notice that focus jumps to the top about half way through the article

Expected: ChromeVox continues down the page

Actual: ChromeVox jumps to the top after a few lines.

# Press search+ctrl+left arrow to return to top
# Press search+3 to jump to first article
# Press search+r once to begin reading from the cursor
# Notice how ChromeVox repeats sections of the article seemingly at random

Expected: ChromeVox continues reading through the page

Actual: odd repeating of whole sections of the page


Components: -UI>Accessibility>Compatibility
Removing the UI>Accessibility>ChromeVox component since this is only an issue on Chrome OS.

Comment 4 by dtseng@chromium.org, Nov 17 2017

Cc: dmazz...@chromium.org
Owner: dtseng@chromium.org
It could very well be an issue on all platforms. The root cause is the recent changes to clip offscreen node rectangles. Since everything's clipped, ChromeVox believes everything is on the *same* line since that's what the accessibility node data says. I have a change to ignore this calcuation for nodes marked as offscreen.

Also, ChromeVox-ism note: ChromeVox Search up/down is line navigation. We try to stay true to the data reported by Chrome as far as representing the visual line. So, in the case of NFB Newsline, the lines appear to wrap by word in some of the publication table links, so it does give a sub optimal experience.

Typically, Search+Left/Right gets used for primary navigation.

Comment 5 by dtseng@chromium.org, Nov 17 2017

Labels: -Type-Bug -Pri-2 M-63 Pri-1 Type-Bug-Regression

Comment 6 by dtseng@chromium.org, Nov 17 2017

Labels: Release-Block-Stable
NextAction: 2017-11-17
Owner: katie@chromium.org

Comment 7 by katydek@google.com, Nov 17 2017

Status: Started (was: Assigned)
Labels: -Release-Block-Stable ReleaseBlock-Stable
Katie, please reassign to me before you leave on vacation, so I can help with the merge next week.

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf5767172e191a022fac3deec4d772968015aaf5

commit bf5767172e191a022fac3deec4d772968015aaf5
Author: Katie Dektar <katydek@google.com>
Date: Fri Nov 17 23:50:02 2017

Disable clipping temporarily to fix a bug in Chrome 63.

Clipping will be re-enabled with a more robust solution for
newer versions of chrome, that will expose both the clipped
and unclipped bounds to ChromeVox.

Bug:  786164 
Change-Id: Ia22fc00236168f9ba41841f6810b72bdd24d4612
Reviewed-on: https://chromium-review.googlesource.com/777541
Commit-Queue: Katie D <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517620}
[modify] https://crrev.com/bf5767172e191a022fac3deec4d772968015aaf5/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/bf5767172e191a022fac3deec4d772968015aaf5/ui/accessibility/ax_tree.cc
[modify] https://crrev.com/bf5767172e191a022fac3deec4d772968015aaf5/ui/accessibility/ax_tree_unittest.cc

Comment 10 by katie@chromium.org, Nov 17 2017

Owner: dmazz...@chromium.org
Change into trunk, re-assigning to Dominic since I'll be OOO next week.
Labels: Merge-Request-63
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 20 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-63 Merge-Approved-63
Please mark bug as fixed for TE to verify.
Status: fixed (was: Started)
Cc: kathrelk...@chromium.org
+ kathrelkeld. Note that this is a revert of a change that went into 63.
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 21 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/735d8176443d7d16488b8b9efa73477a91fea5d2

commit 735d8176443d7d16488b8b9efa73477a91fea5d2
Author: David Tseng <dtseng@chromium.org>
Date: Tue Nov 21 23:48:37 2017

[Merge to m63]: Disable clipping temporarily to fix a bug in Chrome 63.

Clipping will be re-enabled with a more robust solution for
newer versions of chrome, that will expose both the clipped
and unclipped bounds to ChromeVox.

Bug:  786164 
Change-Id: Ia22fc00236168f9ba41841f6810b72bdd24d4612
Reviewed-on: https://chromium-review.googlesource.com/777541
Commit-Queue: Katie D <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517620}
(cherry picked from commit bf5767172e191a022fac3deec4d772968015aaf5)

TBR=dmazzoni@chromium.org

Change-Id: Ifd3ec2597c3efc4b92a9de4dec29496ac2a168ec
Reviewed-on: https://chromium-review.googlesource.com/783492
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#557}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/735d8176443d7d16488b8b9efa73477a91fea5d2/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/735d8176443d7d16488b8b9efa73477a91fea5d2/ui/accessibility/ax_tree.cc
[modify] https://crrev.com/735d8176443d7d16488b8b9efa73477a91fea5d2/ui/accessibility/ax_tree_unittest.cc

Owner: katie@chromium.org
Status: started (was: Fixed)
Labels: -ReleaseBlock-Stable -M-63 M-64 ReleaseBlock-Beta
Re-initroduced in 64; assigning to katie@ who is fixing.

Comment 20 by katydek@google.com, Nov 29 2017

Status: Fixed (was: Started)
This got fixed in 63 with the cherry-picked revert.

I just submitted https://chromium-review.googlesource.com/794511 which re-enabled the functionality introduced in the breaking change without re-breaking things.

Marking fixed... please re-open if needed.
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d367a74b10a8ab3e6842b6babaf60f2962ff0167

commit d367a74b10a8ab3e6842b6babaf60f2962ff0167
Author: Katie Dektar <katydek@google.com>
Date: Wed Nov 29 23:21:39 2017

Fix test failures in Chrome 63 by removing offscreen tests.

TBR:katie@chromium.org,dtseng@chromium.org

Bug: 789425, 788853 , 786164 
Change-Id: I5ab250b3268e01064050779908ea1eb017bd643e
Reviewed-on: https://chromium-review.googlesource.com/798117
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#613}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/d367a74b10a8ab3e6842b6babaf60f2962ff0167/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/d367a74b10a8ab3e6842b6babaf60f2962ff0167/content/browser/accessibility/one_shot_accessibility_tree_search_unittest.cc

 Issue 784685  has been merged into this issue.

Sign in to add a comment