New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786160 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Display information of Previews related flags on chrome://interventions-internals

Project Member Reported by thanhdle@chromium.org, Nov 16 2017

Issue description

The number of flags that can affect previews is getting bigger and bigger, and chrome://interventions-internals page is a good place to group all the related flags.

It should display the current status of those and links to them in the chrome://flags page.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d9c78282fd1ed10842efea09878255fbdc5fc3d

commit 1d9c78282fd1ed10842efea09878255fbdc5fc3d
Author: Thanh Le <thanhdle@chromium.org>
Date: Mon Nov 20 21:37:15 2017

Display all previews related flag info on chrome://interventions-internals.

Changed the name of "Previews Mode" tab to "Interventions", and divide it to 2
sections "Intervention Status" and "Intervention Flags".

"Intervention Flags" now show the links to the flags in
chrome://flags, and the current value of those flags.

Screenshot: https://drive.google.com/a/chromium.org/file/d/1aC4lEdJZPjaZzlQCCKjOFuRLNnptlRPD
Screenshot: https://drive.google.com/a/chromium.org/file/d/1yo3gGc30wILw744FUCp-5reW3yRdXPR_

Bug:  786160 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5b55e0df7e3299c692bf35ec681ca9caa50f1ee2
Reviewed-on: https://chromium-review.googlesource.com/776315
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517934}
[modify] https://crrev.com/1d9c78282fd1ed10842efea09878255fbdc5fc3d/chrome/browser/resources/interventions_internals/index.css
[modify] https://crrev.com/1d9c78282fd1ed10842efea09878255fbdc5fc3d/chrome/browser/resources/interventions_internals/index.html
[modify] https://crrev.com/1d9c78282fd1ed10842efea09878255fbdc5fc3d/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/1d9c78282fd1ed10842efea09878255fbdc5fc3d/chrome/browser/ui/webui/interventions_internals/interventions_internals.mojom
[modify] https://crrev.com/1d9c78282fd1ed10842efea09878255fbdc5fc3d/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc
[modify] https://crrev.com/1d9c78282fd1ed10842efea09878255fbdc5fc3d/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.h
[modify] https://crrev.com/1d9c78282fd1ed10842efea09878255fbdc5fc3d/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/1d9c78282fd1ed10842efea09878255fbdc5fc3d/chrome/test/data/webui/interventions_internals_browsertest.js

Status: Fixed (was: Started)

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment