New issue
Advanced search Search tips

Issue 786153 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 634270
issue 161072



Sign in to add a comment

[SecureContext,Exposed=Worker] does not install globals for interfaces

Project Member Reported by jsb...@chromium.org, Nov 16 2017

Issue description

Repro:

(1) Define an interface 'Foo' via IDL with [SecureContext] and [Exposed=(Window,Worker)], e.g.

[SecureContext, Exposed=(Window,Worker)]
interface Foo {};

Expected:

`Foo` is exposed as a property of the global, i.e. `'Foo' in self` is true

Actual:

`Foo` is exposed in Window contexts, but not Worker contexts.

Note that [SecureContext] attributes on interfaces marked [Exposed=Worker] do appear, so if e.g. there's a `navigator.foo` you can get at instances from a secure context, but the interface names themselves aren't registered.






 

Comment 1 by jsb...@chromium.org, Nov 16 2017

Blocking: 161072 634270

Comment 2 by peria@chromium.org, Nov 17 2017

Owner: peria@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a92cfc96142454dddc5805c1bf236454f0c5cf66

commit a92cfc96142454dddc5805c1bf236454f0c5cf66
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Mon Nov 27 02:54:56 2017

bindings: Remove InstallOriginTrialFeaturesOnGlobal

InstallOriginTrialFeatuersOnGlobal (IOTFOG for shot) calls
V8Foo(Partial)::InstallConditionalFeaturesOnGlobal internally,
where Foo is the global object which the context has.

This CL moves the contents of V8Foo::ICFOG to V8Foo::ICF.
It enables to call them through WrapperTypeInfo, and it means
we no longer need IOTFOG.


Bug: 787325,  786153 ,  634270 
Change-Id: I50dc653f0f19a77fd9aa3a7b71fb985b4f68f781
Reviewed-on: https://chromium-review.googlesource.com/778699
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519207}
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/OriginTrialFeaturesForCore.cpp.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/OriginTrialFeaturesForModules.cpp.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/tests/results/core/OriginTrialFeaturesForCore.cpp
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/tests/results/modules/OriginTrialFeaturesForModules.cpp
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/platform/bindings/OriginTrialFeatures.cpp
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/platform/bindings/OriginTrialFeatures.h

Comment 4 by peria@chromium.org, Nov 29 2017

Status: Fixed (was: Assigned)

Sign in to add a comment