New issue
Advanced search Search tips

Issue 786131 link

Starred by 1 user
Status: Assigned
Owner:
rohitrao@chromium.org
Cc:
justincohen@chromium.org
olivierrobin@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove ui::ResourceBundle wrappers from ContentClient

Project Member Reported by reillyg@chromium.org, Nov 16 2017 
Code which needs to access the resource bundle can depend on //ui/base directly and so this layer of indirection is no longer needed.

This also means that these wrappers can be removed from WebClient which should enable a bit more code sharing between iOS and non-iOS sources that load resources, such as SharedResourcesDataSource(IOS).
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 19

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by reillyg@google.com, Nov 19

Labels: -OS-Linux -OS-Android -OS-Windows -OS-Chrome -OS-Mac -OS-Fuchsia
When I originally filed this issue I did not realize that we explicitly wanted to avoid creating this dependency. I'm going to leave it up to the iOS team to decide but the code sharing this would allow seems like it might make it worth it.

Comment 3 by olivierrobin@chromium.org, Nov 23

Cc: olivierrobin@chromium.org justincohen@chromium.org
Owner: rohitrao@chromium.org
Do we want to do this?

Comment 4 by kkhorimoto@chromium.org, Nov 29

Status: Assigned (was: Untriaged)
►

Sign in to add a comment