New issue
Advanced search Search tips

Issue 786117 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 802292
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 711468



Sign in to add a comment

[root layer scrolls] Check failed: !needs_descendant_dependent_flags_update_

Project Member Reported by skobes@chromium.org, Nov 16 2017

Issue description

The test plugins/mouse-events-fixedpos.html crashes flakily on Linux debug builds with root layer scrolling.  When RLS is disabled, it passes consistently.

$ blink/tools/run_layout_tests.sh -t d --additional-driver-flag=--root-layer-scrolls plugins/mouse-events-fixedpos.html

[1:1:1116/125211.392532:FATAL:PaintLayer.h(339)] Check failed: !needs_descendant_dependent_flags_update_. 
#0 0x7f5ae5fccecd base::debug::StackTrace::StackTrace()
#1 0x7f5ae5fcb2fc base::debug::StackTrace::StackTrace()
#2 0x7f5ae6052cca logging::LogMessage::~LogMessage()
#3 0x7f5ade01b713 blink::PaintLayer::HasVisibleContent()
#4 0x7f5ade01b5d9 blink::PaintLayer::SubtreeIsInvisible()
#5 0x7f5ade2b0b5c blink::LocalFrameView::InvalidateViewportConstrainedObjects()
#6 0x7f5adec84336 blink::PaintLayerScrollableArea::InvalidatePaintForScrollOffsetChange()
#7 0x7f5adec8393d blink::PaintLayerScrollableArea::UpdateScrollOffset()
#8 0x7f5adc3d8227 blink::ScrollableArea::ScrollOffsetChanged()
#9 0x7f5adc3d6c47 blink::ScrollAnimatorCompositorCoordinator::ScrollOffsetChanged()
#10 0x7f5adc3d0c51 blink::ProgrammaticScrollAnimator::NotifyOffsetChanged()
#11 0x7f5adc3d0ca8 blink::ProgrammaticScrollAnimator::ScrollToOffsetWithoutAnimation()
#12 0x7f5adc3d83f5 blink::ScrollableArea::ProgrammaticScrollHelper()
#13 0x7f5adc3d7f5e blink::ScrollableArea::SetScrollOffset()
#14 0x0000007678a1 blink::Internals::ResetToConsistentState()
#15 0x0000007a709e WebCoreTestSupport::resetInternalsObject()
#16 0x0000010b5b6a blink::WebTestingSupport::ResetInternalsObject()
#17 0x00000100e33b content::BlinkTestRunner::Reset()
#18 0x00000100d857 content::BlinkTestRunner::OnReset()
 
Components: Build
Labels: TE-NeedsTriageHelp
As the issue is related to code, which seems to be out of TE-scope. Hence, adding label TE-NeedsTriageHelp for further investigation

Comment 2 by pdr@chromium.org, Nov 17 2017

Components: -Build Blink>Layout
Labels: -TE-NeedsTriageHelp
Status: Available (was: Unconfirmed)
No TE help needed on this one, it's just an internal bug filed by the layout team.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149eed97cbbf8fb71c7e3e236ec76f521119d26b

commit 149eed97cbbf8fb71c7e3e236ec76f521119d26b
Author: Philip Rogers <pdr@chromium.org>
Date: Tue Nov 21 20:08:21 2017

[root layer scrolls] Update expectations

paint/invalidation/svg/js-update-stop-linked-gradient.svg:
This test was recently updated which removed gradient stops:
https://chromium.googlesource.com/chromium/src/+/e3276a9902608cd3930d2a1dad67d56b5ae98313
This patch updates the RLS expectation too.

http/tests/devtools/agents-enable-disable.js (and virtual variant):
This test is crashing on all platforms but the expectation was marked as
timeout on just mac.

plugins/mouse-events-fixedpos.html:
This test is crashing flakily (see:  https://crbug.com/786117 ).

To make it easier to update the expectations file, a new section for
flaky tests has been added.

Bug:  781419 ,  786117 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: Iba1f45b03a1ac2093c48a2cfcabf70c6f93a9d4d
Reviewed-on: https://chromium-review.googlesource.com/779760
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518353}
[modify] https://crrev.com/149eed97cbbf8fb71c7e3e236ec76f521119d26b/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/149eed97cbbf8fb71c7e3e236ec76f521119d26b/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-update-stop-linked-gradient-expected.txt

Comment 4 by skobes@chromium.org, Jan 30 2018

Mergedinto: 802292
Status: Duplicate (was: Available)

Sign in to add a comment