New issue
Advanced search Search tips

Issue 786105 link

Starred by 1 user
Status: Assigned
Owner:
iannu...@google.com
Cc:
hinoka@chromium.org
efoo@chromium.org
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Rename manifest key in console definition

Project Member Reported by no...@chromium.org, Nov 16 2017 
after offline discussion

generalize indexing for console to support not-landed CLs. This bug is underspecified, iannucci can add.

However, i see manifest_name in
https://chromium.googlesource.com/infra/luci/luci-go/+/c2acd12a614164d03f8c1a242cda1ccdbee178d7/milo/api/config/project.proto#129
isn't that what we need?

Comment 1 by iannucci@chromium.org, Nov 18 2017 

It's the same field, it just needs to be renamed. 'Manifest' refers to source manifest. Currently 0 of the values for 'manifest_name' are actually a manifest name. I was proposing to change 'manifest_name' to 'index_name', and then when we do index-by-manifest the index name would look something like "manifest/MANIFEST_NAME".

Comment 2 by iannu...@google.com, Oct 18

Owner: iannu...@google.com
►

Sign in to add a comment