New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Feb 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Drag and Drop: Dropping back a tab is broken.

Reported by sims...@gmail.com, Feb 19 2009 Back to list

Issue description

Chrome Version       : 2.0.165.0 (Dev Build 10024)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
     Safari 3: NA
    Firefox 3: NA
         IE 7: NA

What steps will reproduce the problem?
1. Open a window with 2 tabs
2. Drag one tab out so it will be a new window
3. Try to drag this tab back to the old window

What is the expected result?
 To be able to drag it back to its old window, like how it used to work.

What happens instead?
 It just moves the window around.

Please provide any additional information below. Attach a screenshot if 
possible.
 It still works in the latest normal chrome release.
 I first noticed this in build 9986.
 
Labels: -Pri-2 -Area-Misc Pri-1 Area-BrowserUI Regression
Status: Untriaged (was: NULL)
Summary: Drag and Drop: Dropping back a tab is broken. (was: NULL)
Confirmed in 2.0.165.0 (Developer Build 10008).


Status: Assigned (was: NULL)
Submitting a fix immediately. Sorry, when I fixed  issue 2827  and  3787  yesterday I was 
not aware of this functionality.

Comment 4 by bugdro...@gmail.com, Feb 20 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=10068 

------------------------------------------------------------------------
r10068 | idanan@chromium.org | 2009-02-19 16:39:58 -0800 (Thu, 19 Feb 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab.cc?r1=10068&r2=10067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab.h?r1=10068&r2=10067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_strip.cc?r1=10068&r2=10067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_strip.h?r1=10068&r2=10067

Enable dragging of single tab between two windows.

To determine if a window is draggable, all that was needed is to call HasAvailableDrag action
instead of ContainsExactlyOneTab which was not we wanted anyways.

BUG= 7861 

Review URL: http://codereview.chromium.org/21525
------------------------------------------------------------------------

 Issue 7879  has been merged into this issue.

Comment 6 by sims...@gmail.com, Feb 20 2009

Fix confirmed, it's working perfectly again. Thanks alot, that was very quick :)
Status: Fixed (was: NULL)
Status: Verified (was: NULL)
Verified in Chromium 2.0.165.0 (Developer Build 10094).
 Issue 7955  has been merged into this issue.
 Issue 8068  has been merged into this issue.
 Issue 8067  has been merged into this issue.
Labels: -Regression bulkmove Type-Regression
Chrome Version       : 2.0.165.0 (Dev Build 10024)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
     Safari 3: NA
    Firefox 3: NA
         IE 7: NA

What steps will reproduce the problem?
1. Open a window with 2 tabs
2. Drag one tab out so it will be a new window
3. Try to drag this tab back to the old window

What is the expected result?
 To be able to drag it back to its old window, like how it used to work.

What happens instead?
 It just moves the window around.

Please provide any additional information below. Attach a screenshot if 
possible.
 It still works in the latest normal chrome release.
 I first noticed this in build 9986.
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Type-Regression Type-Bug-Regression

Sign in to add a comment