New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786044 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: Bug

Blocked on:
issue 765321
issue 786745



Sign in to add a comment

Reduce ANGLE try job swarming bot usage

Project Member Reported by jmad...@chromium.org, Nov 16 2017

Issue description

Currently we're using a large proportion of the pool when we get 6+ simultaneous instances of "CQ dry run". We can be a bit smarter about our usage. In particular, we can cut out the simultaneous testing of 32-bit and 64-bit varieties of tests, choosing to run compile-only for some configs.

We could also revisit all the permutations of WebGL tests that we run.


 
Initial intent:

The intent for this change is to allow ANGLE to stop testing the x64
versions of the tests on the ANGLE CQ. The x64 full testers will be
replaced on the CQ with compile-only versions, and the full testers
will remain on the FYI bots.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229

commit 8c6f06b5a1c4a64305ff520dfce51ef4e56f1229
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Nov 17 17:27:07 2017

Add dEQP builders to buildbot json.

Bug:  786044 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8f7cb86b0bdff0b60ffe3d3a1553ff34c262ef1d
Reviewed-on: https://chromium-review.googlesource.com/774986
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517451}
[modify] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/8c6f06b5a1c4a64305ff520dfce51ef4e56f1229/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/74622760bfd7c35ac31fc9a45f1553fd97a02fc2

commit 74622760bfd7c35ac31fc9a45f1553fd97a02fc2
Author: Jamie Madill <jmadill@chromium.org>
Date: Sat Nov 18 20:22:58 2017

Add compile-only targets for ANGLE try bots.

The intent for this change is to allow ANGLE to stop testing the x64
versions of the tests on the ANGLE CQ. The x64 full testers will be
replaced on the CQ with compile-only versions, and the full testers
will remain on the FYI bots.

This also renames the debug testers to make it more clear they are
compile-only. No new FYI bot mirrors are needed because the new
compile-only configurations are merely mirrors of the FYI builders.

The old x64 targets are left around. This is necessary to prevent
breakage, and also we could keep them around as non-default try jobs
for tests.

Bug:  786044 
Tbr: tandrii@chromium.org
Change-Id: I9c0aa9f6582461a7654144f95943d6bf6a0def9d
Reviewed-on: https://chromium-review.googlesource.com/775147
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/74622760bfd7c35ac31fc9a45f1553fd97a02fc2/masters/master.tryserver.chromium.angle/slaves.cfg
[modify] https://crrev.com/74622760bfd7c35ac31fc9a45f1553fd97a02fc2/scripts/slave/recipe_modules/chromium_tests/trybots.py
[modify] https://crrev.com/74622760bfd7c35ac31fc9a45f1553fd97a02fc2/masters/master.tryserver.chromium.angle/master.cfg

Blockedon: 786745
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa7c5b3eb449ed5db1cf07d54375cd127e04441c

commit aa7c5b3eb449ed5db1cf07d54375cd127e04441c
Author: Jamie Madill <jmadill@chromium.org>
Date: Tue Nov 21 19:57:50 2017

Add new ANGLE compile-only configs to mb.pyl.

Bug:  786044 
Change-Id: I289799d50bbca3adb8ed50f7fb7141ed600a910a
Reviewed-on: https://chromium-review.googlesource.com/782405
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518344}
[modify] https://crrev.com/aa7c5b3eb449ed5db1cf07d54375cd127e04441c/tools/mb/mb_config.pyl

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/cc93cebf275a37e2f271f4856d7f13fc7eb3c1ad

commit cc93cebf275a37e2f271f4856d7f13fc7eb3c1ad
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Nov 22 00:16:44 2017

Update cq.cfg for new compile-only builders.

This removes the x64 versions of the Windows tests from the ANGLE CQ.
They are still available to run as optional try jobs, if we suspect
a failure. This should reduce the amount of test duplication while
still keeping complete coverage.

It also updates the Clang builder to the MSVC builder, since Chrome
has switched to Clang by default on Windows, and the clang builder
was a deprecated version of the MSVC builder anyway.

Bug:  chromium:786044 
Change-Id: I786fe85dcdaa57b55b0b44244797c9285c577ea2
Reviewed-on: https://chromium-review.googlesource.com/782402
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/cc93cebf275a37e2f271f4856d7f13fc7eb3c1ad/infra/config/cq.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/cce013c9b61466dd6571901aee44c7a04d5ab613

commit cce013c9b61466dd6571901aee44c7a04d5ab613
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Nov 22 00:42:37 2017

Revert "Update cq.cfg for new compile-only builders."

This reverts commit cc93cebf275a37e2f271f4856d7f13fc7eb3c1ad.

Reason for revert: There was a typo in mb_config.py.

https://build.chromium.org/deprecated/tryserver.chromium.angle/builders/win_angle_compile_x64_dbg_ng/builds/0/steps/analyze/logs/stdio

MBErr: Builder name "win_angle_compile_x64_dbg_ng"  not found under masters[tryserver.chromium.angle] in "E:\b\c\b\win\src\tools\mb\mb_config.pyl"

Original change's description:
> Update cq.cfg for new compile-only builders.
> 
> This removes the x64 versions of the Windows tests from the ANGLE CQ.
> They are still available to run as optional try jobs, if we suspect
> a failure. This should reduce the amount of test duplication while
> still keeping complete coverage.
> 
> It also updates the Clang builder to the MSVC builder, since Chrome
> has switched to Clang by default on Windows, and the clang builder
> was a deprecated version of the MSVC builder anyway.
> 
> Bug:  chromium:786044 
> Change-Id: I786fe85dcdaa57b55b0b44244797c9285c577ea2
> Reviewed-on: https://chromium-review.googlesource.com/782402
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,tandrii@chromium.org

Change-Id: If13d3d69f0a1facd3876858afdaf0577f6ab1cb7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:786044 
Reviewed-on: https://chromium-review.googlesource.com/784070
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/cce013c9b61466dd6571901aee44c7a04d5ab613/infra/config/cq.cfg

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c44ebeca296281c296f2e8526577354164e8beb

commit 5c44ebeca296281c296f2e8526577354164e8beb
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Nov 22 00:56:47 2017

Fix ANGLE bot typo in mb_config.pyl.

'win_angle_x64_compile_dbg_ng' -> 'win_angle_compile_x64_dbg_ng'

Bug:  786044 
Change-Id: I6239a3ea32cd983367b6e9acacf31193555f2660
Tbr: jbudorick@chromium.org
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/783992
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518477}
[modify] https://crrev.com/5c44ebeca296281c296f2e8526577354164e8beb/tools/mb/mb_config.pyl

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/6e94c455c0589dd822bce754b7400adafc27bcb0

commit 6e94c455c0589dd822bce754b7400adafc27bcb0
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed Nov 22 03:49:18 2017

Reland "Update cq.cfg for new compile-only builders."

This is a reland of cc93cebf275a37e2f271f4856d7f13fc7eb3c1ad

Re-landing after mb_config.pyl fix.

Original change's description:
> Update cq.cfg for new compile-only builders.
>
> This removes the x64 versions of the Windows tests from the ANGLE CQ.
> They are still available to run as optional try jobs, if we suspect
> a failure. This should reduce the amount of test duplication while
> still keeping complete coverage.
>
> It also updates the Clang builder to the MSVC builder, since Chrome
> has switched to Clang by default on Windows, and the clang builder
> was a deprecated version of the MSVC builder anyway.
>
> Bug:  chromium:786044 
> Change-Id: I786fe85dcdaa57b55b0b44244797c9285c577ea2
> Reviewed-on: https://chromium-review.googlesource.com/782402
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug:  chromium:786044 
Change-Id: I85d1fe95d12a29e91755303423dd151450bb6a3b
Reviewed-on: https://chromium-review.googlesource.com/784232
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/6e94c455c0589dd822bce754b7400adafc27bcb0/infra/config/cq.cfg

Status: Fixed (was: Assigned)
All current work complete. Will re-open a new issue for further improvements.

Sign in to add a comment